From: "Singh, Jasvinder" <jasvinder.singh@intel.com>
To: "Yu, DapengX" <dapengx.yu@intel.com>,
"Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v4] net/softnic: fix memory leak in parsing arguments
Date: Fri, 16 Jul 2021 12:04:36 +0000 [thread overview]
Message-ID: <BN9PR11MB52585479E5D890830CB54042E0119@BN9PR11MB5258.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210715053814.978200-1-dapengx.yu@intel.com>
> -----Original Message-----
> From: Yu, DapengX <dapengx.yu@intel.com>
> Sent: Thursday, July 15, 2021 6:38 AM
> To: Singh, Jasvinder <jasvinder.singh@intel.com>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>
> Cc: dev@dpdk.org; Yu, DapengX <dapengx.yu@intel.com>; stable@dpdk.org
> Subject: [PATCH v4] net/softnic: fix memory leak in parsing arguments
>
> From: Dapeng Yu <dapengx.yu@intel.com>
>
> In function pmd_parse_args(), firmware path is duplicated from device
> arguments as character string, but is never freed, which cause memory leak.
>
> This patch changes the type of firmware member of struct pmd_params to
> character array, to make memory resource release unnecessary, and
> changes the type of name member to character array, to keep the
> consistency of character string handling in struct pmd_params.
>
> Fixes: 7e68bc20f8c8 ("net/softnic: restructure")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>
> ---
Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>
next prev parent reply other threads:[~2021-07-16 12:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 8:44 [dpdk-stable] [PATCH] " dapengx.yu
2021-07-13 8:44 ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
2021-07-13 10:08 ` [dpdk-stable] [PATCH v2] " dapengx.yu
2021-07-13 10:10 ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
2021-07-14 5:47 ` [dpdk-stable] [PATCH v3] " dapengx.yu
2021-07-14 11:07 ` Singh, Jasvinder
2021-07-15 1:42 ` Yu, DapengX
2021-07-15 5:38 ` [dpdk-stable] [PATCH v4] " dapengx.yu
2021-07-16 12:04 ` Singh, Jasvinder [this message]
2021-07-23 8:11 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR11MB52585479E5D890830CB54042E0119@BN9PR11MB5258.namprd11.prod.outlook.com \
--to=jasvinder.singh@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dapengx.yu@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).