From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 53107A0C47
for <public@inbox.dpdk.org>; Mon, 26 Jul 2021 08:26:14 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id D0F55410EE;
Mon, 26 Jul 2021 08:26:13 +0200 (CEST)
Received: from NAM02-DM3-obe.outbound.protection.outlook.com
(mail-dm3nam07on2073.outbound.protection.outlook.com [40.107.95.73])
by mails.dpdk.org (Postfix) with ESMTP id D962040DDA;
Mon, 26 Jul 2021 08:26:10 +0200 (CEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=ZZZjcEC3atuqvldnbVlVegYWGvo9reLWNLzbTncSPJwjMCBuvSQSk4g2hW4uCcHfwS7X2DcIpGT3dWmVM5kH9VAKJxd+sK3rUhajX23nClc9STUOcYHK6QTv0J/NMuNRtqmqDkGpaZRkAdYAF8WZZZ+fuN4dNl8weErvQHbpgpEgTLdHYDcA1p+4WRdwdj8kzF1oUXzJrg2Xn5ftnmZYUvD+12frn8QqnSFb4jcL2sVhI3FxZYIcp0uLkuUYefsEcB/Qc7eVRZpwuNJUl81Etvl1WD7gRb04/Kv5k+8iwuVR3FaF/Apglb2C7uzWcrimRAjZEhHIpRV3325RUXbzPA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=0Up5yU4OLi6bgeWnxu5etpvIJcUEQiud29lZdGqGj1k=;
b=IeU/S8cJSfVpMJ0Ubps9D06wHHFR0GIW/hf5WED9LMKTSvAHZni5Hr/evu63HG/8DyIG9IJMn4Ir4Cf0h3/aL2JOnDog93eTiBZtEK+wHzNQDReoMDLuGGzNN+esPc8qqTdjkG/RCFjJYEtq1k6iD9js/za/oUQka6yTwezWfTCpzSzBsIhowP8AkW1cOpafAJ31c6sqDbZcDu5UWBf0PRzojJLQCNiZxBQn9qkl9hnhXMuW+43Tv6l6AqpbsuoQeHlwlZzdb09ABdv/nuWtiRSXyQx5fbzPclic3tGUusm6lu6CS97xqhSmUF8KECpNw+BxZc+TDcUrC8bnmPwpfw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
s=selector2;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=0Up5yU4OLi6bgeWnxu5etpvIJcUEQiud29lZdGqGj1k=;
b=boBzpsI3jztDfzijSS781rCIxMgMco6ZJZhiB2nFwv9wJeHI5/nWgzY/KgiOmj14VKzeg8y5AlscVHgSX92vaL5uY1QVmVqy2qbwH8EJ9tqhMTJ062BXkVBOEes31UQSIZtGWj1mANj9x0U7RuBnXmSPgQjKmHzI0KWUMbqT1VqojRkzze4eR9+gNdXr/T1fm1L2npb9X3mE1OjJtIaweUjR4ocsCmXp/avRCYoeF8/fe3jHJyP78iAFme60NMKBGJ5t9lxjGayHI5zOJtNNZvLl/DYrYfW34ISiGIae52sTxbqP8kf5V9I+/vMmv00wIlU4gNYUtVVKxegoYAJgEw==
Received: from BN9PR12MB5034.namprd12.prod.outlook.com (2603:10b6:408:104::17)
by BN9PR12MB5180.namprd12.prod.outlook.com (2603:10b6:408:11d::22)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.29; Mon, 26 Jul
2021 06:26:08 +0000
Received: from BN9PR12MB5034.namprd12.prod.outlook.com
([fe80::29b3:651c:7f0:4756]) by BN9PR12MB5034.namprd12.prod.outlook.com
([fe80::29b3:651c:7f0:4756%6]) with mapi id 15.20.4352.031; Mon, 26 Jul 2021
06:26:08 +0000
From: "Jiawei(Jonny) Wang" <jiaweiw@nvidia.com>
To: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>, Slava Ovsiienko
<viacheslavo@nvidia.com>
CC: Matan Azrad <matan@nvidia.com>, Ori Kam <orika@nvidia.com>, Shahaf Shuler
<shahafs@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>, Raslan Darawsheh
<rasland@nvidia.com>, "stable@dpdk.org" <stable@dpdk.org>
Thread-Topic: [PATCH] net/mlx5: fix mirror flow split with L3 encapsulation
Thread-Index: AQHXf8I/8ZzLaBZ6SEKIjcpYUB2B2atQkqTggAAGkwCABDTnMA==
Date: Mon, 26 Jul 2021 06:26:08 +0000
Message-ID: <BN9PR12MB503430890715CF1DF474285EC6E89@BN9PR12MB5034.namprd12.prod.outlook.com>
References: <20210723124338.18269-1-jiaweiw@nvidia.com>
<5536161.f2duC4C3qX@thomas>
<BN9PR12MB5034F2C47F90F4214310FB68C6E59@BN9PR12MB5034.namprd12.prod.outlook.com>
<3136964.cCNWhMJKoI@thomas>
In-Reply-To: <3136964.cCNWhMJKoI@thomas>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: monjalon.net; dkim=none (message not signed)
header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 5b407e8b-b63e-47db-6607-08d94ffe414e
x-ms-traffictypediagnostic: BN9PR12MB5180:
x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <BN9PR12MB51806073212D8709FB6941C7C6E89@BN9PR12MB5180.namprd12.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: SxZLcsQ/lUtaBrl1nQ/fDwYPbEZ39cSfHaMZGI1jOpa72tE3W4lNH4efMFcVyYEmoJGNncIXmLlIyIxC7wCYDBBPMawwbaWoW80DSJsxRGB6B0BXsx9qQlmnyezb5JzjTBQf889sdmyT5JWwMBKDRVax6w4TWmGepDwpXId5KmviUbQOaYKbck7Kv4nBWckAAJJ4F5djzLcKFu0TQNicdQg9AJ9fgoHjDB7HWsW+VuIH1nvYzLGhC6TOo6avduKKInqWKGxU3iIer4cQRsDPqn5ayU1z0qXZRvxAEFlL9e6i/ZaEfjxqeZ3dsTRPcQ76wcShWn83ZhkGs+/pbZuzlYO/li2FeOyB8P7otvmFRqP8gvZViDwl3FmaebUsWkaEUvmGC6tC0YcMmgOKUT2bsfllpwrVxaGw6WLsATVTZy4xG1YDpV1/GkjzvHa8S6O0bJeeN4pYNjZtiQG4QL3zP2eO9XcMt7fpNN1ojm4gaRXISRXmhCq/GMPx/MDzrrJ+a0jS45DGJ7dzko7e/qLKx58N8vMD2aF6eJZsoQNn5R7fXm5S8+YVK3mCdCLforK7njYTfTX5i+3Mxu0SOLh/IF+Q7SjtZfdGJ31pMVBG7tzkxwj2yvXeAD0pw6BVf4UZbW+Ru1wEzgXyHFXBwfN+laJ9/VrvEZlR+W0yiAffD2/yn3pM6t0lWDx2RGDrIpeK5NNblPibhxSO3t+MKKw50xxWF+CVuDvO83URzvtnGlgy8VBscwYQQ3xya9lnSZhpBBktLI+QERQZsTIdDXF/WJFBqRmOim5IwAtil5ncagM=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:BN9PR12MB5034.namprd12.prod.outlook.com; PTR:; CAT:NONE;
SFS:(4636009)(136003)(366004)(376002)(39860400002)(396003)(346002)(966005)(316002)(54906003)(33656002)(66446008)(186003)(8676002)(66946007)(66476007)(66556008)(55016002)(64756008)(26005)(6636002)(76116006)(9686003)(8936002)(53546011)(86362001)(71200400001)(7696005)(52536014)(2906002)(122000001)(83380400001)(4326008)(478600001)(38100700002)(110136005)(6506007)(5660300002)(38070700004);
DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bxH5tfE1pFGAspdNXS4H3K6bJRV8faJehZKe6vT6zIpKjA67erENKngfx9KS?=
=?us-ascii?Q?uLrMdpV71YbUV5SLfO4kS1bX4NRf4o7zBTZ2qcI/M0rQA2/NYmdLYAX0QYUO?=
=?us-ascii?Q?1C2n2c1j4/edFQeAovsxLWzw7TJIIcLAGL1ZOcdAlhE+inmdSviM4ujs5q2R?=
=?us-ascii?Q?vfba5Ea3QKohLee4R/zxjENvSl8HJC1NHF+4FDQBtpV5i9f6K2ud9HinMKyr?=
=?us-ascii?Q?sCn2knfLUEyye3U2VzhTFejfAyJ5aaNDGeLCdNhXZtwK0iAGuz/3D1HdlC53?=
=?us-ascii?Q?QLUzCoCiPVhW/LIENbg6xezOI8IO+elRSpZdo29tQG50DB0VkrWvx3FHeymR?=
=?us-ascii?Q?ntDZhiMmz6cL5RlpRdZX96BTjgmQ44Ll0ezy9ygSWbCfEYrH2/P3kixsH0zq?=
=?us-ascii?Q?G+0CHHbDi3eLL9P1B+JIrT7NvqYUIAT1B+Y1Wi+GKZ87FdeoRaokb05BJ54P?=
=?us-ascii?Q?xuRGHy8bjAebPhf3vt2G581+gAvO+SGbPU5WsdAuEwP7vt0e8MIXlwRRYH4Z?=
=?us-ascii?Q?+fQ/kDMkoxGCJH6ejVsoB/3gf2445F+ydzn/sBmcUXnO3bC3gnWlWwrb4Xi/?=
=?us-ascii?Q?LzgLrsWyP4Ochh8hJUDU0lUZDVxZIPHeI7aClAIP6uByXdkuPgLbGfh6gX1g?=
=?us-ascii?Q?5MeBs46lo85IAx8tu7KwUpbBCjBp+SR27u6k94azrZhdlks5Q9hvE1XuwN4u?=
=?us-ascii?Q?xu7k8BbV05MVRIE5ovr496PmuEM8eXvTcfoKvbCpWu2lLh0POjsd6IRxSWLB?=
=?us-ascii?Q?FacmOjXUQSS5hLJyuIUluT4t6XrNf020SBn33sJCXIXDKMjs12+6KSVRSMgw?=
=?us-ascii?Q?6sA5YMWkpzP6ROmLhcgRgszH0m9KRTLrn00YK9av3IaXcjESz3fM9aUnmj2f?=
=?us-ascii?Q?JX21kXgQtuh2PVhMInFUFDaVtT0UG2ik1zxm8JDPnPq6NMu97Ng6yoaJoFqy?=
=?us-ascii?Q?JMwUs8G4tAgbPtlVJYEyksIMgn6KeyO8LhYgxsnXX+m+f4bc/N45WoVD5nXi?=
=?us-ascii?Q?NEna9pg04dyTnpMz/pAZbHJ6KofLV2Lh71BV8Q9rAQKlgfvLWeDs+YTdHY6x?=
=?us-ascii?Q?4M1OyrzGtJoPUg7DgpIAxBQZafiPp8K8PVTeztto8K2FYWm5k4fqNBo5zmxr?=
=?us-ascii?Q?0vQZ92JaqnpFbD85oBKS/mJdnfbOAOoPaJW/yLebPrgbonPOYLY0YkTKwV86?=
=?us-ascii?Q?s61klvp6ODS/cS8mqQ+KIiZ4aZO9bN4xAJY7N77PDtznpCIGysVkdzNl5su9?=
=?us-ascii?Q?Ne2uKTBjtjeNh84EB2AldA0UcLjHrdldb+uNZ6FZ1IAUOyfKJGLZ1yqgl1bT?=
=?us-ascii?Q?5tj1zPF6Ufwx9oiznn1POiZy?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5034.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5b407e8b-b63e-47db-6607-08d94ffe414e
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2021 06:26:08.4027 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: MfRG8Hww8wJpJj5SkM2YQ/Ie8FC0v9qSIN3qM/hcRR68d4OLkEf0t9JwOFoApXKSAQ0DhINwF3rg08C8H8lG8Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5180
Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix mirror flow split with L3
encapsulation
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Friday, July 23, 2021 10:10 PM
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; Jiawei(Jonny) Wang
> <jiaweiw@nvidia.com>
> Cc: Matan Azrad <matan@nvidia.com>; Ori Kam <orika@nvidia.com>;
> Shahaf Shuler <shahafs@nvidia.com>; dev@dpdk.org; Raslan Darawsheh
> <rasland@nvidia.com>; stable@dpdk.org
> Subject: Re: [PATCH] net/mlx5: fix mirror flow split with L3 encapsulatio=
n
>=20
> 23/07/2021 16:01, Jiawei(Jonny) Wang:
> > Hello,
> >
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > 23/07/2021 14:43, Jiawei Wang:
> > > > Due to hardware limitations, the decap action can't follow the
> > >
> > > Which decap action? Pleas be more specific.
> >
> > All of decap, vxlan_decap, nvgre_decap and raw_decap.
> > Will update details.
> >
> > >
> > > > sample action in the same flow, to keep the original action order
> > > > of sample and decap actions the flow was internally split by PMD,
> > > > and decap action was moved into suffix subflow in the new table.
> > >
> > > "the" new table? which one?
> >
> > " sample and decap actions the flow was internally split by PMD, "
> > means that PMD split internally into two flows:prefix subflow with
> > sample action in original table; suffix subflow with decap action in
> > the new table;
> >
> > >
> > > Was there an issue? Above seems to say all is fine.
> > >
> >
> > The issue is mentioned below that 'L3 encapsulation' case
> > (raw_decap+raw_encap), the previous code not consier the combination
> decap/encap case.
> > And under this case flow don't need split.
> >
> > > > There is a specific combination of raw decap and raw encap actions
> > > > to specify "L3 encapsulation" packet transformation - raw decap
> > > > action to remove L2 header and raw encap to add the tunnel header.
> > >
> > > Is this combination the problem? It was not working before this patch=
?
> > > Please describe what happened.
> > >
> >
> > L3 encap is working without sample action or sample is working without
> > L3 encap;
>=20
> OK please be more explicit in the next version.
>=20
The v2 patch is ready, https://patchwork.dpdk.org/project/dpdk/patch/202107=
26062233.30657-1-jiaweiw@nvidia.com/
Please help to review, and Thanks your comments.
> > > > This specific L3 encapsulation is encoded as a single packet
> > > > reformat hardware transaction and is supported by hardware after
> > > > sample action (no hardware limitations for packet reformat).
> > > >
> > > > The patch checks whether the decap action is the part of "L3
> > > encapsulation"
> > >
> > > I think you mean "is part of".
> >
> > Thanks, will fix in new version.
> >
> > >
> > > > and does not move the decap action into suffix subflow for the case=
.
> > > >
> > > > Fixes: cafd87f62a06 ("net/mlx5: fix VLAN push/pop and decap
> > > > actions with mirror")
> > > > Cc: stable@dpdk.org
> > > >
> > > > Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>
> > > > Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
>=20
>=20