From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB133A00BE for ; Tue, 19 May 2020 11:31:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 866161D404; Tue, 19 May 2020 11:31:26 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 1876F1C2A3; Tue, 19 May 2020 11:31:22 +0200 (CEST) IronPort-SDR: LmxD06CTQaWz8VoZPmcj7as8uM2CSLcUbsiJb37H3zq0jqk8+BCYHdglXEQb0O6+isza7FCrmo ATXKIFBwtRng== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2020 02:31:22 -0700 IronPort-SDR: uUOq2f0QjJqZ2BdKz2E3pqKrbPilPaGuN75f4ipILMmZ8v1qwTXGpewE/+SiBAN7eqGfY/OYV7 XgT+5VL2JgHw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,409,1583222400"; d="scan'208";a="253190814" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by orsmga007.jf.intel.com with ESMTP; 19 May 2020 02:31:21 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 19 May 2020 02:31:21 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 19 May 2020 02:31:21 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 19 May 2020 02:31:21 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 19 May 2020 02:31:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kKk+couninqe2Ft1hZ77Qx4Ha/OQ9FZRyHQkmO5F12Wjs7mZbdf+PxQeDxm5zD2peezi8h3RHm4JnIfViVL3De+O+heNM7soL8s6AYbsS4frytNHKRtBBu9YyoZx3ovStglf7krcODSKQZuZplqn+qCWtzZ4EOPXjXS/wQkIY2lPWFXVwH3rzcqFXaiHXVdVS5yrNkVo+p9+lQMvRVkXOLF+yGCMVpYfq5fv8BeWv34olPGhn/37+dmzSfKV2S7F+NEeiVz/Zxa1DEKtyirMQrRMnsc/QwIK8va+DaKaHKPGWBA9QlRh5MUaR2BQpm3f77CxfHZoRPK108+vo/N+Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=raipm2BfzQMU57XyA//FNB4BT/QAaAlZw7FXuNwKumE=; b=dAErL9dZh8a4ugWwfYt+EKCjGi/u9f59se4o0OTy5lT7MXKdOFKkDqGv+xkdAkEgmk3GfxemVbFZ6TQlkkPsrdUiME+iFLjRiwU2igXKDwT/pYTgelZUqCZLeBo7pqcd3tiNnDeQzZKfmcCzRhW/nfmKDYfcHP9swWcxeJdHWTNbDEB1PP10GolFvxhLfqmMYpZWV0U9oQz/VeVflsV2fWjjs1F+4k4CZfXurg3+S6Mq1K/NEwVdFfm7oVrFIUv2gd6rB8Zms4AKAG//MzLMT2s4pLeNolIsa1gCLDqzszQBicey8+wnfB3YQ4b4uY5pUmA3bLAihdH7wmjdauBhCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=raipm2BfzQMU57XyA//FNB4BT/QAaAlZw7FXuNwKumE=; b=FS+0z1UtaK6hveTKiS0PfRMYbd7U1XZhLBVwDnD3Kl1LJC1nYvgzDVdrpnFfMln8xO7AbLyAIMCxGBpTo1lzxDseAeZLiInKscRdfFGWrxHedmP4AcVRxD0sReIOMpfb2q0GKrrXJ/t2B3vrkqpZ4MvD2cRcclZzUEtI5Q8We0w= Received: from BY5PR11MB3910.namprd11.prod.outlook.com (2603:10b6:a03:185::13) by BY5PR11MB4103.namprd11.prod.outlook.com (2603:10b6:a03:18c::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.26; Tue, 19 May 2020 09:31:19 +0000 Received: from BY5PR11MB3910.namprd11.prod.outlook.com ([fe80::ad60:fbb0:b236:3679]) by BY5PR11MB3910.namprd11.prod.outlook.com ([fe80::ad60:fbb0:b236:3679%6]) with mapi id 15.20.3000.034; Tue, 19 May 2020 09:31:19 +0000 From: "Dybkowski, AdamX" To: Anoob Joseph , "dev@dpdk.org" , "Trahe, Fiona" , "akhil.goyal@nxp.com" CC: "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] cryptodev: fix SHA-1 digest enum comment Thread-Index: AQHWLSJA9WVDZ3fDfU2N/A1hQlliZKiu6YiAgAA79nA= Date: Tue, 19 May 2020 09:31:19 +0000 Message-ID: References: <20200518142342.1987-1-adamx.dybkowski@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [79.184.238.8] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d17c905c-d5b4-412d-f36b-08d7fbd76300 x-ms-traffictypediagnostic: BY5PR11MB4103: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 040866B734 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aD2B1L90gewa1LNAyHzPu06oaNoRu9fkSnWjEjE7GOgxL+aVnS6LHqdbiF4zHFEab545Gc4bkbBUTrrglgKUtHjCbYzSAf9buO94dsjPurMb2qSDZcjxHqqL2N/ZM70cU0ZB3aEf5tu6ofQ1v8Pn7AA6U+rOU9CS41E2VutIRaWnm/LmmIKggY2EJmQpW5FZpZg9Pz150ajb6RrQti+ll7z1Ys509bgEFMN4iasPKWT+yvtPZYVX+ZDdcs0eHjcm5xbCyVWwFGPo2IZns78Wn/c7urFjOI4dpcR2gjVwA4azcy6kd2pK+VPv1GHOzcYSw8wixvVpE708nEAg3hnbqKM41w+up3d9giXUieCLZxPPgDK2tgT2OHLeNo16EILMkjjbDPS/e0EUhPzpmorq9RBiWzFUy8IrUWgvBr9/bYvPUKuLueZU8MPTpkyFkqTyy7802apqXE0l2CuHWi6qMKdWekvfVRCXOZeADBYHDG7BzbEgZMqmM5dzGCrnxucZubJfQUitSQiGtw3VK4wR1A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB3910.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(366004)(136003)(346002)(396003)(39860400002)(376002)(478600001)(7696005)(66446008)(55016002)(64756008)(66556008)(66946007)(66476007)(76116006)(4326008)(26005)(9686003)(8676002)(186003)(8936002)(86362001)(52536014)(53546011)(6506007)(33656002)(71200400001)(316002)(2906002)(110136005)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: cGolKQ1uz1o52VTjq/iN7eHY1Jyy1SWvGRPyNnLV6hYGjv3V16ib1aQtgIPBKrylng+3Kh1L/iZnkDgwZS+zQfTkrQI8BnTj7o+FZMVHhQoesxMgC9Fmx4vyDikiEwNQV+JMtEypmTyt/hQkmJHjx4Gf8lsq+PKb3H4dLOz/n3PV7zayrlGY7/k1rqjRDTAmanxywPAO1rMA68Lf7MYd0VSeSFX5rWqfryOwR4V+38xED0HvCB3iCGreHLJWkDIrpM/3vaMgGxPomgJvcDn7oLXQAlo7MAW0KVH/mPdSV8HrY7sDlg2To3P4wujyZ7cF5QanO8gGUE9i+0iUZNOYqjwrntI7paURNQ0H2Wkb8KJj9I8ck/Q+LgnFVcbdF+eaBod8Ktna0HtHc0Y+d2JBqhTI6FSV4fahrVfI06gzDPNa2cl1E2TIRyuabng680MBrIuMNtCJaH+li8Dhl/d3bCMtsfepQ5M/QFD+52HN2zo= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: d17c905c-d5b4-412d-f36b-08d7fbd76300 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2020 09:31:19.1972 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dEf9UWXkOG/LrVhextXFUkGW4WbpEnPct7RgJ73GPX3Uc0FDPAHKhKU3JUMRacKCC84DGqFWhPrrUKNxUNKXEUrvvV6u9kISvaAujwreuH4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4103 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] cryptodev: fix SHA-1 digest enum comment X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi. My answer below. Adam > -----Original Message----- > From: Anoob Joseph > Sent: Tuesday, 19 May, 2020 07:54 > To: Dybkowski, AdamX ; dev@dpdk.org; > Trahe, Fiona ; akhil.goyal@nxp.com > Cc: stable@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] cryptodev: fix SHA-1 digest enum comment >=20 > Hi Adam, Akhil, >=20 > Please see inline. >=20 > Thanks, > Anoob >=20 > > -----Original Message----- > > From: dev On Behalf Of Adam Dybkowski > > Sent: Monday, May 18, 2020 7:54 PM > > To: dev@dpdk.org; fiona.trahe@intel.com; akhil.goyal@nxp.com > > Cc: Adam Dybkowski ; stable@dpdk.org > > Subject: [dpdk-dev] [PATCH] cryptodev: fix SHA-1 digest enum comment > > > > This patch fixes improper SHA-1 digest size in the enum comment. > > > > Fixes: 1bd407fac80b ("cryptodev: extract symmetric operations") > > Cc: stable@dpdk.org > > > > Signed-off-by: Adam Dybkowski > > --- > > lib/librte_cryptodev/rte_crypto_sym.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/lib/librte_cryptodev/rte_crypto_sym.h > > b/lib/librte_cryptodev/rte_crypto_sym.h > > index d9585ecd6..9cea4e5f0 100644 > > --- a/lib/librte_cryptodev/rte_crypto_sym.h > > +++ b/lib/librte_cryptodev/rte_crypto_sym.h > > @@ -269,9 +269,9 @@ enum rte_crypto_auth_algorithm { > > /**< HMAC using MD5 algorithm */ > > > > RTE_CRYPTO_AUTH_SHA1, > > - /**< 128 bit SHA algorithm. */ > > + /**< 160 bit SHA algorithm. */ > > RTE_CRYPTO_AUTH_SHA1_HMAC, > > - /**< HMAC using 128 bit SHA algorithm. */ > > + /**< HMAC using 160 bit SHA algorithm. */ >=20 > [Anoob] This raises one interesting question. Is HMAC-SHA-1-96 > (https://tools.ietf.org/html/rfc2404) treated as a separate algorithm or = is it a > digest size variant of RTE_CRYPTO_AUTH_SHA1_HMAC? I assume the later. [Adam] DPDK doesn't have separate enums for such variations. According to R= FC 2104, chapter "5. Truncated output", the calculation of HMAC-SHA-1-96 is= done using ordinary HMAC-SHA-1, but the calculation result is then truncat= ed to 96 bits, or any other digest size provided in auth xform. >=20 > > RTE_CRYPTO_AUTH_SHA224, > > /**< 224 bit SHA algorithm. */ > > RTE_CRYPTO_AUTH_SHA224_HMAC, > > -- > > 2.17.1