* [dpdk-stable] [PATCH v1] raw/ifpga: fix ifpga device name format
@ 2021-04-22 8:27 Wei Huang
2021-04-22 11:13 ` Xu, Rosen
2021-04-28 9:26 ` Ferruh Yigit
0 siblings, 2 replies; 4+ messages in thread
From: Wei Huang @ 2021-04-22 8:27 UTC (permalink / raw)
To: dev, rosen.xu, qi.z.zhang; +Cc: stable, tianfei.zhang, ferruh.yigit, Wei Huang
The device name format used in ifpga_rawdev_create() was changed to
"IFPGA:%02x:%02x.%x", but the format used in ifpga_rawdev_destroy()
was left as "IFPGA:%x:%02x.%x", it should be changed synchronously.
Fixes: 9c006c45d0c5 ("raw/ifpga: scan PCIe BDF device tree")
Cc: stable@dpdk.org
Signed-off-by: Wei Huang <wei.huang@intel.com>
---
drivers/raw/ifpga/ifpga_rawdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c
index d9a46ef915..f591a87b49 100644
--- a/drivers/raw/ifpga/ifpga_rawdev.c
+++ b/drivers/raw/ifpga/ifpga_rawdev.c
@@ -1551,7 +1551,7 @@ ifpga_rawdev_destroy(struct rte_pci_device *pci_dev)
}
memset(name, 0, sizeof(name));
- snprintf(name, RTE_RAWDEV_NAME_MAX_LEN, "IFPGA:%x:%02x.%x",
+ snprintf(name, RTE_RAWDEV_NAME_MAX_LEN, "IFPGA:%02x:%02x.%x",
pci_dev->addr.bus, pci_dev->addr.devid, pci_dev->addr.function);
IFPGA_RAWDEV_PMD_INFO("Closing %s on NUMA node %d",
--
2.29.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-stable] [PATCH v1] raw/ifpga: fix ifpga device name format 2021-04-22 8:27 [dpdk-stable] [PATCH v1] raw/ifpga: fix ifpga device name format Wei Huang @ 2021-04-22 11:13 ` Xu, Rosen 2021-04-25 2:07 ` Zhang, Qi Z 2021-04-28 9:26 ` Ferruh Yigit 1 sibling, 1 reply; 4+ messages in thread From: Xu, Rosen @ 2021-04-22 11:13 UTC (permalink / raw) To: Huang, Wei, dev, Zhang, Qi Z; +Cc: stable, Zhang, Tianfei, Yigit, Ferruh Hi, > -----Original Message----- > From: Huang, Wei <wei.huang@intel.com> > Sent: Thursday, April 22, 2021 16:27 > To: dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>; Zhang, Qi Z > <qi.z.zhang@intel.com> > Cc: stable@dpdk.org; Zhang, Tianfei <tianfei.zhang@intel.com>; Yigit, Ferruh > <ferruh.yigit@intel.com>; Huang, Wei <wei.huang@intel.com> > Subject: [PATCH v1] raw/ifpga: fix ifpga device name format > > The device name format used in ifpga_rawdev_create() was changed to > "IFPGA:%02x:%02x.%x", but the format used in ifpga_rawdev_destroy() was > left as "IFPGA:%x:%02x.%x", it should be changed synchronously. > > Fixes: 9c006c45d0c5 ("raw/ifpga: scan PCIe BDF device tree") > Cc: stable@dpdk.org > > Signed-off-by: Wei Huang <wei.huang@intel.com> > --- > drivers/raw/ifpga/ifpga_rawdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/raw/ifpga/ifpga_rawdev.c > b/drivers/raw/ifpga/ifpga_rawdev.c > index d9a46ef915..f591a87b49 100644 > --- a/drivers/raw/ifpga/ifpga_rawdev.c > +++ b/drivers/raw/ifpga/ifpga_rawdev.c > @@ -1551,7 +1551,7 @@ ifpga_rawdev_destroy(struct rte_pci_device > *pci_dev) > } > > memset(name, 0, sizeof(name)); > - snprintf(name, RTE_RAWDEV_NAME_MAX_LEN, > "IFPGA:%x:%02x.%x", > + snprintf(name, RTE_RAWDEV_NAME_MAX_LEN, > "IFPGA:%02x:%02x.%x", > pci_dev->addr.bus, pci_dev->addr.devid, pci_dev- > >addr.function); > > IFPGA_RAWDEV_PMD_INFO("Closing %s on NUMA node %d", > -- > 2.29.2 Acked-by: Rosen Xu <rosen.xu@intel.com> ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [PATCH v1] raw/ifpga: fix ifpga device name format 2021-04-22 11:13 ` Xu, Rosen @ 2021-04-25 2:07 ` Zhang, Qi Z 0 siblings, 0 replies; 4+ messages in thread From: Zhang, Qi Z @ 2021-04-25 2:07 UTC (permalink / raw) To: Xu, Rosen, Huang, Wei, dev; +Cc: stable, Zhang, Tianfei, Yigit, Ferruh > -----Original Message----- > From: Xu, Rosen <rosen.xu@intel.com> > Sent: Thursday, April 22, 2021 7:13 PM > To: Huang, Wei <wei.huang@intel.com>; dev@dpdk.org; Zhang, Qi Z > <qi.z.zhang@intel.com> > Cc: stable@dpdk.org; Zhang, Tianfei <tianfei.zhang@intel.com>; Yigit, Ferruh > <ferruh.yigit@intel.com> > Subject: RE: [PATCH v1] raw/ifpga: fix ifpga device name format > > Hi, > > > -----Original Message----- > > From: Huang, Wei <wei.huang@intel.com> > > Sent: Thursday, April 22, 2021 16:27 > > To: dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>; Zhang, Qi Z > > <qi.z.zhang@intel.com> > > Cc: stable@dpdk.org; Zhang, Tianfei <tianfei.zhang@intel.com>; Yigit, > > Ferruh <ferruh.yigit@intel.com>; Huang, Wei <wei.huang@intel.com> > > Subject: [PATCH v1] raw/ifpga: fix ifpga device name format > > > > The device name format used in ifpga_rawdev_create() was changed to > > "IFPGA:%02x:%02x.%x", but the format used in ifpga_rawdev_destroy() > > was left as "IFPGA:%x:%02x.%x", it should be changed synchronously. > > > > Fixes: 9c006c45d0c5 ("raw/ifpga: scan PCIe BDF device tree") > > Cc: stable@dpdk.org > > > > Signed-off-by: Wei Huang <wei.huang@intel.com> > > --- > > drivers/raw/ifpga/ifpga_rawdev.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/raw/ifpga/ifpga_rawdev.c > > b/drivers/raw/ifpga/ifpga_rawdev.c > > index d9a46ef915..f591a87b49 100644 > > --- a/drivers/raw/ifpga/ifpga_rawdev.c > > +++ b/drivers/raw/ifpga/ifpga_rawdev.c > > @@ -1551,7 +1551,7 @@ ifpga_rawdev_destroy(struct rte_pci_device > > *pci_dev) > > } > > > > memset(name, 0, sizeof(name)); > > -snprintf(name, RTE_RAWDEV_NAME_MAX_LEN, "IFPGA:%x:%02x.%x", > > +snprintf(name, RTE_RAWDEV_NAME_MAX_LEN, > > "IFPGA:%02x:%02x.%x", > > pci_dev->addr.bus, pci_dev->addr.devid, pci_dev- > > >addr.function); > > > > IFPGA_RAWDEV_PMD_INFO("Closing %s on NUMA node %d", > > -- > > 2.29.2 > > Acked-by: Rosen Xu <rosen.xu@intel.com> Applied to dpdk-next-net-intel Thanks Qi ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [PATCH v1] raw/ifpga: fix ifpga device name format 2021-04-22 8:27 [dpdk-stable] [PATCH v1] raw/ifpga: fix ifpga device name format Wei Huang 2021-04-22 11:13 ` Xu, Rosen @ 2021-04-28 9:26 ` Ferruh Yigit 1 sibling, 0 replies; 4+ messages in thread From: Ferruh Yigit @ 2021-04-28 9:26 UTC (permalink / raw) To: Wei Huang, dev, rosen.xu, qi.z.zhang; +Cc: stable, tianfei.zhang On 4/22/2021 9:27 AM, Wei Huang wrote: > The device name format used in ifpga_rawdev_create() was changed to > "IFPGA:%02x:%02x.%x", but the format used in ifpga_rawdev_destroy() > was left as "IFPGA:%x:%02x.%x", it should be changed synchronously. > Hi Wei, If the name is significant, why not convert the format into a macro and use it? This prevents further similar errors, also highlights that format should be exact same. > Fixes: 9c006c45d0c5 ("raw/ifpga: scan PCIe BDF device tree") > Cc: stable@dpdk.org > > Signed-off-by: Wei Huang <wei.huang@intel.com> > --- > drivers/raw/ifpga/ifpga_rawdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c > index d9a46ef915..f591a87b49 100644 > --- a/drivers/raw/ifpga/ifpga_rawdev.c > +++ b/drivers/raw/ifpga/ifpga_rawdev.c > @@ -1551,7 +1551,7 @@ ifpga_rawdev_destroy(struct rte_pci_device *pci_dev) > } > > memset(name, 0, sizeof(name)); > - snprintf(name, RTE_RAWDEV_NAME_MAX_LEN, "IFPGA:%x:%02x.%x", > + snprintf(name, RTE_RAWDEV_NAME_MAX_LEN, "IFPGA:%02x:%02x.%x", > pci_dev->addr.bus, pci_dev->addr.devid, pci_dev->addr.function); > > IFPGA_RAWDEV_PMD_INFO("Closing %s on NUMA node %d", > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-28 9:26 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-04-22 8:27 [dpdk-stable] [PATCH v1] raw/ifpga: fix ifpga device name format Wei Huang 2021-04-22 11:13 ` Xu, Rosen 2021-04-25 2:07 ` Zhang, Qi Z 2021-04-28 9:26 ` Ferruh Yigit
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).