From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8AF5A034F for ; Thu, 1 Apr 2021 10:48:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C195540142; Thu, 1 Apr 2021 10:48:55 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 17BFE40142; Thu, 1 Apr 2021 10:48:53 +0200 (CEST) IronPort-SDR: Zs4tHtLZK+nAWhbjj9iFpUVPFB557fxK/y0NJHQ0fhfpK47N3vPtK5VfYDro5wiioX+pUo20kG PRLKOv12vkSQ== X-IronPort-AV: E=McAfee;i="6000,8403,9940"; a="172220611" X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="172220611" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 01:48:28 -0700 IronPort-SDR: ah34PFc8w5WPzwbflC/SvYvlyXSpAzjpZPMnwZ43d586cwEziW5etcUzYSZRm9SFsbDHpB69Y1 +8ikAGff3NfA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="446149778" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga002.fm.intel.com with ESMTP; 01 Apr 2021 01:48:28 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 1 Apr 2021 01:48:28 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 1 Apr 2021 01:48:27 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 1 Apr 2021 01:48:27 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.107) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Thu, 1 Apr 2021 01:48:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ikFmzjLDEA6kz2mpxSxLTgkHx2dxF5hHXbUQJP8MsE2UAHXs6c86Z2J4s5AOsNsK19W3fl91y0McUMGKkWAicjOWHpD1qnXCB0Hf4Wf3ZCWyYx/gstFYRs1Kmw2qJh8d57QuulIcx0PDjPIYjo+eypK99zSXrxH318zrS42wiWlAnTR2w6aQ7vW1ekKtvlEk9B5YENiYKroWs7QAa1xQEmDnE06za15FEvFvOz26l/cj5vuilFir1urVe7IfBFBZ6uhNJI1OpJ/f18nBZrUQPhhoBDEfQ/ZmRAeEKyDm5e6vLkm6Y6RnwX9D6+MsiTQ20NAP3agi3GBi5x5WZHATag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HClPc77N+aQcSW/DsGAmtTmIhpun5o8T+gdtoWHP+Uc=; b=AvUz17m/rC4gEt9GVcW6w38LhrlyEF9WQT2zgICPJzdAmUk93k+MmoU8caIPo/ErryVyvqkiU6XTziS/nngwhVuvxHO3CAgeqohaDPQCqCuk20vE0kdd2h3vYLWnfE36U0NIhr6L8lyg2MMWqFCnDXftnPEqvER+0vym6WA23HNVHk4V9cfLw6Oss6clrh6gT6Kb0glujCZKVoDXzyJqRFFiFN0943nAI0DpE64dJowqs2NiDaJFI1MOBwD0574nKiTXTEh++LW+02zmiRI9CUJBjpJDNmF1An/6dyFgfEeDD1lwWia8yrHwarYVHwA5+rqrg8uDcmamV9M7uXpo8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HClPc77N+aQcSW/DsGAmtTmIhpun5o8T+gdtoWHP+Uc=; b=lFQiN4KkHPLcMAWmyHzbnsN9kijCoM4vvr/2GivMJcx1lxVVaFpOsM8/KBdCAXHYsz8TW4XiJCjpFwB2laAioQj/DIZ/hFPZBms5PK6uPcj9iFK/4bh4M5qFsEaUARyl7GWwzc7619xkwG1F6PMGjYQhQRERCyFK/aUihCOqqEI= Received: from BYAPR11MB2901.namprd11.prod.outlook.com (2603:10b6:a03:91::23) by BY5PR11MB4305.namprd11.prod.outlook.com (2603:10b6:a03:1bf::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.28; Thu, 1 Apr 2021 08:48:25 +0000 Received: from BYAPR11MB2901.namprd11.prod.outlook.com ([fe80::4447:5f1e:984e:57f3]) by BYAPR11MB2901.namprd11.prod.outlook.com ([fe80::4447:5f1e:984e:57f3%3]) with mapi id 15.20.3999.028; Thu, 1 Apr 2021 08:48:25 +0000 From: "Xu, Rosen" To: "Huang, Wei" , "dev@dpdk.org" , "Zhang, Qi Z" CC: "stable@dpdk.org" , "Zhang, Tianfei" Thread-Topic: [PATCH v1 1/2] raw/ifpga/base: use untained variable as argument Thread-Index: AQHXGwbcre9kKqiYaU2JMyyHoNddZqqfcXbg Date: Thu, 1 Apr 2021 08:48:25 +0000 Message-ID: References: <1615969417-17118-1-git-send-email-wei.huang@intel.com> <1615969417-17118-2-git-send-email-wei.huang@intel.com> In-Reply-To: <1615969417-17118-2-git-send-email-wei.huang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.51] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 54e90ad5-3310-43b2-08c5-08d8f4eae9a6 x-ms-traffictypediagnostic: BY5PR11MB4305: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:517; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: F2cwy8ZzZwc6WzWfJKTkRIGsnxdfAhytOF1/g5izeCaNal4GgiOIrhdhqkyY4ZLqrcXhZa3Y0sFaQIuouHJ0EzXV/PofEhJKe1mShlCbCbQUpXwEJ6PaWnrk9Zu5PHG/EOb9LgKLolOuKpPoyilF5UaWAVbXnUI0cPQHFhkt5a4h4D0iawpnLNhi7gN/0icLaCQ3DODsFnbvGVL0GkfaOco4CZY+92mL8YpV8n1sY1PpdbgH7EZyhhYg13UdqU0CMckEWi5+MgGZd51aR5p4aUkDWqkrNeM2D1NNKlAQwjzGl0BMPWUZijcdaH8ueQQdUhKMkTKsw9kSoHoSfgW9ghQEV+Mfm8rraHuFldw5MvmZV5IUjOWaIDb0r+ZqGZjz+EU3AOmO877yNDOh0pJ7ByUmiakUMPhUsJgGFB5qTR1GJmSkdXgyNg1PtvhmV41/sxr06JJ40lUO3u1qz+UhGJqTuHidB5o7VttmO8eyNetdc6CRNtD+8bIH96DCuy/swq9f1WjmKzvGwHMBVgmion/AaekANuPMiY5EROALhHXkn2G6SS/P1pOQj6Pm98YtqcN1inLbMwroEYQB66PietaXJ0OnFu6FxuxKmeU//8yl5f1k1x13iL1B+yNRqMkw7LmidmGB6RPK6asErTwf+BS6hJZj1mf30aAkPDtBvvI= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB2901.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(136003)(346002)(39860400002)(366004)(396003)(38100700001)(8676002)(55016002)(9686003)(71200400001)(54906003)(110136005)(8936002)(478600001)(4326008)(53546011)(107886003)(450100002)(6506007)(7696005)(5660300002)(186003)(2906002)(26005)(76116006)(316002)(64756008)(66476007)(52536014)(66556008)(66946007)(66446008)(33656002)(83380400001)(6636002)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?hazZBv9bMltcoLc/SmIenYgoLR72UKBxaDKVKZJV7k1aBBmG+uHtkTmelpzK?= =?us-ascii?Q?ZMjR2bX8obJmSxXdad8jSRLCFdOzxVgFSMu2H7q+cSoMJCmX12kARNnNPK8d?= =?us-ascii?Q?nLt/UqYpNiOAupi9hM5rUjyNTEZ78uhTpDtvvsdqJA6KOO8PUHgygLNIZohE?= =?us-ascii?Q?UJxW6Alj8gw2HfB0tzoG2sDrRhcRvpqqy7Y21J3m2F6O8Ufk6HpRXwDla9Tz?= =?us-ascii?Q?2/q8n/24QFbwbAz1qo2jdX/Wa0TWbOnrILqb0PiSWDgGIj94l3qXnNKYRoeM?= =?us-ascii?Q?L4WJMGwvSEa14gUTd1ibDayiFrXWSXGpE7SlZcobtzIVqhfM4uFAIChN5a+p?= =?us-ascii?Q?49yfXzbr6cHdwaFbwigs1wem3a96Yx+aEqt13llfPgXF5x0UFNc2MoiYBHAd?= =?us-ascii?Q?sGPKfccVYN9Y2HaJi1U1xNp6XuRYPRmQrNctQ4rcIk1vVvDdym+3ArSCa2I9?= =?us-ascii?Q?no1ylQxCFcKUArQjNqvJy3snLDqcJsWzxWNYpZWEHBv69H1up2a1609PiREJ?= =?us-ascii?Q?VfENWsBMjIXSGy6++OpiYKAV2N1JvmoTQzG5b6Ri4fwdWdqgcHHtr5hbQiHS?= =?us-ascii?Q?FGZnWsMHCAUomV11lDgk3QEfAdMWpJwxEPTtwdhu0Lmh6BxJC1pfHShFNsnq?= =?us-ascii?Q?fnnqWWVaOfa5KtudFcfg8Ge1f2O+EPhwmEcxSv9O8CzZYP/epQpB2JxR8YsT?= =?us-ascii?Q?mST125WMobiQoKouDT46ABz3qQKlxHuLasYj0Q+9Ni8rHav+V+ZeqzMIe1yA?= =?us-ascii?Q?VWcKWEdM0lLD03Cp35+h0QBxKHnW4RSjImPNgFcDZcJMNRC5JoEu6uL1Zh/L?= =?us-ascii?Q?CsatmR/i/wmK0YY8R+mnlU+IeqUJslc7s+ASo6QYYwVv5kZq9gjUiQIyAfkr?= =?us-ascii?Q?n6U4ufooktt/3GRpRvUlSR07QSkIekDdKYZzV6W8u/8lO3pMx2+vrscXFqNo?= =?us-ascii?Q?vKfLRhLI8ghy3JnM3h8QYt1uFtw4xJ2MABwUSBH4nTF3RDY0v1oO73AKKlkn?= =?us-ascii?Q?3BcBxhtza8OuRBWkoU3b/Axk1rY0u/tV5RbGHL0HXwSSE68HweIfdtaGfaEV?= =?us-ascii?Q?IjLOkALmTwiySXkafK0bQ5m6ilzkrPWyFdLaH6HEdaMo05pKlW3y+3784tu4?= =?us-ascii?Q?Dwa6lHuvHiCq8HbwBaW2UNIc3sLs5kwtdTYaTRB9TWonvQI6Pg0Vb/0r/+EM?= =?us-ascii?Q?UxBx30y6e5hOEhSxR5QaiI/1PETC5R0UzschgB8+Yl4aXspoGfPyF2yTUmw3?= =?us-ascii?Q?XuxgumtfGhH/A83EEIxLsFMR4ODcdyDTbpLMnSuW9vUuW4N/3AiFyqS5jpPu?= =?us-ascii?Q?YfE2Oomuwf5acalqq0eSNlkB?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB2901.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 54e90ad5-3310-43b2-08c5-08d8f4eae9a6 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2021 08:48:25.1253 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: o4R4h0RFjl6R5Mvqr9qRnuScvvEsYOukElEULUmcVsvakX7wpNaBd3kDyR5m9YJRy0dodEKyAYOtctD9bg2G7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4305 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH v1 1/2] raw/ifpga/base: use untained variable as argument X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, -----Original Message----- From: Huang, Wei =20 Sent: Wednesday, March 17, 2021 4:24 PM To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z Cc: stable@dpdk.org; Zhang, Tianfei ; Huang, Wei <= wei.huang@intel.com> Subject: [PATCH v1 1/2] raw/ifpga/base: use untained variable as argument In fme_spi_init(), passing tainted expression "fme->max10_dev" to function "intel_max10_device_remove" has risk. Untainted variable "max10= " should be used. Coverity issue: 367480 Fixes: 96ebfcf8125c ("raw/ifpga/base: add SPI and MAX10 device driver") Signed-off-by: Wei Huang --- drivers/raw/ifpga/base/ifpga_fme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/raw/ifpga/base/ifpga_fme.c b/drivers/raw/ifpga/base/if= pga_fme.c index 43c7b9c3dc..a63f90331f 100644 --- a/drivers/raw/ifpga/base/ifpga_fme.c +++ b/drivers/raw/ifpga/base/ifpga_fme.c @@ -1001,7 +1001,7 @@ static int fme_spi_init(struct ifpga_feature *feature= ) return ret; =20 max10_fail: - intel_max10_device_remove(fme->max10_dev); + intel_max10_device_remove(max10); spi_fail: altera_spi_release(spi_master); return ret; -- 2.29.2 Acked-by: Rosen Xu