From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36E0BA0517 for ; Wed, 10 Jun 2020 12:17:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1EFFE2C38; Wed, 10 Jun 2020 12:17:23 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 6B5172B83; Wed, 10 Jun 2020 12:17:19 +0200 (CEST) IronPort-SDR: vnYo+4PTID5TfhS6dsi7iSpNixynUWSB2GuJa1kNsYFCM1JAt9awmTc7kNk9C//n+xOuExbP+t 6iy7M5UU1QVA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2020 03:17:17 -0700 IronPort-SDR: F1wQh/UXCV+F/GCtFOq5KiGW4ez4ADD8caXO3YGeZ1oGsXwA4pGjy9/iYoQoOGT4swWaF6VvyC J+xAhzrmmhLg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,495,1583222400"; d="scan'208";a="274917689" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga006.jf.intel.com with ESMTP; 10 Jun 2020 03:17:17 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 10 Jun 2020 03:17:17 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 10 Jun 2020 03:17:16 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 10 Jun 2020 03:17:16 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.44) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 10 Jun 2020 03:17:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C2X4UBOI/IpVTveWyaKjlrWa66iWW69JLRso9j+VrTg0tDHALonlQ0iQkXwA46ghqsH+BR4ArFGZX47YMDlpScBYsDenCESJiJXHTa7rANGizMBtQNkZPWEL4Pwena3pPIC6sXMUF6H4g7QH1H6klr7SQRUEZvjUkV/QlRLh8rNnwoRrg/MbPy4Vy/LttCkLoAVxpDJsL1Bf1doMQZr0lBeX2uHCbwCr9bTyuoFGq4EBk9OlzUyA+KsbBiN1FdZtOp52HlCPOJTBOGf4mbuB1O5c5CzlT86RRAIv+REPM20nU67854eO5O5GjtMazKwg8niCWkJN8J13DqWW95Y9aA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TcChE5yGqXLd40bsbdvCLqd2ZuULx1nmeAobHJRvFuc=; b=Zzzb7Hv+QZNtMs5qcapnAPSB+4sqZ6UMzQ23fPK8mhPL2OvKgvAqanMuav0wBE9BMxJIbV/ZRxh/K6+HhVqAhdyq05a5r0AWXMFHrAjRhPAwwSnkkFaBoMJIXYeni/8zYW4tF1arZO3KmtCOKhNrxRITyKugfx/JOm74ONRKq+2EM4UENM8wVeeNPjaQlOmZh12+Oz3zDu797BFnI1vEcQJmnX0ecACy+2Omp5qTdCP1Ivsyt9OYvuERlHuNziDIe3hdVsfRC7wsP8db4kGfEiXZVE0fcwwxmAXRbmvlXAHCy8nt1KiFf+BnrDyyhbpz7BkBZSL599aMiewFj8bIFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TcChE5yGqXLd40bsbdvCLqd2ZuULx1nmeAobHJRvFuc=; b=xcAhjojlJgQcEk9wKkQbq0Hpdx/n+5RP5mc92Qj6iZrUsxNOgio6bd/cgrts6ptI5IbvT7g/Zw+d2TvRj+GUznIIOZJ8VV+5HBpP5oAIJ/82N05b/0r/L4ZiNxzH29U+CELrDsKKxbIK2mQ3whaIz6M9Hw5MmIFu1Fx16LOamGk= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BYAPR11MB2983.namprd11.prod.outlook.com (2603:10b6:a03:88::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.18; Wed, 10 Jun 2020 10:17:14 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f160:29ab:b8f9:4189]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f160:29ab:b8f9:4189%6]) with mapi id 15.20.3066.023; Wed, 10 Jun 2020 10:17:14 +0000 From: "Ananyev, Konstantin" To: Feifei Wang , Honnappa Nagarahalli CC: "dev@dpdk.org" , "nd@arm.com" , "stable@dpdk.org" Thread-Topic: [PATCH] lib/ring: fix the bug of HTS/RTS bulk enqueue Thread-Index: AQHWPtjQrpvqrP3iZEmeGHES4Gka+6jRop/Q Date: Wed, 10 Jun 2020 10:17:13 +0000 Message-ID: References: <20200610033918.45834-1-feifei.wang2@arm.com> In-Reply-To: <20200610033918.45834-1-feifei.wang2@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.181] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8b758ab2-9053-4cd5-b8e5-08d80d277212 x-ms-traffictypediagnostic: BYAPR11MB2983: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-forefront-prvs: 0430FA5CB7 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yStlGb0fGvFQ3H0INiQp1RuND9W8z2t0A2xW97vwrjGi7Zv/IvYBlN/emMhhuLy8yVrXJm1fzZCMkGgMQi6Ptuhxz7XwVI2vFo4BHrVBM5gsyEuu901Nkadjn9twMMhFygftETeFaw+KVu31mEN/cPfNYeQk6j6vCr4j45HU9rWH3KOADckbAimAJfQ1TtmU6imaM2yEJgj7KhmRdlAHA1GV2Gr1zVtB/4TkdolUHVrX70z5IGfl7/q3292eiNv2E6C4FfyuRCWIsfZr/TJCUBubux40bpbVq3uDsQsTPBo+EWWyntiPogfM+aPSC693s8wIzkeg5spNpyuCOMLj0w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(346002)(396003)(39860400002)(376002)(136003)(366004)(55016002)(6506007)(52536014)(33656002)(5660300002)(7696005)(4326008)(86362001)(71200400001)(83380400001)(9686003)(186003)(2906002)(110136005)(66476007)(66946007)(64756008)(316002)(66556008)(478600001)(8936002)(8676002)(26005)(66446008)(54906003)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: eP1+s90UNWHcmPUROsdCE7VeVYNvut7EWyRlfgjABbvEe6+e0nik0vsgkz79jsGxYNK58D1B1j5QCNufgoY13VHpQpoxJQaBOm0GA45bY86cCfTNJZlS1/RvLT5QPtX7nJkUTvk9NakvaWonY28RPsjeRhvjDn5H3tERygIc7P10uuz4Qh9t3L10cgm9V98lK/7RYzs2cKzGNevD23TvbM/UyxdVFFXJ8hE+nVlbtnaiOFMlTmOOjvUdaqSI+fbQmyNP+0NLYPMOhZYPMsdhbkgXhzwSqq5GG0pwAYV5oZLGJVWo1v/viF4uc1JcPVaADbvlkdRr0LwvQxUZWkHwXLFXeOvGDOJuCPLU7OiMyK+H2e+wc1XuXCqp3+QKZi/Mrz9fBvk0oJq8tJTkYpfX82h/P5AuCemiqgbnLxxwI+WJ7DiBMhv6WMrGvLUQcmtyCF4nQ/eKN2ZzNwUjDqHo7D/HA0bE4pnB74mCLnp90s+mF3X3GQihzaEDejVjQJBX x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 8b758ab2-9053-4cd5-b8e5-08d80d277212 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2020 10:17:14.0151 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2PVoTj+USNbTCy6WHimPPkzZYye/5+ajV2MlnL9wTP80/61Mk2cOD4JpaFPR+VbNfQylOTAjhL1+XaFOWX4LhKdSocVzr0EIkFXsUTV6krI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2983 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH] lib/ring: fix the bug of HTS/RTS bulk enqueue X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > Directly call "_rte_ring_do_enqueue_elem" function can result in the > process skips the "switch" order and cannot call the APIs of RTS and HTS > mode in "rte_ring_enqueue_bulk_elem" function. >=20 > To fix it, remove the unnecessary function and make > "_rte_ring_do_enqueue_elem" consistent with "_rte_ring_do_dequeue_elem". >=20 > Fixes: e6ba4731c0f3 ("ring: introduce RTS ring mode") > Cc: stable@dpdk.org >=20 > Signed-off-by: Feifei Wang > Reviewed-by: Ruifeng Wang > --- > lib/librte_ring/rte_ring_elem.h | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/lib/librte_ring/rte_ring_elem.h b/lib/librte_ring/rte_ring_e= lem.h > index a5a4c46f9..469aee7da 100644 > --- a/lib/librte_ring/rte_ring_elem.h > +++ b/lib/librte_ring/rte_ring_elem.h > @@ -578,9 +578,6 @@ static __rte_always_inline unsigned int > rte_ring_enqueue_bulk_elem(struct rte_ring *r, const void *obj_table, > unsigned int esize, unsigned int n, unsigned int *free_space) > { > - return __rte_ring_do_enqueue_elem(r, obj_table, esize, n, > - RTE_RING_QUEUE_FIXED, r->prod.sync_type, free_space); > - > switch (r->prod.sync_type) { > case RTE_RING_SYNC_MT: > return rte_ring_mp_enqueue_bulk_elem(r, obj_table, esize, n, > -- Ouch, that was a nasty one from me. Thanks for catching and fixing. Acked-by: Konstantin Ananyev > 2.17.1