From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7A32A0A0A for ; Fri, 22 Jan 2021 14:15:44 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A060E140FD8; Fri, 22 Jan 2021 14:15:44 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 57C02140FBE; Fri, 22 Jan 2021 14:15:41 +0100 (CET) IronPort-SDR: ZrfhGa1YL6RBjUJ5ozS9pVm1EO0QfHM1iYXBW8ZT/KNwu8Td0woQEmjE1K3wvyudQUQKrT3FVA hgqoDgsU6ugw== X-IronPort-AV: E=McAfee;i="6000,8403,9871"; a="158622824" X-IronPort-AV: E=Sophos;i="5.79,366,1602572400"; d="scan'208";a="158622824" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2021 05:15:40 -0800 IronPort-SDR: qPXQM0wQz2WM6X1kbM2S5ihMHp7IXMd1ar0THXZwRFLcdqbKMs/WcVVRGHUQWhbqNUZ9HAh0M6 ElvFHCFjcXCw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,366,1602572400"; d="scan'208";a="400650071" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga004.fm.intel.com with ESMTP; 22 Jan 2021 05:15:40 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 22 Jan 2021 05:15:39 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 22 Jan 2021 05:15:39 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Fri, 22 Jan 2021 05:15:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mKBVO3IXMXtBQJwZhz9NXFLg104EYy+0PLkQ+xieD+zX8lfGkXdnYqp0M7ppkFTr2X8Vqwu8wJa0yOyaRfei95+mH04xJLWshtGdRkXufOftK886/kom/gb39Ing+W1g1i6JaN3zHhlk/14gHagtWUY087zFPBEy9h9aRbCdevSxxQbjC8T6uf2Qa+lV9myt6kGAkJTHOYk4NpdDTQh5lhLTL5i0u5zKn3dCA6laXxsbgBeuPFi792m6u24okV222K/o6rTy4JPGFSkRGo2gufUV1nWdrzOep60IAvDbDzZ2xUD4B30h9cGiRWFzV2+wX03yKvcnIQTrSP0zlGJnFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z4s/TVKMuO0Sz1GtMi5Fel+NhPddCjv+VTJaHESQ6oE=; b=UMFGH9z0b6mCvO49XLoJUSasM63sLwAYAUg7MWB6zmEPxAZCVJ1/Sx/vazP9a4BWu8K4f9HGWK3xsGXK+0CA/op1UKz4q+l9LF2cO30G8qdK7LvdE1WC/o0GuisUC+Xs4eCWA84c3PLLs1BlIRkPFc+M9+2y0YGuhBnwRJogxKGU69BC3xMEe95pj5Kn5L9nO6Z89EO2HmercvUk9dCNnXV+hOpaJ6hLfXgQ2PT3ppkF8itof9Vobdwq+EZ6rBXPuPwKXWnG+ztRCO+CgaFrMqpxsLq8G3QIjZ166SDD4VTp62RsPYS0wiZDwQroX3XMbEI+OyAhxl1KPl/9K90OIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z4s/TVKMuO0Sz1GtMi5Fel+NhPddCjv+VTJaHESQ6oE=; b=tjsXaIEL1XFY2tF/sZn+hTRF0Kr55fnX3kTnPEPz0Vbc18phdUNfn7H8rZnbV2IRhWMiR22yPEXgjIaVp2VRdzBIKioNIGS8/6dwRtCkhXuDSQaLMIeNtb6LAadtvk3V4mKRT4qA7u3kudZf1UeKH52fkai+j7Iq4FZy5Zghhq8= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BY5PR11MB3893.namprd11.prod.outlook.com (2603:10b6:a03:183::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.11; Fri, 22 Jan 2021 13:15:38 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::1152:1426:8a4f:c755]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::1152:1426:8a4f:c755%4]) with mapi id 15.20.3784.013; Fri, 22 Jan 2021 13:15:38 +0000 From: "Ananyev, Konstantin" To: Feifei Wang , Honnappa Nagarahalli , Olivier Matz , "Gavin Hu" CC: "dev@dpdk.org" , "nd@arm.com" , "stable@dpdk.org" Thread-Topic: [PATCH v1 1/3] test/ring: reduce iteration numbers to make test duration shorter Thread-Index: AQHW14pvs4H3cFomtEmgHbIsZfD8baoz0Whg Date: Fri, 22 Jan 2021 13:15:38 +0000 Message-ID: References: <20201221111359.22013-1-feifei.wang2@arm.com> <20201221111359.22013-2-feifei.wang2@arm.com> In-Reply-To: <20201221111359.22013-2-feifei.wang2@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [46.7.39.127] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cb5bd882-cd81-4a0a-33db-08d8bed7cf99 x-ms-traffictypediagnostic: BY5PR11MB3893: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: C9U5KDb5zHAjTb0Ofh6dSZnUTdfg8h+ps1/+KvMZkA2fx6aGoje0oBJJbAs7EjF2U9NdmkjQUMWJNS8Kla4TqtM3Rn9ovy+uRBLP7ZC5uVpEtAUi9RZeLQmIUaZVaX8CcJ441RdJiL5seNm3IufDgHbsIPWqYPcBIYv5R7jt5sT/aY0wvlRE7f1fzP/K9joOjF+4Ml1KqdLRuB85nKxVrfBCiluiGlJeDgeTZVEuZsf/5B0Y+H2PVygGHxQZ/5D2txMOZyVv52CBcD2LNxamqLtk7jZranFwv/8P0MtIfNQb9uTc6zfazF4AbkJEEY8rRhR0k9XWslvLnIU43h1lj+QaYv3S503epLXjYUU2TwFkngwVq0CoXbl27c/TtFbmTfTCCe0znn63uDxpkG5gyEN7jO9idZ/LRsP50c85WuXjcmOX4ndSEzn71ljqqGsd+raT1mpZlG/0OYhv1nI0RrfCNoPz7yXjZR7t+K3PkmiE4SmNEzCicVfg0u1Uhy8Pi/05p0iqzVAJKmkuCOZ281dA0J4YLmS7FSY7vCaPIEb14s1kLumN0P+iILuhGZ2E x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(376002)(346002)(396003)(366004)(54906003)(83380400001)(110136005)(33656002)(6506007)(9686003)(52536014)(4326008)(66946007)(26005)(76116006)(64756008)(66446008)(5660300002)(86362001)(66556008)(66476007)(71200400001)(55016002)(186003)(316002)(7696005)(2906002)(8936002)(8676002)(478600001)(473944003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?342N2GEAn2CYRXAsfLV6AXNNtc87h2cyjCI/LlbKmeU0yl9tG+W15x4jOs36?= =?us-ascii?Q?gR6idIXuj6PuowLpOMXf5NKLUyNBwoT7HsQbI7MerpReu063efA42k+8ytyC?= =?us-ascii?Q?fF33HDEvIgtDSuB/cU6048TuzofCu2VlOr5sGHWSDrOhYgR4Ds3+lJErXdM2?= =?us-ascii?Q?NbOevbp0bFrEv9xeqiDaCzeD8RjFPGmR6ZPOklChqenClJ8uRUg34s5Bg0SO?= =?us-ascii?Q?1+/qeAKmt5jCgUDMVs1ubvnlqCjLyX1j2m0UrNqERz2K1QMcXpmdG3zOXhKU?= =?us-ascii?Q?8I7RM+VrkznX5zh2KJ0yXuyFUPWLUla7dKv6NxMDBJUdeVlDUHjPgCpNMS3c?= =?us-ascii?Q?RvhYFcNfU6Bf6Vl6ZZwpggf83QsFRR1lFLIgfCZ+4apwcVnEloHH6qEZ3WEh?= =?us-ascii?Q?Lb33N7+bTqhtegogDFVKC5mG597tmcBJWw23He7/2CYPB9rOg+znxIXuBIjH?= =?us-ascii?Q?vtxPgpgguhorxgHEEP5WkAt5is5BgoQX/nO17MOUNxEahzpV6qzpWjL5QAwE?= =?us-ascii?Q?Mnnu3NC54JYq525kmiRqshhPeG8PRf1/FufBjPy3t33fWlqCeTg3AtV40hcU?= =?us-ascii?Q?EM1Qyx2hrRPRVKINGSsAUtmaHPFGPNre2w8fiMTh0E6OHYdWc5g1OFr15IIq?= =?us-ascii?Q?aqdORIqxA1BrTcUe0iGnbJENjT5n7WIciYwNSXmn6SIWdvhntjC2LBZD6csX?= =?us-ascii?Q?tmT/hhkrxtBTAmgIQVXEmg+dGRiRU080wJUinP+Pp5W6QFTT94iqyH5kKcra?= =?us-ascii?Q?xHDv2L1civtiZtSxAcBxKDnfb6oGq8sEgT6OW2qCj3ywE7wNcXleiMjO1te3?= =?us-ascii?Q?p6yEGmanq4ayCykn7NnJ82lK8hgIG2q8ZVETYdaoPH1liHOZCRNJu8qkYT4j?= =?us-ascii?Q?4KHgBCl4VoADiWMTj07i/n2CGho6pn8GWJda9MzuUyU34fZvrHuDXM3HUyc9?= =?us-ascii?Q?KmsF7zUaxhUm1oFfPHB8XeFbDIAu7saRNnuC2/sg7yxtqMJNZ00HDp/1irb4?= =?us-ascii?Q?4XWt/wgE+2yOeCEZI0uHwKYOiY84tL05ZZp39eMvH02hW7o=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3301.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb5bd882-cd81-4a0a-33db-08d8bed7cf99 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jan 2021 13:15:38.1736 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FPZZ+dJCqyJ97p3S19CUgjKSX8txvcmeXfQ6eOQy8kDmZ/Dar3DNypkgekI5cvtnEV0EisYMPUYdAJofV5sdaaG4pjvCgjOhYPoOAmXnR8M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB3893 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH v1 1/3] test/ring: reduce iteration numbers to make test duration shorter X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > When testing ring performance in the case that multiple lcores are mapped= to > the same physical core, e.g. --lcores '(0-3)@10', it takes a very long ti= me > to wait for the "enqueue_dequeue_bulk_helper" to finish. This is because > too much iteration numbers and extremely low efficiency for enqueue and > dequeue with this kind of core mapping. Following are the test results to > show the above phenomenon: >=20 > x86-Intel(R) Xeon(R) Gold 6240: > $sudo ./app/test/dpdk-test --lcores '(0-1)@25' > Testing using two hyperthreads(bulk (size: 8):) > iter_shift: 3 5 7 9 11 13 *15 17 1= 9 21 23 > run time: 7s 7s 7s 8s 9s 16s 47s 170s 6= 60s >0.5h >1h > legacy APIs: SP/SC: 37 11 6 40525 40525 40209 40367 40407 4= 0541 NoData NoData > legacy APIs: MP/MC: 56 14 11 50657 40526 40526 40526 40625 4= 0585 NoData NoData >=20 > aarch64-n1sdp: > $sudo ./app/test/dpdk-test --lcore '(0-1)@1' > Testing using two hyperthreads(bulk (size: 8):) > iter_shift: 3 5 7 9 11 13 *15 17 1= 9 21 23 > run time: 8s 8s 8s 9s 9s 14s 34s 111s 4= 18s 25min >1h > legacy APIs: SP/SC: 0.4 0.2 0.1 488 488 488 488 488 4= 89 489 NoData > legacy APIs: MP/MC: 0.4 0.3 0.2 488 488 488 488 490 4= 89 489 NoData >=20 > As the number of iterations increases, so does the time which is required= to > run the program. Currently (iter_shift =3D 23), it will take more than 1 = hour > to wait for the test to finish. To fix this, the "iter_shift" should decr= ease > and ensure enough iterations to keep the test data stable. In order to ac= hieve > this, we also test with "-l" EAL argument: >=20 > x86-Intel(R) Xeon(R) Gold 6240: > $sudo ./app/test/dpdk-test -l 25-26 > Testing using two NUMA nodes(bulk (size: 8):) > iter_shift: 3 5 7 9 11 13 *15 17 1= 9 21 23 > run time: 6s 6s 6s 6s 6s 6s 6s 7s 8= s 11s 27s > legacy APIs: SP/SC: 47 20 13 22 54 83 91 73 8= 1 75 95 > legacy APIs: MP/MC: 44 18 18 240 245 270 250 249 2= 52 250 253 >=20 > aarch64-n1sdp: > $sudo ./app/test/dpdk-test -l 1-2 > Testing using two physical cores(bulk (size: 8):) > iter_shift: 3 5 7 9 11 13 *15 17 1= 9 21 23 > run time: 8s 8s 8s 8s 8s 8s 8s 9s 9= s 11s 23s > legacy APIs: SP/SC: 0.7 0.4 1.2 1.8 2.0 2.0 2.0 2.0 2= .0 2.0 2.0 > legacy APIs: MP/MC: 0.3 0.4 1.3 1.9 2.9 2.9 2.9 2.9 2= .9 2.9 2.9 >=20 > According to above test data, when "iter_shift" is set as "15", the test = run > time is reduced to less than 1 minute and the test result can keep stable > in x86 and aarch64 servers. >=20 > Fixes: 1fa5d0099efc ("test/ring: add custom element size performance test= s") > Cc: honnappa.nagarahalli@arm.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Feifei Wang > Reviewed-by: Honnappa Nagarahalli > Reviewed-by: Ruifeng Wang > --- > app/test/test_ring_perf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/app/test/test_ring_perf.c b/app/test/test_ring_perf.c > index e63e25a86..fd82e2041 100644 > --- a/app/test/test_ring_perf.c > +++ b/app/test/test_ring_perf.c > @@ -178,7 +178,7 @@ enqueue_dequeue_bulk_helper(const unsigned int flag, = const int esize, > struct thread_params *p) > { > int ret; > - const unsigned int iter_shift =3D 23; > + const unsigned int iter_shift =3D 15; > const unsigned int iterations =3D 1 << iter_shift; > struct rte_ring *r =3D p->r; > unsigned int bsize =3D p->size; > -- I think it would be better to rework the test(s) to terminate after some timeout (30s or so), and report number of ops per t= imeout.=20 Anyway, as a short term fix, I am ok with it. Acked-by: Konstantin Ananyev > 2.17.1