From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "Hunt, David" <david.hunt@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Hunt, David" <david.hunt@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v1 1/4] test/power: fix check for cpu frequency
Date: Thu, 29 Apr 2021 10:34:33 +0000 [thread overview]
Message-ID: <BYAPR11MB336638F459E3A0BD0D568E73FF5F9@BYAPR11MB3366.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210422144030.16746-1-david.hunt@intel.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of David Hunt
> +TEST_POWER_SYSFILE_SCALING_FREQ, lcore_id) < 0) {
> return 0;
[Reshma]: Do we need to return -1 here and in other failure scenarios below.
> }
> f = fopen(fullpath, "r");
> if (f == NULL) {
> -return 0;
> +if (snprintf(fullpath, sizeof(fullpath),
> +TEST_POWER_SYSFILE_CPUINFO_FREQ, lcore_id) < 0) {
> +return 0;
> +}
> +f = fopen(fullpath, "r");
> +if (f == NULL) {
> +return 0;
> +}
> }
> for (i = 0; i < MAX_LOOP; i++) {
> fflush(f);
> --
> 2.17.1
next prev parent reply other threads:[~2021-04-29 10:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 14:40 [dpdk-stable] " David Hunt
2021-04-22 14:40 ` [dpdk-stable] [PATCH v1 2/4] test/power: add turbo mode to freq check function David Hunt
2021-04-22 16:13 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly
2021-05-12 15:34 ` Thomas Monjalon
2021-05-12 16:38 ` David Hunt
2021-04-22 14:40 ` [dpdk-stable] [PATCH v1 3/4] test/power: fix low freq test when turbo enabled David Hunt
2021-04-22 14:40 ` [dpdk-stable] [PATCH v1 4/4] test/power: fix turbo test David Hunt
2021-04-29 10:34 ` Pattan, Reshma [this message]
2021-05-11 13:27 ` [dpdk-stable] [dpdk-dev] [PATCH v1 1/4] test/power: fix check for cpu frequency Thomas Monjalon
2021-05-11 14:41 ` David Hunt
2021-05-11 14:46 ` Pattan, Reshma
2021-05-12 16:32 ` [dpdk-stable] [PATCH v2 " David Hunt
2021-05-12 16:32 ` [dpdk-stable] [PATCH v2 2/4] test/power: add turbo mode to freq check function David Hunt
2021-05-12 16:32 ` [dpdk-stable] [PATCH v2 3/4] test/power: fix low freq test when turbo enabled David Hunt
2021-05-12 16:32 ` [dpdk-stable] [PATCH v2 4/4] test/power: fix turbo test David Hunt
2021-05-12 20:05 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB336638F459E3A0BD0D568E73FF5F9@BYAPR11MB3366.namprd11.prod.outlook.com \
--to=reshma.pattan@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).