From: "Xing, Beilei" <beilei.xing@intel.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
"maxime.leroy@6wind.com" <maxime.leroy@6wind.com>
Subject: Re: [dpdk-stable] [PATCH v2 1/3] net/i40e: fix FDIR issue for ARP packets
Date: Tue, 28 Apr 2020 07:38:10 +0000 [thread overview]
Message-ID: <BYAPR11MB3541EED61244807FE7BDB94BF7AC0@BYAPR11MB3541.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200428054815.3551-2-wei.zhao1@intel.com>
> -----Original Message-----
> From: Zhao1, Wei <wei.zhao1@intel.com>
> Sent: Tuesday, April 28, 2020 1:48 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Xing, Beilei <beilei.xing@intel.com>;
> maxime.leroy@6wind.com; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH v2 1/3] net/i40e: fix FDIR issue for ARP packets
>
> This patch can enable FDIR awith ethertype as input set for ARP packet, it will
> associate this rule, "flow create 0 ingress pattern eth type is 0x0806 / end
> actions mark id 0x86 / rss / end", with pctype
> I40E_FILTER_PCTYPE_L2_PAYLOAD for ARP packet rule.
> I have tried to enable ARP ethertype for FDIR filter, it work well for ARP for
> FDIR filter, so delete the check.
How about
'Currently, flow "pattern eth type is 0x0806 / end actions mark id 0x86 / rss / end" can't be created successfully. FDIR parser shouldn't deny RTE_ETHER_TYPE_ARP since ARP packets will be parsed as PCTYPE_L2_PAYLOAD.
This patch fixes the issue.' ?
>
> Bugzilla ID: 402
> Fixes: 42044b69c67d ("net/i40e: support input set selection for FDIR")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
> drivers/net/i40e/i40e_flow.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index
> 7e64ae53a..1533d5abb 100644
> --- a/drivers/net/i40e/i40e_flow.c
> +++ b/drivers/net/i40e/i40e_flow.c
> @@ -2666,7 +2666,6 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev
> *dev,
> if (next_type ==
> RTE_FLOW_ITEM_TYPE_VLAN ||
> ether_type == RTE_ETHER_TYPE_IPV4 ||
> ether_type == RTE_ETHER_TYPE_IPV6 ||
> - ether_type == RTE_ETHER_TYPE_ARP ||
> ether_type == outer_tpid) {
> rte_flow_error_set(error, EINVAL,
>
> RTE_FLOW_ERROR_TYPE_ITEM,
> @@ -2711,7 +2710,6 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev
> *dev,
>
> if (ether_type == RTE_ETHER_TYPE_IPV4 ||
> ether_type == RTE_ETHER_TYPE_IPV6 ||
> - ether_type == RTE_ETHER_TYPE_ARP ||
> ether_type == outer_tpid) {
> rte_flow_error_set(error, EINVAL,
>
> RTE_FLOW_ERROR_TYPE_ITEM,
> --
> 2.19.1
next prev parent reply other threads:[~2020-04-28 7:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200427071500.14767-1-wei.zhao1@intel.com>
2020-04-27 7:14 ` [dpdk-stable] [PATCH 1/3] net/i40e: remove ARP type check for FDIR filter Wei Zhao
2020-04-28 1:20 ` Xing, Beilei
2020-04-28 5:39 ` Zhao1, Wei
2020-04-27 7:15 ` [dpdk-stable] [PATCH 3/3] net/i40e: remove teardown when flush " Wei Zhao
2020-04-28 1:13 ` Xing, Beilei
2020-04-28 1:18 ` Zhao1, Wei
2020-04-28 5:48 ` [dpdk-stable] [PATCH v2 0/3] fix i40e bug for flow filter Wei Zhao
2020-04-28 5:48 ` [dpdk-stable] [PATCH v2 1/3] net/i40e: fix FDIR issue for ARP packets Wei Zhao
2020-04-28 7:38 ` Xing, Beilei [this message]
2020-04-28 7:46 ` Zhao1, Wei
2020-04-28 5:48 ` [dpdk-stable] [PATCH v2 2/3] doc: input set requirement of each pctype for FDIR Wei Zhao
2020-04-28 5:48 ` [dpdk-stable] [PATCH v2 3/3] net/i40e: remove teardown when flush FDIR filter Wei Zhao
2020-04-28 7:16 ` Xing, Beilei
2020-04-28 7:44 ` Zhao1, Wei
2020-04-28 7:39 ` [dpdk-stable] [PATCH v3 0/3] fix i40e bug for flow filter Wei Zhao
2020-04-28 7:39 ` [dpdk-stable] [PATCH v3 1/3] net/i40e: fix FDIR issue for ARP packets Wei Zhao
2020-04-28 7:39 ` [dpdk-stable] [PATCH v3 2/3] doc: input set requirement of each pctype for FDIR Wei Zhao
2020-04-28 7:39 ` [dpdk-stable] [PATCH v3 3/3] net/i40e: remove teardown when flush FDIR filter Wei Zhao
2020-04-29 2:03 ` [dpdk-stable] [PATCH v4 0/3] fix i40e bug for flow filter Wei Zhao
2020-04-29 2:03 ` [dpdk-stable] [PATCH v4 1/3] net/i40e: fix FDIR issue for ARP packets Wei Zhao
2020-04-29 2:03 ` [dpdk-stable] [PATCH v4 2/3] doc: input set requirement of each pctype for FDIR Wei Zhao
2020-04-29 10:35 ` Ferruh Yigit
2020-04-30 0:52 ` Zhao1, Wei
2020-04-30 10:19 ` Ferruh Yigit
2020-05-06 1:05 ` Zhao1, Wei
2020-05-06 9:29 ` Ferruh Yigit
2020-05-06 9:32 ` Zhao1, Wei
2020-04-29 2:03 ` [dpdk-stable] [PATCH v4 3/3] net/i40e: remove teardown when flush FDIR filter Wei Zhao
2020-04-29 3:05 ` [dpdk-stable] [PATCH v4 0/3] fix i40e bug for flow filter Xing, Beilei
2020-04-29 7:17 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB3541EED61244807FE7BDB94BF7AC0@BYAPR11MB3541.namprd11.prod.outlook.com \
--to=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.leroy@6wind.com \
--cc=stable@dpdk.org \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).