patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] raw/ioat: fix missing device name in idxd bus scan
@ 2021-05-27 13:36 Kevin Laatz
  2021-05-27 14:28 ` Bruce Richardson
  0 siblings, 1 reply; 4+ messages in thread
From: Kevin Laatz @ 2021-05-27 13:36 UTC (permalink / raw)
  To: dev; +Cc: stable, bruce.richardson, sunil.pai.g, Kevin Laatz

The device name is not being initialized during the idxd bus scan which
will cause segmentation faults when an appliation tries to access this
information.

This patch adds the required initialization of the device name so that it
can be read without issues.

Fixes: b7aaf417f936 ("raw/ioat: add bus driver for device scanning automatically")

Reported-by: Sunil Pai G <sunil.pai.g@intel.com>
Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
---
 drivers/raw/ioat/idxd_bus.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/raw/ioat/idxd_bus.c b/drivers/raw/ioat/idxd_bus.c
index af400079ab..539f51b1b1 100644
--- a/drivers/raw/ioat/idxd_bus.c
+++ b/drivers/raw/ioat/idxd_bus.c
@@ -313,6 +313,7 @@ dsa_scan(void)
 
 		read_device_int(dev, "numa_node", &numa_node);
 		dev->device.numa_node = numa_node;
+		dev->device.name = dev->wq_name;
 	}
 
 	closedir(dev_dir);
-- 
2.30.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [PATCH] raw/ioat: fix missing device name in idxd bus scan
  2021-05-27 13:36 [dpdk-stable] [PATCH] raw/ioat: fix missing device name in idxd bus scan Kevin Laatz
@ 2021-05-27 14:28 ` Bruce Richardson
  2021-06-04 14:11   ` Pai G, Sunil
  0 siblings, 1 reply; 4+ messages in thread
From: Bruce Richardson @ 2021-05-27 14:28 UTC (permalink / raw)
  To: Kevin Laatz; +Cc: dev, stable, sunil.pai.g

On Thu, May 27, 2021 at 02:36:09PM +0100, Kevin Laatz wrote:
> The device name is not being initialized during the idxd bus scan which
> will cause segmentation faults when an appliation tries to access this
> information.
> 
> This patch adds the required initialization of the device name so that it
> can be read without issues.
> 
> Fixes: b7aaf417f936 ("raw/ioat: add bus driver for device scanning automatically")
> 
> Reported-by: Sunil Pai G <sunil.pai.g@intel.com>
> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [PATCH] raw/ioat: fix missing device name in idxd bus scan
  2021-05-27 14:28 ` Bruce Richardson
@ 2021-06-04 14:11   ` Pai G, Sunil
  2021-06-17  7:21     ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
  0 siblings, 1 reply; 4+ messages in thread
From: Pai G, Sunil @ 2021-06-04 14:11 UTC (permalink / raw)
  To: Richardson, Bruce, Laatz, Kevin; +Cc: dev, stable


> -----Original Message-----
> From: Richardson, Bruce <bruce.richardson@intel.com>
> Sent: Thursday, May 27, 2021 7:58 PM
> To: Laatz, Kevin <kevin.laatz@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Pai G, Sunil <sunil.pai.g@intel.com>
> Subject: Re: [PATCH] raw/ioat: fix missing device name in idxd bus scan
> 
> On Thu, May 27, 2021 at 02:36:09PM +0100, Kevin Laatz wrote:
> > The device name is not being initialized during the idxd bus scan
> > which will cause segmentation faults when an appliation tries to
> > access this information.
> >
> > This patch adds the required initialization of the device name so that
> > it can be read without issues.
> >
> > Fixes: b7aaf417f936 ("raw/ioat: add bus driver for device scanning
> > automatically")
> >
> > Reported-by: Sunil Pai G <sunil.pai.g@intel.com>
> > Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> > ---
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Tested-by: Sunil Pai G <sunil.pai.g@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] raw/ioat: fix missing device name in idxd bus scan
  2021-06-04 14:11   ` Pai G, Sunil
@ 2021-06-17  7:21     ` Thomas Monjalon
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2021-06-17  7:21 UTC (permalink / raw)
  To: Laatz, Kevin; +Cc: Richardson, Bruce, dev, stable, Pai G, Sunil

> > > The device name is not being initialized during the idxd bus scan
> > > which will cause segmentation faults when an appliation tries to
> > > access this information.
> > >
> > > This patch adds the required initialization of the device name so that
> > > it can be read without issues.
> > >
> > > Fixes: b7aaf417f936 ("raw/ioat: add bus driver for device scanning
> > > automatically")
> > >
> > > Reported-by: Sunil Pai G <sunil.pai.g@intel.com>
> > > Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> > > ---
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> Tested-by: Sunil Pai G <sunil.pai.g@intel.com>

Applied, thanks




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-06-17  7:21 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-27 13:36 [dpdk-stable] [PATCH] raw/ioat: fix missing device name in idxd bus scan Kevin Laatz
2021-05-27 14:28 ` Bruce Richardson
2021-06-04 14:11   ` Pai G, Sunil
2021-06-17  7:21     ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git