From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D25FFA09EE
	for <public@inbox.dpdk.org>; Sun, 13 Dec 2020 15:20:22 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id A6EEDC96A;
	Sun, 13 Dec 2020 15:20:21 +0100 (CET)
Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4])
 by dpdk.org (Postfix) with ESMTP id E97BD3257;
 Sun, 13 Dec 2020 15:20:16 +0100 (CET)
Received: from HKMAIL103.nvidia.com (Not Verified[10.18.92.77]) by
 nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
 id <B5fd6231e0000>; Sun, 13 Dec 2020 22:20:14 +0800
Received: from HKMAIL102.nvidia.com (10.18.16.11) by HKMAIL103.nvidia.com
 (10.18.16.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sun, 13 Dec
 2020 14:20:05 +0000
Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.54) by
 HKMAIL102.nvidia.com (10.18.16.11) with Microsoft SMTP Server (TLS)
 id
 15.0.1473.3 via Frontend Transport; Sun, 13 Dec 2020 14:20:05 +0000
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cOsj22MW95ZVcwzICa6TkpGVu3zNNQICZRSN3LqSolVBoXrdWmYbmM0OGTvqnfXElhska58zQbZgKUnaox5gXL9nylb+nkJBHieXrzNsV6zsOrDSrZXdZsrMYaO3XMqsiNgeBLw24QFKGXmckVsrmjRQtdsqKYXdOqdChgrd1aOOyFtYTLOM9VAUhbqdokYuU4i+9Jg59Tg6g9iTek/cVxmkmjjEJL7smcxj/GtqwAylpb6mNY2Kvm/Y1TR5gmSccve4df0NubbfPuygYwQ1v/+US+314r6V1yUjCidJ58OV58GcZeySLX3rUXVTTANlmXmVnwjNpaTCbFkcmiCS8Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2/2wP1aiOVt8QAGpyIzNsHVfPO0z0AL7B3oAjoOGTVY=;
 b=eX2Xs1RIUVKta3xoZE5PHl2v4S2BCO2IIZd8dVm9DQfiUoP/7bTZy7tRENKNF1T0pcLrYCl6l8W8UGJ3+qC+zb+jZci09o1U2qU/V/43gtImXL7djtaB47LjSpbBkZzu7FTqWzJQLYU0nc+lKDGGCG0YIJ6w8em1CRj+HMLvxiB+RBgi503Zds/XfaeHvHoim5dXyyf9HIaL9kWRq0f/QgOhEACOXbb+s5LouCsWC5vALBbpLt3UEr0zuSc8DOxtH07u4K5QXDdvwtgzSmp+Ju+KpMW2h2/aNASR38WQOZt97u57+N5CKdJoz94lANs/YEHDcYZ4ZHPe3Jwrn34umQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
Received: from BYAPR12MB2824.namprd12.prod.outlook.com (2603:10b6:a03:97::10)
 by BYAPR12MB2965.namprd12.prod.outlook.com (2603:10b6:a03:ae::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.20; Sun, 13 Dec
 2020 14:20:02 +0000
Received: from BYAPR12MB2824.namprd12.prod.outlook.com
 ([fe80::1584:8c09:d801:d90d]) by BYAPR12MB2824.namprd12.prod.outlook.com
 ([fe80::1584:8c09:d801:d90d%6]) with mapi id 15.20.3654.025; Sun, 13 Dec 2020
 14:20:02 +0000
From: Odi Assli <odia@nvidia.com>
To: Tal Shnaiderman <talshn@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
 "pallavi.kadam@intel.com" <pallavi.kadam@intel.com>,
 "dmitry.kozliuk@gmail.com" <dmitry.kozliuk@gmail.com>,
 "navasile@linux.microsoft.com" <navasile@linux.microsoft.com>,
 "dmitrym@microsoft.com" <dmitrym@microsoft.com>, "stable@dpdk.org"
 <stable@dpdk.org>
Thread-Topic: [PATCH] pci/windows: do not fail on missing NUMA node for PCIe
Thread-Index: AQHW0VqLeH9EAIrSwUOul+zc4TfRNKn1Eohw
Date: Sun, 13 Dec 2020 14:20:01 +0000
Message-ID: <BYAPR12MB2824667DD9BB72AA1186994AABC80@BYAPR12MB2824.namprd12.prod.outlook.com>
References: <20201213141604.12560-1-talshn@nvidia.com>
In-Reply-To: <20201213141604.12560-1-talshn@nvidia.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: nvidia.com; dkim=none (message not signed)
 header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com;
x-originating-ip: [141.226.15.213]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e8d4e936-7c96-4e54-f881-08d89f722e2e
x-ms-traffictypediagnostic: BYAPR12MB2965:
x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <BYAPR12MB296527DB896747E71A37EADEABC80@BYAPR12MB2965.namprd12.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:451;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 6XJpKcYeqPE3nGuP+RGBBJRxw6KdXHtI0mliMCiTaZGiOr2TOQqMZI7hREFiBy55qqncFjDRwV7gw2b0YpSbgLODcy5xzun9qjmLyPeC9J9TPohcfWG6BMdP7kSlsXwU20/0Fzo48rgFmxUxkq+w8FxN0dM7TeaoE+BYds2VdfIS15ycMmyh8QQ30NZhOC5v+vP0jDfe4ExJUtEgyg1GjjGoz7uUoksrNLdsubjIVQwtVUpryCRDLCKu2J1WI/od4E/lKJfRp8eV433iwDzGvqOkD9qVYtatsgfPFKHJVREa3SimLE8qVuxVEAXlZYNTkECZ6GPt55R03BfiOmUeaQ==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:BYAPR12MB2824.namprd12.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(4636009)(366004)(346002)(136003)(376002)(7696005)(71200400001)(4326008)(8676002)(8936002)(54906003)(508600001)(86362001)(110136005)(33656002)(5660300002)(26005)(66476007)(66446008)(66556008)(52536014)(83380400001)(2906002)(186003)(55016002)(66946007)(9686003)(6506007)(76116006)(64756008);
 DIR:OUT; SFP:1101; 
x-ms-exchange-antispam-messagedata: =?us-ascii?Q?AN++Rb7YXe1jFsAB4nVWmwtz+ZvUYlmeEThN40Uqa6Xa6eXx1mrvFfoj/sWw?=
 =?us-ascii?Q?4vKLizdxMim7LdyqZ2+nu+sWHVd0M5uE5g4Mp93GNIYmSVJO4gitK9Kct69m?=
 =?us-ascii?Q?hffHJnnET+Oh1z8sDdJ01IUqJ5/HXzY4rHal1/Q8LDi2QQgoVsQ0/VqxXOSe?=
 =?us-ascii?Q?jDBEzNT5GTq16Y+KLF8JtgWadvk2/8CqvdTY1r8EC4dXgdTv6dA6dzDCCDBn?=
 =?us-ascii?Q?zeUZCqMKxjtCDfFSDV4hD9VmhoBkkWrqMjk6mnFyH5+DZn/JaE8KsfUbST1e?=
 =?us-ascii?Q?nbFk1asNi/mdYn4fmipdBqM9YubHBxt5lgf9hWU6ZKpCDJiy2CE2BDZwzjHB?=
 =?us-ascii?Q?4nLf4IgkiUaLbsNLliKe9BQKYFhap5JjitdOUW6/eONKQWF2aaamhBn43Y52?=
 =?us-ascii?Q?feru0EBpbQEhsJ+NDV8VRUku+L5BHjmN2s/V0//CS84k7dPIVsrUKvzMvbn3?=
 =?us-ascii?Q?2D8DM3o7F/Jptkb0CkEOmuspv1fVGG2v7U6E1hBRKXyaIkBHP8cza4DNAGi7?=
 =?us-ascii?Q?wdtbGe1L3xWrxMNN56/JT0dNoTkqTYqyz/j4xf4chFznN474B8CpVpCDyy00?=
 =?us-ascii?Q?y6RrddmRAapzeQfa4iBCEaShIc722rH0uW1mfBWiAgcNqiWTqPZCpKONrD7a?=
 =?us-ascii?Q?OmR0tWIQryVWi0mFmH+jY2fa+npmaXi+OjWY5/xF1QxhMZ6QO9jp2zuGEk2t?=
 =?us-ascii?Q?I6HjR+EsoZvkgvF/cT099FaRBBfAc0qZSx1AbNR/Ct5WQzcAzUHnwhyxwhLv?=
 =?us-ascii?Q?1L4ii1v50iSFmAJ2a9rgqPnD8KQaDSpVWWh0tjMWxhyyEt6rYdJ7CMJ8sR+6?=
 =?us-ascii?Q?I/vfo+Tpzp0yVqtQkJ2I5y05bBMtVJEBJ4E+1qQ5skSVrEPSNS8MuudVpWZR?=
 =?us-ascii?Q?ObD6aKTGvtGLohvh33fm/CMVuzbYQjz27G5NNrD42TPfVHnpUZZGj2yiU0Z5?=
 =?us-ascii?Q?RAsPGY6xImnQWfCzn8dUyMrRuOKQKeH9bk9IoCChJQc=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2824.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e8d4e936-7c96-4e54-f881-08d89f722e2e
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2020 14:20:01.9535 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KzX12xkuEPZ4NrdBYR98aPqHn85OP4x4cGHYI0WERiCbqFGBe7c4Rp4bSAwZkt0S
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2965
X-OriginatorOrg: Nvidia.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
 t=1607869214; bh=2/2wP1aiOVt8QAGpyIzNsHVfPO0z0AL7B3oAjoOGTVY=;
 h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:
 CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:
 In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach:
 X-MS-TNEF-Correlator:authentication-results:x-originating-ip:
 x-ms-publictraffictype:x-ms-office365-filtering-correlation-id:
 x-ms-traffictypediagnostic:x-ld-processed:
 x-ms-exchange-transport-forked:x-microsoft-antispam-prvs:
 x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck:
 x-microsoft-antispam:x-microsoft-antispam-message-info:
 x-forefront-antispam-report:x-ms-exchange-antispam-messagedata:
 Content-Type:Content-Transfer-Encoding:MIME-Version:
 X-MS-Exchange-CrossTenant-AuthAs:
 X-MS-Exchange-CrossTenant-AuthSource:
 X-MS-Exchange-CrossTenant-Network-Message-Id:
 X-MS-Exchange-CrossTenant-originalarrivaltime:
 X-MS-Exchange-CrossTenant-fromentityheader:
 X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:
 X-MS-Exchange-CrossTenant-userprincipalname:
 X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg;
 b=UyJOkabWIYMMjw7G+Sa7CrD0uFgdE7ZFUbfIr/xJ8uVBJq3UQZD7kkpx22YVhXXZO
 ojW2V7odDZ53YOzP5nElnshUYDp3em4nsOSLlDzjRXRzG/QDuIpKeCG8Wl7tDFacRM
 suJ5HukVcW746n5H/BLbBoFUmRCUyiXxkavIbEiAA28sqE5RcDpqHDqiahLCWcCa1P
 Wio3c4BK3dW9MhkkHp/t+T12cYObxCRlPiRBEXgBy9RjletIW5+3c0x9rNwJDbHOk2
 V6ND5jDfYDj3IGiDOILFNozYm+obXeN8xOo5/NK9iLZuZdf9aF1xUed0vTitm69Yzt
 tsnARUs9P3jdw==
Subject: Re: [dpdk-stable] [PATCH] pci/windows: do not fail on missing NUMA
	node for PCIe
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>

> Subject: [PATCH] pci/windows: do not fail on missing NUMA node for PCIe
>=20
> On older processors, NUMA isn't bound to PCIe locality.
> those cases return ERROR_NOT_FOUND in response to the
> SetupDiGetDevicePropertyW call with DEVPKEY_Device_Numa_Node
> attribute.
>=20
> This error fails the probe process for the PCIe device.
> this commit will ignore such failure and will set the numa_node to 0.
>=20
> Fixes: b762221ac24f ("bus/pci: support Windows with bifurcated drivers")
> Cc: stable@dpdk.org
>=20
> Reported-by: Odi Assli <odia@nvidia.com>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---
>  drivers/bus/pci/windows/pci.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>=20
> diff --git a/drivers/bus/pci/windows/pci.c b/drivers/bus/pci/windows/pci.=
c
> index 33a5fb1d83..62bac4b8ec 100644
> --- a/drivers/bus/pci/windows/pci.c
> +++ b/drivers/bus/pci/windows/pci.c
> @@ -234,6 +234,15 @@ get_device_resource_info(HDEVINFO dev_info,
>  		&DEVPKEY_Device_Numa_Node, &property_type,
>  		(BYTE *)&numa_node, sizeof(numa_node), NULL, 0);
>  	if (!res) {
> +		DWORD error =3D GetLastError();
> +		if (error =3D=3D ERROR_NOT_FOUND) {
> +			/* On older CPUs, NUMA isn't bound to PCIe locality
> +			 * We do not want to fail the probing process
> +			 * Setting 0 for numa_node and returnng
> ERROR_SUCCESS.
> +			 */
> +			dev->device.numa_node =3D 0;
> +			return ERROR_SUCCESS;
> +		}
>  		RTE_LOG_WIN32_ERR("SetupDiGetDevicePropertyW"
>  			"(DEVPKEY_Device_Numa_Node)");
>  		return -1;
> --
> 2.16.1.windows.4

Tested-by: Odi Assli <odia@nvidia.com>