patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Odi Assli <odia@nvidia.com>
To: Tal Shnaiderman <talshn@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
	Matan Azrad <matan@nvidia.com>,
	Raslan Darawsheh <rasland@nvidia.com>,
	Asaf Penso <asafp@nvidia.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH 1/3] net/mlx5: fix unsupported offloads disablement
Date: Thu, 22 Apr 2021 10:17:28 +0000
Message-ID: <BYAPR12MB2824B1B9ABAE876F6A74FED7AB469@BYAPR12MB2824.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20210421163441.17240-2-talshn@nvidia.com>

> Subject: [PATCH 1/3] net/mlx5: fix unsupported offloads disablement
> 
> mlx5 offloads which are unsupported on Windows are currently disabled by
> checks with IBV/DV flags which are irrelevant to Windows.
> 
> The checks are removed until they are fully available.
> 
> Fixes: 93f4ece91a1f ("net/mlx5: spawn ethdev ports on Windows")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
>  drivers/net/mlx5/windows/mlx5_os.c | 15 +--------------
>  1 file changed, 1 insertion(+), 14 deletions(-)
> 
> diff --git a/drivers/net/mlx5/windows/mlx5_os.c
> b/drivers/net/mlx5/windows/mlx5_os.c
> index 814063b5ce..5e53042b85 100644
> --- a/drivers/net/mlx5/windows/mlx5_os.c
> +++ b/drivers/net/mlx5/windows/mlx5_os.c
> @@ -359,11 +359,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,
>  	config->swp = 0;
>  	config->ind_table_max_size =
>  		sh->device_attr.max_rwq_indirection_table_size;
> -	if (RTE_CACHE_LINE_SIZE == 128 &&
> -	    !(device_attr.flags &
> MLX5DV_CONTEXT_FLAGS_CQE_128B_COMP))
> -		cqe_comp = 0;
> -	else
> -		cqe_comp = 1;
> +	cqe_comp = 0;
>  	config->cqe_comp = cqe_comp;
>  	DRV_LOG(DEBUG, "tunnel offloading is not supported");
>  	config->tunnel_en = 0;
> @@ -424,8 +420,6 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,
>  	err = mlx5_dev_check_sibling_config(priv, config);
>  	if (err)
>  		goto error;
> -	config->hw_csum = !!(sh->device_attr.device_cap_flags_ex &
> -			    IBV_DEVICE_RAW_IP_CSUM);
>  	DRV_LOG(DEBUG, "checksum offloading is %ssupported",
>  		(config->hw_csum ? "" : "not "));
>  	DRV_LOG(DEBUG, "counters are not supported"); @@ -439,19
> +433,12 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,
>  		config->ind_table_max_size = ETH_RSS_RETA_SIZE_512;
>  	DRV_LOG(DEBUG, "maximum Rx indirection table size is %u",
>  		config->ind_table_max_size);
> -	config->hw_vlan_strip = !!(sh->device_attr.raw_packet_caps &
> -
> IBV_RAW_PACKET_CAP_CVLAN_STRIPPING);
>  	DRV_LOG(DEBUG, "VLAN stripping is %ssupported",
>  		(config->hw_vlan_strip ? "" : "not "));
> -	config->hw_fcs_strip = !!(sh->device_attr.raw_packet_caps &
> -				 IBV_RAW_PACKET_CAP_SCATTER_FCS);
>  	if (config->hw_padding) {
>  		DRV_LOG(DEBUG, "Rx end alignment padding isn't
> supported");
>  		config->hw_padding = 0;
>  	}
> -	config->tso = (sh->device_attr.max_tso > 0 &&
> -		      (sh->device_attr.tso_supported_qpts &
> -		       (1 << IBV_QPT_RAW_PACKET)));
>  	if (config->tso)
>  		config->tso_max_payload_sz = sh->device_attr.max_tso;
>  	DRV_LOG(DEBUG, "%sMPS is %s.",
> --
> 2.16.1.windows.4

Tested-by: Odi Assli <odia@nvidia.com>


      reply	other threads:[~2021-04-22 10:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210421163441.17240-1-talshn@nvidia.com>
2021-04-21 16:34 ` Tal Shnaiderman
2021-04-22 10:17   ` Odi Assli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR12MB2824B1B9ABAE876F6A74FED7AB469@BYAPR12MB2824.namprd12.prod.outlook.com \
    --to=odia@nvidia.com \
    --cc=asafp@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=matan@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=talshn@nvidia.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git