* [dpdk-stable] [PATCH 1/3] net/mlx5: fix unsupported offloads disablement [not found] <20210421163441.17240-1-talshn@nvidia.com> @ 2021-04-21 16:34 ` Tal Shnaiderman 2021-04-22 10:17 ` Odi Assli 0 siblings, 1 reply; 2+ messages in thread From: Tal Shnaiderman @ 2021-04-21 16:34 UTC (permalink / raw) To: dev; +Cc: thomas, matan, rasland, asafp, odia, stable mlx5 offloads which are unsupported on Windows are currently disabled by checks with IBV/DV flags which are irrelevant to Windows. The checks are removed until they are fully available. Fixes: 93f4ece91a1f ("net/mlx5: spawn ethdev ports on Windows") Cc: stable@dpdk.org Signed-off-by: Tal Shnaiderman <talshn@nvidia.com> Acked-by: Matan Azrad <matan@nvidia.com> --- drivers/net/mlx5/windows/mlx5_os.c | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/net/mlx5/windows/mlx5_os.c b/drivers/net/mlx5/windows/mlx5_os.c index 814063b5ce..5e53042b85 100644 --- a/drivers/net/mlx5/windows/mlx5_os.c +++ b/drivers/net/mlx5/windows/mlx5_os.c @@ -359,11 +359,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, config->swp = 0; config->ind_table_max_size = sh->device_attr.max_rwq_indirection_table_size; - if (RTE_CACHE_LINE_SIZE == 128 && - !(device_attr.flags & MLX5DV_CONTEXT_FLAGS_CQE_128B_COMP)) - cqe_comp = 0; - else - cqe_comp = 1; + cqe_comp = 0; config->cqe_comp = cqe_comp; DRV_LOG(DEBUG, "tunnel offloading is not supported"); config->tunnel_en = 0; @@ -424,8 +420,6 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, err = mlx5_dev_check_sibling_config(priv, config); if (err) goto error; - config->hw_csum = !!(sh->device_attr.device_cap_flags_ex & - IBV_DEVICE_RAW_IP_CSUM); DRV_LOG(DEBUG, "checksum offloading is %ssupported", (config->hw_csum ? "" : "not ")); DRV_LOG(DEBUG, "counters are not supported"); @@ -439,19 +433,12 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, config->ind_table_max_size = ETH_RSS_RETA_SIZE_512; DRV_LOG(DEBUG, "maximum Rx indirection table size is %u", config->ind_table_max_size); - config->hw_vlan_strip = !!(sh->device_attr.raw_packet_caps & - IBV_RAW_PACKET_CAP_CVLAN_STRIPPING); DRV_LOG(DEBUG, "VLAN stripping is %ssupported", (config->hw_vlan_strip ? "" : "not ")); - config->hw_fcs_strip = !!(sh->device_attr.raw_packet_caps & - IBV_RAW_PACKET_CAP_SCATTER_FCS); if (config->hw_padding) { DRV_LOG(DEBUG, "Rx end alignment padding isn't supported"); config->hw_padding = 0; } - config->tso = (sh->device_attr.max_tso > 0 && - (sh->device_attr.tso_supported_qpts & - (1 << IBV_QPT_RAW_PACKET))); if (config->tso) config->tso_max_payload_sz = sh->device_attr.max_tso; DRV_LOG(DEBUG, "%sMPS is %s.", -- 2.16.1.windows.4 ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [PATCH 1/3] net/mlx5: fix unsupported offloads disablement 2021-04-21 16:34 ` [dpdk-stable] [PATCH 1/3] net/mlx5: fix unsupported offloads disablement Tal Shnaiderman @ 2021-04-22 10:17 ` Odi Assli 0 siblings, 0 replies; 2+ messages in thread From: Odi Assli @ 2021-04-22 10:17 UTC (permalink / raw) To: Tal Shnaiderman, dev Cc: NBU-Contact-Thomas Monjalon, Matan Azrad, Raslan Darawsheh, Asaf Penso, stable > Subject: [PATCH 1/3] net/mlx5: fix unsupported offloads disablement > > mlx5 offloads which are unsupported on Windows are currently disabled by > checks with IBV/DV flags which are irrelevant to Windows. > > The checks are removed until they are fully available. > > Fixes: 93f4ece91a1f ("net/mlx5: spawn ethdev ports on Windows") > Cc: stable@dpdk.org > > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com> > Acked-by: Matan Azrad <matan@nvidia.com> > --- > drivers/net/mlx5/windows/mlx5_os.c | 15 +-------------- > 1 file changed, 1 insertion(+), 14 deletions(-) > > diff --git a/drivers/net/mlx5/windows/mlx5_os.c > b/drivers/net/mlx5/windows/mlx5_os.c > index 814063b5ce..5e53042b85 100644 > --- a/drivers/net/mlx5/windows/mlx5_os.c > +++ b/drivers/net/mlx5/windows/mlx5_os.c > @@ -359,11 +359,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, > config->swp = 0; > config->ind_table_max_size = > sh->device_attr.max_rwq_indirection_table_size; > - if (RTE_CACHE_LINE_SIZE == 128 && > - !(device_attr.flags & > MLX5DV_CONTEXT_FLAGS_CQE_128B_COMP)) > - cqe_comp = 0; > - else > - cqe_comp = 1; > + cqe_comp = 0; > config->cqe_comp = cqe_comp; > DRV_LOG(DEBUG, "tunnel offloading is not supported"); > config->tunnel_en = 0; > @@ -424,8 +420,6 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, > err = mlx5_dev_check_sibling_config(priv, config); > if (err) > goto error; > - config->hw_csum = !!(sh->device_attr.device_cap_flags_ex & > - IBV_DEVICE_RAW_IP_CSUM); > DRV_LOG(DEBUG, "checksum offloading is %ssupported", > (config->hw_csum ? "" : "not ")); > DRV_LOG(DEBUG, "counters are not supported"); @@ -439,19 > +433,12 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, > config->ind_table_max_size = ETH_RSS_RETA_SIZE_512; > DRV_LOG(DEBUG, "maximum Rx indirection table size is %u", > config->ind_table_max_size); > - config->hw_vlan_strip = !!(sh->device_attr.raw_packet_caps & > - > IBV_RAW_PACKET_CAP_CVLAN_STRIPPING); > DRV_LOG(DEBUG, "VLAN stripping is %ssupported", > (config->hw_vlan_strip ? "" : "not ")); > - config->hw_fcs_strip = !!(sh->device_attr.raw_packet_caps & > - IBV_RAW_PACKET_CAP_SCATTER_FCS); > if (config->hw_padding) { > DRV_LOG(DEBUG, "Rx end alignment padding isn't > supported"); > config->hw_padding = 0; > } > - config->tso = (sh->device_attr.max_tso > 0 && > - (sh->device_attr.tso_supported_qpts & > - (1 << IBV_QPT_RAW_PACKET))); > if (config->tso) > config->tso_max_payload_sz = sh->device_attr.max_tso; > DRV_LOG(DEBUG, "%sMPS is %s.", > -- > 2.16.1.windows.4 Tested-by: Odi Assli <odia@nvidia.com> ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-22 10:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210421163441.17240-1-talshn@nvidia.com>
2021-04-21 16:34 ` [dpdk-stable] [PATCH 1/3] net/mlx5: fix unsupported offloads disablement Tal Shnaiderman
2021-04-22 10:17 ` Odi Assli
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).