[PATCH] net/mlx5: fix wrong error log in async flow destruction

[PATCH] net/mlx5: fix wrong error log in async flow destruction

[Michael Baum]

The flow_hw_async_flow_destroy() function fills the error structure in
case of failure.

The error log reported by function is "fail to create rte flow" while
the correct failure is in destruction.

This patch changes the error log to report "fail to destroy rte flow".

Fixes: c40c061a022e ("net/mlx5: add basic flow queue operation")
Cc: suanmingm@nvidia.com
Cc: stable@dpdk.org

Signed-off-by: Michael Baum <michaelba@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
 drivers/net/mlx5/mlx5_flow_hw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c
index 537bcf141d..979eec8dc4 100644
--- a/drivers/net/mlx5/mlx5_flow_hw.c
+++ b/drivers/net/mlx5/mlx5_flow_hw.c
@@ -2623,7 +2623,7 @@ flow_hw_async_flow_destroy(struct rte_eth_dev *dev,
 error:
 	return rte_flow_error_set(error, rte_errno,
 			RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,
-			"fail to create rte flow");
+			"fail to destroy rte flow");
 }
 
 /**
-- 
2.25.1

RE: [PATCH] net/mlx5: fix wrong error log in async flow destruction

[Raslan Darawsheh]

Hi,

> -----Original Message-----
> From: Michael Baum <michaelba@nvidia.com>
> Sent: Sunday, November 13, 2022 1:07 PM
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@nvidia.com>; Raslan Darawsheh
> <rasland@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>;
> Suanming Mou <suanmingm@nvidia.com>; stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix wrong error log in async flow destruction
> 
> The flow_hw_async_flow_destroy() function fills the error structure in
> case of failure.
> 
> The error log reported by function is "fail to create rte flow" while
> the correct failure is in destruction.
> 
> This patch changes the error log to report "fail to destroy rte flow".
> 
> Fixes: c40c061a022e ("net/mlx5: add basic flow queue operation")
> Cc: suanmingm@nvidia.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Michael Baum <michaelba@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh