patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Rasesh Mody <rmody@marvell.com>
To: Devendra Singh Rawat <dsinghrawat@marvell.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>
Cc: GR-Everest-DPDK-Dev <GR-Everest-DPDK-Dev@marvell.com>,
	Igor Russkikh <irusskikh@marvell.com>,
	Manish Chopra <manishc@marvell.com>,
	"Devendra Singh Rawat" <dsinghrawat@marvell.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] net/qede: change driver's default load parameter
Date: Fri, 4 Dec 2020 04:32:29 +0000
Message-ID: <BYAPR18MB2838EC56D59FCE49A0347AC7B5F10@BYAPR18MB2838.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20201203133023.4060250-1-dsinghrawat@marvell.com>

Hi Devendra,

>From: Devendra Singh Rawat <dsinghrawat@marvell.com>
>Sent: Thursday, December 03, 2020 5:30 AM
>
>Loading ecore clients (PMD or linux kernel driver) having different ecore
>versions concurrently, is problematic from device's init/config perspective.
>This fix changes driver's default load parameter to have ecore version
>validated by MFW. All ecore clients having matching ecore version should be
>allowed to load, otherwise MFW should fail the load request.
>

Accompanying this change, I think, Co-existence considerations section in NIC guide needs to be updated.

Thanks,
Rasesh

>Fixes: c5e1108920 ("alter driver's force load behavior")
>Cc: stable@dpdk.org
>
>Signed-off-by: Devendra Singh Rawat <dsinghrawat@marvell.com>
>Signed-off-by: Manish Chopra <manishc@marvell.com>
>Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
>---
> drivers/net/qede/qede_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c
>index caa9d1d4f..d208d276a 100644
>--- a/drivers/net/qede/qede_main.c
>+++ b/drivers/net/qede/qede_main.c
>@@ -300,7 +300,7 @@ static int qed_slowpath_start(struct ecore_dev *edev,
> 	memset(&drv_load_params, 0, sizeof(drv_load_params));
> 	drv_load_params.mfw_timeout_val =
>ECORE_LOAD_REQ_LOCK_TO_DEFAULT;
> 	drv_load_params.avoid_eng_reset = false;
>-	drv_load_params.override_force_load =
>ECORE_OVERRIDE_FORCE_LOAD_ALWAYS;
>+	drv_load_params.override_force_load =
>ECORE_OVERRIDE_FORCE_LOAD_NONE;
> 	hw_init_params.avoid_eng_affin = false;
> 	hw_init_params.p_drv_load_params = &drv_load_params;
>
>--
>2.18.2



  reply	other threads:[~2020-12-04  4:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-03 13:30 Devendra Singh Rawat
2020-12-04  4:32 ` Rasesh Mody [this message]
2021-01-06 13:20 ` [dpdk-stable] [PATCH v2] " Devendra Singh Rawat
2021-01-06 15:17   ` Devendra Singh Rawat
2021-01-12  4:52     ` [dpdk-stable] [dpdk-dev] " Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR18MB2838EC56D59FCE49A0347AC7B5F10@BYAPR18MB2838.namprd18.prod.outlook.com \
    --to=rmody@marvell.com \
    --cc=GR-Everest-DPDK-Dev@marvell.com \
    --cc=dev@dpdk.org \
    --cc=dsinghrawat@marvell.com \
    --cc=ferruh.yigit@intel.com \
    --cc=irusskikh@marvell.com \
    --cc=jerinj@marvell.com \
    --cc=manishc@marvell.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git