* [PATCH v2] lib/hash: Set the maximum reclamation size to user provided value [not found] <396BD6B3-B936-42F3-9FA9-B07578786FE5@arm.com> @ 2024-05-13 10:00 ` Abdullah Ömer Yamaç 2024-05-13 14:34 ` Honnappa Nagarahalli 0 siblings, 1 reply; 7+ messages in thread From: Abdullah Ömer Yamaç @ 2024-05-13 10:00 UTC (permalink / raw) To: dev Cc: stable, Abdullah Ömer Yamaç, dharmik.thakkar, Honnappa Nagarahalli, Yipeng Wang, Sameh Gobriel, Bruce Richardson, Vladimir Medvedkin In the previous implementation, the maximum reclamation size was set to RTE_HASH_RCU_DQ_RECLAIM_MAX and it was not configurable. This patch uses the configuration argument to set the maximum reclamation size. Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation") Cc: dharmik.thakkar@arm.com Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> Cc: Yipeng Wang <yipeng1.wang@intel.com> Cc: Sameh Gobriel <sameh.gobriel@intel.com> Cc: Bruce Richardson <bruce.richardson@intel.com> Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com> Signed-off-by: Abdullah Ömer Yamaç <aomeryamac@gmail.com> --- lib/hash/rte_cuckoo_hash.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c index 9cf94645f6..f7f0fdfd21 100644 --- a/lib/hash/rte_cuckoo_hash.c +++ b/lib/hash/rte_cuckoo_hash.c @@ -1557,6 +1557,7 @@ rte_hash_rcu_qsbr_add(struct rte_hash *h, struct rte_hash_rcu_config *cfg) if (params.size == 0) params.size = total_entries; params.trigger_reclaim_limit = cfg->trigger_reclaim_limit; + params.max_reclaim_size = cfg->max_reclaim_size; if (params.max_reclaim_size == 0) params.max_reclaim_size = RTE_HASH_RCU_DQ_RECLAIM_MAX; params.esize = sizeof(struct __rte_hash_rcu_dq_entry); -- 2.34.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] lib/hash: Set the maximum reclamation size to user provided value 2024-05-13 10:00 ` [PATCH v2] lib/hash: Set the maximum reclamation size to user provided value Abdullah Ömer Yamaç @ 2024-05-13 14:34 ` Honnappa Nagarahalli 2024-05-13 15:22 ` Abdullah Ömer Yamaç 0 siblings, 1 reply; 7+ messages in thread From: Honnappa Nagarahalli @ 2024-05-13 14:34 UTC (permalink / raw) To: Abdullah Ömer Yamaç Cc: dev, stable, Dharmik Jayesh Thakkar, Yipeng Wang, Sameh Gobriel, Bruce Richardson, Vladimir Medvedkin, nd Hi Abdullah, I do not see the changes I suggested in this version. > On May 13, 2024, at 5:00 AM, Abdullah Ömer Yamaç <aomeryamac@gmail.com> wrote: > > In the previous implementation, the maximum reclamation size was set > to RTE_HASH_RCU_DQ_RECLAIM_MAX and it was not configurable. This patch > uses the configuration argument to set the maximum reclamation size. > > Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation") > Cc: dharmik.thakkar@arm.com > Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> > Cc: Yipeng Wang <yipeng1.wang@intel.com> > Cc: Sameh Gobriel <sameh.gobriel@intel.com> > Cc: Bruce Richardson <bruce.richardson@intel.com> > Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com> > > Signed-off-by: Abdullah Ömer Yamaç <aomeryamac@gmail.com> > --- > lib/hash/rte_cuckoo_hash.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c > index 9cf94645f6..f7f0fdfd21 100644 > --- a/lib/hash/rte_cuckoo_hash.c > +++ b/lib/hash/rte_cuckoo_hash.c > @@ -1557,6 +1557,7 @@ rte_hash_rcu_qsbr_add(struct rte_hash *h, struct rte_hash_rcu_config *cfg) > if (params.size == 0) > params.size = total_entries; > params.trigger_reclaim_limit = cfg->trigger_reclaim_limit; > + params.max_reclaim_size = cfg->max_reclaim_size; > if (params.max_reclaim_size == 0) > params.max_reclaim_size = RTE_HASH_RCU_DQ_RECLAIM_MAX; > params.esize = sizeof(struct __rte_hash_rcu_dq_entry); > -- > 2.34.1 > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] lib/hash: Set the maximum reclamation size to user provided value 2024-05-13 14:34 ` Honnappa Nagarahalli @ 2024-05-13 15:22 ` Abdullah Ömer Yamaç 2024-05-13 16:17 ` Honnappa Nagarahalli 0 siblings, 1 reply; 7+ messages in thread From: Abdullah Ömer Yamaç @ 2024-05-13 15:22 UTC (permalink / raw) To: Honnappa Nagarahalli Cc: dev, stable, Dharmik Jayesh Thakkar, Yipeng Wang, Sameh Gobriel, Bruce Richardson, Vladimir Medvedkin, nd [-- Attachment #1: Type: text/plain, Size: 2137 bytes --] Hello, I saw two comments, and the first one " Please add: stable@dpdk.org to the Cc list" then I added stable@dpdk.org to Cc. Would you like me to add it to the commit? Second one : “Set the maximum reclamation size to user provided value” I set this comment to the header. I thought it was more meaningful in the header. If you want also, I can insert it in the description part. Do I miss something else? On Mon, May 13, 2024 at 5:34 PM Honnappa Nagarahalli < Honnappa.Nagarahalli@arm.com> wrote: > Hi Abdullah, > I do not see the changes I suggested in this version. > > > On May 13, 2024, at 5:00 AM, Abdullah Ömer Yamaç <aomeryamac@gmail.com> > wrote: > > > > In the previous implementation, the maximum reclamation size was set > > to RTE_HASH_RCU_DQ_RECLAIM_MAX and it was not configurable. This patch > > uses the configuration argument to set the maximum reclamation size. > > > > Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation") > > Cc: dharmik.thakkar@arm.com > > Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> > > Cc: Yipeng Wang <yipeng1.wang@intel.com> > > Cc: Sameh Gobriel <sameh.gobriel@intel.com> > > Cc: Bruce Richardson <bruce.richardson@intel.com> > > Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com> > > > > Signed-off-by: Abdullah Ömer Yamaç <aomeryamac@gmail.com> > > --- > > lib/hash/rte_cuckoo_hash.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c > > index 9cf94645f6..f7f0fdfd21 100644 > > --- a/lib/hash/rte_cuckoo_hash.c > > +++ b/lib/hash/rte_cuckoo_hash.c > > @@ -1557,6 +1557,7 @@ rte_hash_rcu_qsbr_add(struct rte_hash *h, struct > rte_hash_rcu_config *cfg) > > if (params.size == 0) > > params.size = total_entries; > > params.trigger_reclaim_limit = cfg->trigger_reclaim_limit; > > + params.max_reclaim_size = cfg->max_reclaim_size; > > if (params.max_reclaim_size == 0) > > params.max_reclaim_size = RTE_HASH_RCU_DQ_RECLAIM_MAX; > > params.esize = sizeof(struct __rte_hash_rcu_dq_entry); > > -- > > 2.34.1 > > > > [-- Attachment #2: Type: text/html, Size: 3404 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] lib/hash: Set the maximum reclamation size to user provided value 2024-05-13 15:22 ` Abdullah Ömer Yamaç @ 2024-05-13 16:17 ` Honnappa Nagarahalli 2024-05-13 16:35 ` [PATCH v3] lib/hash: setting the maximum reclamation size Abdullah Ömer Yamaç 0 siblings, 1 reply; 7+ messages in thread From: Honnappa Nagarahalli @ 2024-05-13 16:17 UTC (permalink / raw) To: Abdullah Ömer Yamaç Cc: dev, stable, Dharmik Jayesh Thakkar, Yipeng Wang, Sameh Gobriel, Bruce Richardson, Vladimir Medvedkin, nd > On May 13, 2024, at 10:22 AM, Abdullah Ömer Yamaç <aomeryamac@gmail.com> wrote: > > Hello, > I saw two comments, and the first one > " Please add: > stable@dpdk.org to the Cc list" then I added stable@dpdk.org to Cc. Would you like me to add it to the commit? I thought it needs to be added to the commit message as per contributing guidelines [1]. [1] https://doc.dpdk.org/guides/contributing/patches.html#patch-for-stable-releases > > Second one : > “Set the maximum reclamation size to user provided value” I set this comment to the header. I thought it was more meaningful in the header. If you want also, I can insert it in the description part. I meant that we should simplify the long commit message. > > Do I miss something else? > > > On Mon, May 13, 2024 at 5:34 PM Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> wrote: > Hi Abdullah, > I do not see the changes I suggested in this version. > > > On May 13, 2024, at 5:00 AM, Abdullah Ömer Yamaç <aomeryamac@gmail.com> wrote: > > > > In the previous implementation, the maximum reclamation size was set > > to RTE_HASH_RCU_DQ_RECLAIM_MAX and it was not configurable. This patch > > uses the configuration argument to set the maximum reclamation size. > > > > Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation") > > Cc: dharmik.thakkar@arm.com > > Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> > > Cc: Yipeng Wang <yipeng1.wang@intel.com> > > Cc: Sameh Gobriel <sameh.gobriel@intel.com> > > Cc: Bruce Richardson <bruce.richardson@intel.com> > > Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com> > > > > Signed-off-by: Abdullah Ömer Yamaç <aomeryamac@gmail.com> > > --- > > lib/hash/rte_cuckoo_hash.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c > > index 9cf94645f6..f7f0fdfd21 100644 > > --- a/lib/hash/rte_cuckoo_hash.c > > +++ b/lib/hash/rte_cuckoo_hash.c > > @@ -1557,6 +1557,7 @@ rte_hash_rcu_qsbr_add(struct rte_hash *h, struct rte_hash_rcu_config *cfg) > > if (params.size == 0) > > params.size = total_entries; > > params.trigger_reclaim_limit = cfg->trigger_reclaim_limit; > > + params.max_reclaim_size = cfg->max_reclaim_size; > > if (params.max_reclaim_size == 0) > > params.max_reclaim_size = RTE_HASH_RCU_DQ_RECLAIM_MAX; > > params.esize = sizeof(struct __rte_hash_rcu_dq_entry); > > -- > > 2.34.1 > > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v3] lib/hash: setting the maximum reclamation size 2024-05-13 16:17 ` Honnappa Nagarahalli @ 2024-05-13 16:35 ` Abdullah Ömer Yamaç 2024-05-14 20:52 ` Honnappa Nagarahalli 0 siblings, 1 reply; 7+ messages in thread From: Abdullah Ömer Yamaç @ 2024-05-13 16:35 UTC (permalink / raw) To: dev Cc: Abdullah Ömer Yamaç, stable, dharmik.thakkar, Honnappa Nagarahalli, Yipeng Wang, Sameh Gobriel, Bruce Richardson, Vladimir Medvedkin Set the maximum reclamation size to user provided value Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation") Cc: stable@dpdk.org Cc: dharmik.thakkar@arm.com Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> Cc: Yipeng Wang <yipeng1.wang@intel.com> Cc: Sameh Gobriel <sameh.gobriel@intel.com> Cc: Bruce Richardson <bruce.richardson@intel.com> Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com> Signed-off-by: Abdullah Ömer Yamaç <aomeryamac@gmail.com> --- lib/hash/rte_cuckoo_hash.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c index 9cf94645f6..f7f0fdfd21 100644 --- a/lib/hash/rte_cuckoo_hash.c +++ b/lib/hash/rte_cuckoo_hash.c @@ -1557,6 +1557,7 @@ rte_hash_rcu_qsbr_add(struct rte_hash *h, struct rte_hash_rcu_config *cfg) if (params.size == 0) params.size = total_entries; params.trigger_reclaim_limit = cfg->trigger_reclaim_limit; + params.max_reclaim_size = cfg->max_reclaim_size; if (params.max_reclaim_size == 0) params.max_reclaim_size = RTE_HASH_RCU_DQ_RECLAIM_MAX; params.esize = sizeof(struct __rte_hash_rcu_dq_entry); -- 2.34.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3] lib/hash: setting the maximum reclamation size 2024-05-13 16:35 ` [PATCH v3] lib/hash: setting the maximum reclamation size Abdullah Ömer Yamaç @ 2024-05-14 20:52 ` Honnappa Nagarahalli 2024-06-18 14:09 ` David Marchand 0 siblings, 1 reply; 7+ messages in thread From: Honnappa Nagarahalli @ 2024-05-14 20:52 UTC (permalink / raw) To: Abdullah Ömer Yamaç Cc: dev, stable, Dharmik Jayesh Thakkar, Yipeng Wang, Sameh Gobriel, Bruce Richardson, Vladimir Medvedkin, nd > On May 13, 2024, at 11:35 AM, Abdullah Ömer Yamaç <aomeryamac@gmail.com> wrote: > > Set the maximum reclamation size to user provided value > > Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation") > Cc: stable@dpdk.org > Cc: dharmik.thakkar@arm.com > Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> > Cc: Yipeng Wang <yipeng1.wang@intel.com> > Cc: Sameh Gobriel <sameh.gobriel@intel.com> > Cc: Bruce Richardson <bruce.richardson@intel.com> > Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com> > > Signed-off-by: Abdullah Ömer Yamaç <aomeryamac@gmail.com> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> > --- > lib/hash/rte_cuckoo_hash.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c > index 9cf94645f6..f7f0fdfd21 100644 > --- a/lib/hash/rte_cuckoo_hash.c > +++ b/lib/hash/rte_cuckoo_hash.c > @@ -1557,6 +1557,7 @@ rte_hash_rcu_qsbr_add(struct rte_hash *h, struct rte_hash_rcu_config *cfg) > if (params.size == 0) > params.size = total_entries; > params.trigger_reclaim_limit = cfg->trigger_reclaim_limit; > + params.max_reclaim_size = cfg->max_reclaim_size; > if (params.max_reclaim_size == 0) > params.max_reclaim_size = RTE_HASH_RCU_DQ_RECLAIM_MAX; > params.esize = sizeof(struct __rte_hash_rcu_dq_entry); > -- > 2.34.1 > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3] lib/hash: setting the maximum reclamation size 2024-05-14 20:52 ` Honnappa Nagarahalli @ 2024-06-18 14:09 ` David Marchand 0 siblings, 0 replies; 7+ messages in thread From: David Marchand @ 2024-06-18 14:09 UTC (permalink / raw) To: Abdullah Ömer Yamaç Cc: Honnappa Nagarahalli, dev, stable, Dharmik Jayesh Thakkar, Yipeng Wang, Sameh Gobriel, Bruce Richardson, Vladimir Medvedkin, nd On Tue, May 14, 2024 at 10:52 PM Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> wrote: > > On May 13, 2024, at 11:35 AM, Abdullah Ömer Yamaç <aomeryamac@gmail.com> wrote: > > > > Set the maximum reclamation size to user provided value > > > > Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation") > > Cc: stable@dpdk.org > > > > Signed-off-by: Abdullah Ömer Yamaç <aomeryamac@gmail.com> > Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> Applied, thanks. -- David Marchand ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-06-18 14:10 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <396BD6B3-B936-42F3-9FA9-B07578786FE5@arm.com>
2024-05-13 10:00 ` [PATCH v2] lib/hash: Set the maximum reclamation size to user provided value Abdullah Ömer Yamaç
2024-05-13 14:34 ` Honnappa Nagarahalli
2024-05-13 15:22 ` Abdullah Ömer Yamaç
2024-05-13 16:17 ` Honnappa Nagarahalli
2024-05-13 16:35 ` [PATCH v3] lib/hash: setting the maximum reclamation size Abdullah Ömer Yamaç
2024-05-14 20:52 ` Honnappa Nagarahalli
2024-06-18 14:09 ` David Marchand
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).