patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
To: Luc Pelletier <lucp.at.work@gmail.com>
Cc: dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH 19.11.9 1/2] eal: fix race in control thread creation
Date: Thu, 3 Jun 2021 06:59:51 +0200
Message-ID: <CAATJJ0+-M=VWfd2zwCWZrxyiwaL4cxiBBSXKpc+r1aqk7EjU9g@mail.gmail.com> (raw)
In-Reply-To: <20210521154907.320565-1-lucp.at.work@gmail.com>

On Fri, May 21, 2021 at 5:49 PM Luc Pelletier <lucp.at.work@gmail.com> wrote:
>
> [ upstream commit 34cc55cce6b180a6c3ee3fcf70a0fd56927f240d ]
>
> The creation of control threads uses a pthread barrier for
> synchronization. This patch fixes a race condition where the pthread
> barrier could get destroyed while one of the threads has not yet
> returned from the pthread_barrier_wait function, which could result in
> undefined behaviour.
>
> Fixes: 3a0d465d4c53 ("eal: fix use-after-free on control thread creation")
> ---

Thank you, applied to 19.11.9 (to become -rc2) now

>  lib/librte_eal/common/eal_common_thread.c | 49 +++++++++++++----------
>  1 file changed, 27 insertions(+), 22 deletions(-)
>
> diff --git a/lib/librte_eal/common/eal_common_thread.c b/lib/librte_eal/common/eal_common_thread.c
> index f9a8cf14d..a5089ae49 100644
> --- a/lib/librte_eal/common/eal_common_thread.c
> +++ b/lib/librte_eal/common/eal_common_thread.c
> @@ -147,20 +147,25 @@ struct rte_thread_ctrl_params {
>         void *(*start_routine)(void *);
>         void *arg;
>         pthread_barrier_t configured;
> +       unsigned int refcnt;
>  };
>
> +static void ctrl_params_free(struct rte_thread_ctrl_params *params)
> +{
> +       if (__atomic_sub_fetch(&params->refcnt, 1, __ATOMIC_ACQ_REL) == 0) {
> +               (void)pthread_barrier_destroy(&params->configured);
> +               free(params);
> +       }
> +}
> +
>  static void *rte_thread_init(void *arg)
>  {
> -       int ret;
>         struct rte_thread_ctrl_params *params = arg;
>         void *(*start_routine)(void *) = params->start_routine;
>         void *routine_arg = params->arg;
>
> -       ret = pthread_barrier_wait(&params->configured);
> -       if (ret == PTHREAD_BARRIER_SERIAL_THREAD) {
> -               pthread_barrier_destroy(&params->configured);
> -               free(params);
> -       }
> +       pthread_barrier_wait(&params->configured);
> +       ctrl_params_free(params);
>
>         return start_routine(routine_arg);
>  }
> @@ -180,15 +185,18 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name,
>
>         params->start_routine = start_routine;
>         params->arg = arg;
> +       params->refcnt = 2;
>
> -       pthread_barrier_init(&params->configured, NULL, 2);
> -
> -       ret = pthread_create(thread, attr, rte_thread_init, (void *)params);
> +       ret = pthread_barrier_init(&params->configured, NULL, 2);
>         if (ret != 0) {
>                 free(params);
>                 return -ret;
>         }
>
> +       ret = pthread_create(thread, attr, rte_thread_init, (void *)params);
> +       if (ret != 0)
> +               goto fail;
> +
>         if (name != NULL) {
>                 ret = rte_thread_setname(*thread, name);
>                 if (ret < 0)
> @@ -197,24 +205,21 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name,
>         }
>
>         ret = pthread_setaffinity_np(*thread, sizeof(*cpuset), cpuset);
> -       if (ret)
> -               goto fail;
> +       if (ret != 0)
> +               goto fail_cancel;
>
> -       ret = pthread_barrier_wait(&params->configured);
> -       if (ret == PTHREAD_BARRIER_SERIAL_THREAD) {
> -               pthread_barrier_destroy(&params->configured);
> -               free(params);
> -       }
> +       pthread_barrier_wait(&params->configured);
> +       ctrl_params_free(params);
>
>         return 0;
>
> -fail:
> -       if (PTHREAD_BARRIER_SERIAL_THREAD ==
> -           pthread_barrier_wait(&params->configured)) {
> -               pthread_barrier_destroy(&params->configured);
> -               free(params);
> -       }
> +fail_cancel:
>         pthread_cancel(*thread);
>         pthread_join(*thread, NULL);
> +
> +fail:
> +       (void)pthread_barrier_destroy(&params->configured);
> +       free(params);
> +
>         return -ret;
>  }
> --
> 2.25.1
>


-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd

      parent reply	other threads:[~2021-06-03  5:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-21 15:49 Luc Pelletier
2021-05-21 15:49 ` [dpdk-stable] [PATCH 19.11.9 2/2] eal: fix hang " Luc Pelletier
2021-06-03  5:00   ` Christian Ehrhardt
2021-06-03  4:59 ` Christian Ehrhardt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAATJJ0+-M=VWfd2zwCWZrxyiwaL4cxiBBSXKpc+r1aqk7EjU9g@mail.gmail.com' \
    --to=christian.ehrhardt@canonical.com \
    --cc=lucp.at.work@gmail.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git