Re: [PATCH 19.11] net/iavf: add thread for event callbacks

[Christian Ehrhardt <christian.ehrhardt@canonical.com>]

On Thu, Nov 17, 2022 at 10:05 AM Zhou, YidingX <yidingx.zhou@intel.com> wrote:
>
> > > > > -----Original Message-----
> > > > > From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> > > > > Sent: Wednesday, November 16, 2022 4:18 PM
> > > > > To: Zhou, YidingX <yidingx.zhou@intel.com>
> > > > > Cc: stable@dpdk.org
> > > > > Subject: Re: [PATCH 19.11] net/iavf: add thread for event
> > > > > callbacks
> > > > >
> > > > > On Wed, Nov 16, 2022 at 3:35 AM Yiding Zhou
> > > > > <yidingx.zhou@intel.com>
> > > > wrote:
> > > > > >
> > > > > > [upstream commit cb5c1b91f76f436724cd09f26c7432b2775b519c]
> > > > >
> > > > > Hi,
> > > > > I tried to apply this but it causes build errors:
> > > > >
> > > > > [  151s] iavf_vchnl.o: In function `iavf_dev_event_handler_fini':
> > > > > [  151s] iavf_vchnl.c:(.text+0x5d9): undefined reference to
> > `pthread_cancel'
> > > > > [  151s] iavf_vchnl.c:(.text+0x611): undefined reference to `pthread_join'
> > > > > [  151s] collect2: error: ld returned 1 exit status [  151s] make[4]:
> > > > > *** [librte_pmd_iavf.so.20.0] Error 1 [  151s] make[3]: *** [iavf]
> > > > > Error 2
> > > > >
> > > > > On all redhat, fedora, suse builds.
> > > > > Interestingly the Ubuntu builds worked fine, but only them.
> > > > >
> > > > > Please have a look and resubmit.
> > > > >
> > > > Ok, I will check this on other systems.
> > >
> > > Hi
> > > I have built DPDK successfully on the following systems.
> > >
> > > OS: Fedora release 36 (Thirty Six)
> > > meson: 0.63.1
> > > ninja: 1.10.2.git.kitware.jobserver-1
> > > gcc: gcc (GCC) 12.2.1 20220819 (Red Hat 12.2.1-1)
> > > ----------------
> > > OS: SUSE Linux Enterprise Server 15 SP4  (x86_64)
> > > meson: n0.61.5
> > > ninja: 1.10.2.git.kitware.jobserver-1
> > > gcc: gcc (SUSE Linux) 7.5.0
> > > ----------------
> > > OS: Red Hat Enterprise Linux release 9.0 (Plow)
> > > meson: 0.63.2
> > > ninja: 1.10.2.git.kitware.jobserver-1
> > > gcc: gcc (GCC) 11.2.1 20220127 (Red Hat 11.2.1-9)
> > >
> > > What is your build environment?
> >
> > Hi,
> > We use OBS (Thanks Lucas to set this up, I'm only re-using what he
> > did) to do some cross release/distro build checks based on our WIP branches on
> > github.
> > You can dive into details of logs and configuration here:
> > https://build.opensuse.org/package/show/home:cpaelzer:branches:home:bluca:
> > dpdk/dpdk-19.11
> >
> > Not all builds work every time, but between before & after applying a patch for
> > 19.11.x I at least want to see no regressions.
> > Due to that, please ignore suse_factory; suse_tumbleweed, debian_next and
> > fedora_rawhide - those have been broken before.
> > But most others start to fail when applying your patch while being ok before.
> >
> > I'm done with DPDK 19.11 for the rest of today, so to make more sense for you I
> > have applied your patch again and restarted the OBS service.
> > In a few minutes you'll see the artifacts of a build with your patch applied so
> > you can have a look.
> >
>
> Hi, I have checked the log of OBS, It seems that '- lpthread' is missing from the linker's parameter,
> but other files that also called 'pthread_join' can be correctly linked (e.g. lib/librte_eal/common/eal_common_thread.c).
> This is very confusing.
> I may not be able to solve this issue in a short time, so this patch should not be applied to 19.11.
> Thanks.

Ok, please come back once you have sorted it out.
This pattern reminds me that 19.11 still had make + meson based build systems.
The builds that keep working are meson based (Ubuntu/Debian) and the
builds failing IIRC back in the 19.11.x days used make.
If you tested your change on RH/Suse/Fedora using meson that might
explain why you could not reproduce it.

> > --
> > Christian Ehrhardt
> > Senior Staff Engineer, Ubuntu Server
> > Canonical Ltd



-- 
Christian Ehrhardt
Senior Staff Engineer, Ubuntu Server
Canonical Ltd