From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7638BA0542 for ; Thu, 17 Nov 2022 10:15:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6FA7540DDC; Thu, 17 Nov 2022 10:15:03 +0100 (CET) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id C720F40DDA for ; Thu, 17 Nov 2022 10:15:01 +0100 (CET) Received: from mail-oo1-f72.google.com (mail-oo1-f72.google.com [209.85.161.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 87CDE3F141 for ; Thu, 17 Nov 2022 09:15:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1668676501; bh=qkh4ChryecQRH1buJDMqkEnQAUoWtpRPbWjGW7+cHI0=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=vnD5NWBA7TCPog66Pp1BqLOtoSkEi9FBW/Hg8pwKIvWQtJIIwE4WmEHApg3DevMFK upm1VBbkJI/GE22xsYQyrXQBcLSLWG9fvcq1FsXQXE8h0ZZqK72UkHw/MN2sexJpFc ZNYz+MRQci8tMABm9wVTvcM537mpFKFsXN/cd+WobGRWSiUfNf7ShiWAhm1DCIurxE pKXHTERTDK+s9TD5IDdYQNtLwm3l4bzvq9w6zEkWVnb6sRsMkJy5APvJ06gC+cZFTp qbpFJ67Ia372jeCEpgSYu7v0jagr7o9vge8GE1CiYD9Ws+DdG/YvAaoCvzl/4EwP44 2FH7lbvTQbR1w== Received: by mail-oo1-f72.google.com with SMTP id k13-20020a4adfad000000b0049f0c8d234bso659471ook.11 for ; Thu, 17 Nov 2022 01:15:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qkh4ChryecQRH1buJDMqkEnQAUoWtpRPbWjGW7+cHI0=; b=e+/5dFxccRHAcLXa/W2id4BXtN8OeiJ1sDxYESvM1tnDvLpPSZAsijMM8dcjuCEZ4m 8z7qsAocN7cfH/UX5WltMKtY0hQVb+RFdJgaDARtOqVaEf8Oov/hU1TGBUSPdMIdIN2P XfSugNtk4iCSF8z6OK3DeABoRwi/rVL6iVMKJvfUxuJ+Jgev17Vn63zzP4QoBUm4SRLM ASylcZLTSXIAn7+TyQBGY6JyKpqWVzbDaqWCBC1hywhwj4V2T1NjoAZX7aK35CRbwYH6 oDT3poHu0TyUfWW/8TfzMUzPCkA2GOTjT605/xcTkYtt7dOU0mOIcGV979SbmAhoNgeT LJ4g== X-Gm-Message-State: ANoB5plD9bOla9wp7nHlV/Lp/iivT9mDHF0DUcoZ9WOY640bMNK23PzX T7uEpUcSUWcE8jzGFlhalE96iHEry09NoNSZ/PhIA4urCN+osX/kpo5CguVtk3p6Ru47HEtwF9A b/xjCI+pohZ9/DEVYMagEo0dKKrLrAaHaeiBmrzj4 X-Received: by 2002:a05:6871:4411:b0:131:caf1:947 with SMTP id nd17-20020a056871441100b00131caf10947mr3873555oab.204.1668676500480; Thu, 17 Nov 2022 01:15:00 -0800 (PST) X-Google-Smtp-Source: AA0mqf6REPaIaXW2bMRrLlMyDB+vww1d/ZCS7io9kDiNrcSa4sJkBFLiHPze8U1WQpJqQoS5X1+rRNgPxWPBf9RG/bg= X-Received: by 2002:a05:6871:4411:b0:131:caf1:947 with SMTP id nd17-20020a056871441100b00131caf10947mr3873549oab.204.1668676500277; Thu, 17 Nov 2022 01:15:00 -0800 (PST) MIME-Version: 1.0 References: <20221116023926.317352-1-yidingx.zhou@intel.com> In-Reply-To: From: Christian Ehrhardt Date: Thu, 17 Nov 2022 10:14:34 +0100 Message-ID: Subject: Re: [PATCH 19.11] net/iavf: add thread for event callbacks To: "Zhou, YidingX" Cc: "stable@dpdk.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Thu, Nov 17, 2022 at 10:05 AM Zhou, YidingX wrote: > > > > > > -----Original Message----- > > > > > From: Christian Ehrhardt > > > > > Sent: Wednesday, November 16, 2022 4:18 PM > > > > > To: Zhou, YidingX > > > > > Cc: stable@dpdk.org > > > > > Subject: Re: [PATCH 19.11] net/iavf: add thread for event > > > > > callbacks > > > > > > > > > > On Wed, Nov 16, 2022 at 3:35 AM Yiding Zhou > > > > > > > > > wrote: > > > > > > > > > > > > [upstream commit cb5c1b91f76f436724cd09f26c7432b2775b519c] > > > > > > > > > > Hi, > > > > > I tried to apply this but it causes build errors: > > > > > > > > > > [ 151s] iavf_vchnl.o: In function `iavf_dev_event_handler_fini': > > > > > [ 151s] iavf_vchnl.c:(.text+0x5d9): undefined reference to > > `pthread_cancel' > > > > > [ 151s] iavf_vchnl.c:(.text+0x611): undefined reference to `pthread_join' > > > > > [ 151s] collect2: error: ld returned 1 exit status [ 151s] make[4]: > > > > > *** [librte_pmd_iavf.so.20.0] Error 1 [ 151s] make[3]: *** [iavf] > > > > > Error 2 > > > > > > > > > > On all redhat, fedora, suse builds. > > > > > Interestingly the Ubuntu builds worked fine, but only them. > > > > > > > > > > Please have a look and resubmit. > > > > > > > > > Ok, I will check this on other systems. > > > > > > Hi > > > I have built DPDK successfully on the following systems. > > > > > > OS: Fedora release 36 (Thirty Six) > > > meson: 0.63.1 > > > ninja: 1.10.2.git.kitware.jobserver-1 > > > gcc: gcc (GCC) 12.2.1 20220819 (Red Hat 12.2.1-1) > > > ---------------- > > > OS: SUSE Linux Enterprise Server 15 SP4 (x86_64) > > > meson: n0.61.5 > > > ninja: 1.10.2.git.kitware.jobserver-1 > > > gcc: gcc (SUSE Linux) 7.5.0 > > > ---------------- > > > OS: Red Hat Enterprise Linux release 9.0 (Plow) > > > meson: 0.63.2 > > > ninja: 1.10.2.git.kitware.jobserver-1 > > > gcc: gcc (GCC) 11.2.1 20220127 (Red Hat 11.2.1-9) > > > > > > What is your build environment? > > > > Hi, > > We use OBS (Thanks Lucas to set this up, I'm only re-using what he > > did) to do some cross release/distro build checks based on our WIP branches on > > github. > > You can dive into details of logs and configuration here: > > https://build.opensuse.org/package/show/home:cpaelzer:branches:home:bluca: > > dpdk/dpdk-19.11 > > > > Not all builds work every time, but between before & after applying a patch for > > 19.11.x I at least want to see no regressions. > > Due to that, please ignore suse_factory; suse_tumbleweed, debian_next and > > fedora_rawhide - those have been broken before. > > But most others start to fail when applying your patch while being ok before. > > > > I'm done with DPDK 19.11 for the rest of today, so to make more sense for you I > > have applied your patch again and restarted the OBS service. > > In a few minutes you'll see the artifacts of a build with your patch applied so > > you can have a look. > > > > Hi, I have checked the log of OBS, It seems that '- lpthread' is missing from the linker's parameter, > but other files that also called 'pthread_join' can be correctly linked (e.g. lib/librte_eal/common/eal_common_thread.c). > This is very confusing. > I may not be able to solve this issue in a short time, so this patch should not be applied to 19.11. > Thanks. Ok, please come back once you have sorted it out. This pattern reminds me that 19.11 still had make + meson based build systems. The builds that keep working are meson based (Ubuntu/Debian) and the builds failing IIRC back in the 19.11.x days used make. If you tested your change on RH/Suse/Fedora using meson that might explain why you could not reproduce it. > > -- > > Christian Ehrhardt > > Senior Staff Engineer, Ubuntu Server > > Canonical Ltd -- Christian Ehrhardt Senior Staff Engineer, Ubuntu Server Canonical Ltd