From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE9B5A0524 for ; Tue, 1 Jun 2021 10:25:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8023E40040; Tue, 1 Jun 2021 10:25:58 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id A0E4A40040 for ; Tue, 1 Jun 2021 10:25:56 +0200 (CEST) Received: from mail-qk1-f197.google.com ([209.85.222.197]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lnzim-0002z2-3q for stable@dpdk.org; Tue, 01 Jun 2021 08:25:56 +0000 Received: by mail-qk1-f197.google.com with SMTP id s20-20020ae9f7140000b02903a98afb6313so1240923qkg.21 for ; Tue, 01 Jun 2021 01:25:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc :content-transfer-encoding; bh=wkePzuVS6yOqO89mPBKspipcOwQBeHi+4cz8GI6OV6o=; b=iAdbt/cC8DuS9es9+FKbCpmiR80zYDShjHqtt65n/E7oFeGDsRuMxmO7nkmZHh7lIz +GDzR/oJwh7PpToq6wnVjNasJtKVev1K4l68xyeLCtTxB+i6UyP1Xt6Xt0iXRbFl5UHu C/b/lJxxpssF0NWKTL6Amrf0m11ks81qu63UJKmYhpP8rqKHVAq+w5nzVTTVtQPbS2fB iEwYfV1bEcrlaRiRg/Eqb5pTztvmg8pd9tot4+epbeHwSMfAX0RMUKnDroBqD+un3fBx pyfHaCNuRkTM6Lo5t6dgYnJl3baataqMKmcytjkbYWtBebYmwdw041TO+yGz3wr4yltt /0QQ== X-Gm-Message-State: AOAM533JGYdVVx1goAVLAafMCoD/CTULYfCSpY/JYWShjEqWbjJEwiQf 6zl4ufoUe+2aQWffRR7LJV0jfecYAX9WORWR1S3RDo4644+EJNuCpA47yea6mJKD4J07Mwol7F8 /uNkgwr7/25RSQquwWtVDxENBenjW9SIws27oQf+L X-Received: by 2002:ae9:c016:: with SMTP id u22mr20742995qkk.114.1622535955284; Tue, 01 Jun 2021 01:25:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxkTvZl0faJceyhpT5n9IGAtwLcM0mDseahAGubk96eDvXIyA3mAgpRkdkvvvbrymvs8oTJjGTZiT13MRjJEjk= X-Received: by 2002:ae9:c016:: with SMTP id u22mr20742984qkk.114.1622535955081; Tue, 01 Jun 2021 01:25:55 -0700 (PDT) MIME-Version: 1.0 From: Christian Ehrhardt Date: Tue, 1 Jun 2021 10:25:29 +0200 Message-ID: To: Chengwen Feng , "Min Hu (Connor)" , Yisen Zhuang , Lijun Ou Cc: dpdk stable Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE not present in 19.11.x series X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, this was targeted at the stable releases: commit 1bdcca8006e4c690d017531f7fc6c31b19ad8d1d Author: Chengwen Feng Date: Sat Apr 17 17:54:58 2021 +0800 net/hns3: fix flow director lock But it introduced ../drivers/net/hns3/hns3_flow.c: In function =E2=80=98hns3_flow_init=E2=80= =99: ../drivers/net/hns3/hns3_flow.c:1168:27: error: =E2=80=98RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE=E2=80=99 undeclared (first use in= this function) 1168 | dev->data->dev_flags |=3D RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/hns3/hns3_flow.c:1168:27: note: each undeclared identifier is reported only once for each function it appears in The reason is that this was introduced in 20.11 commit 80d1a9aff7f6088ea97d78e36de3f9edae018f1c Author: Suanming Mou Date: Thu Oct 15 09:07:47 2020 +0800 ethdev: make flow API thread safe I'm unsure about the potential implications to e.g. just strip declaring RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE from your patch so if you'd want to have that one applied ti 19.11.x I'd ask you to have a more detailed look and consider providing a backport or letting me know that this patch isn't needed for 19.11.x Thanks in advance, Christian --=20 Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd