patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH 19.11] app/testpmd: fix NVGRE encap configuration
@ 2021-06-04 13:37 Jiawei Wang
  2021-06-08  4:51 ` Christian Ehrhardt
  0 siblings, 1 reply; 2+ messages in thread
From: Jiawei Wang @ 2021-06-04 13:37 UTC (permalink / raw)
  To: orika, christian.ehrhardt, viacheslavo, rasland; +Cc: stable

[ upstream commit 9b0da816bdec98c0d6c5d17ccdd337bdbafc3f75 ]

For NVGRE protocol, the default value of 'c_k_s_rsvd0_ver'
must be 0x2000, and protocol type must be 0x6558 in the NVGRE
header.

This patch updates these two configurations while parsing the nvgre
encap.

Fixes: dcd962fc6b4e ("app/testpmd: add NVGRE encap/decap")

Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>
---
 app/test-pmd/cmdline_flow.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index da3533c..0b76f7e 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -4250,7 +4250,11 @@ static int comp_set_raw_index(struct context *, const struct token *,
 		       .src_addr = nvgre_encap_conf.ipv4_src,
 		       .dst_addr = nvgre_encap_conf.ipv4_dst,
 		},
-		.item_nvgre.flow_id = 0,
+		.item_nvgre = {
+			.c_k_s_rsvd0_ver = RTE_BE16(0x2000),
+			.protocol = RTE_BE16(RTE_ETHER_TYPE_TEB),
+			.flow_id = 0,
+		},
 	};
 	memcpy(action_nvgre_encap_data->item_eth.dst.addr_bytes,
 	       nvgre_encap_conf.eth_dst, RTE_ETHER_ADDR_LEN);
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-stable] [PATCH 19.11] app/testpmd: fix NVGRE encap configuration
  2021-06-04 13:37 [dpdk-stable] [PATCH 19.11] app/testpmd: fix NVGRE encap configuration Jiawei Wang
@ 2021-06-08  4:51 ` Christian Ehrhardt
  0 siblings, 0 replies; 2+ messages in thread
From: Christian Ehrhardt @ 2021-06-08  4:51 UTC (permalink / raw)
  To: Jiawei Wang; +Cc: Ori Kam, Viacheslav Ovsiienko, Raslan Darawsheh, dpdk stable

On Fri, Jun 4, 2021 at 3:37 PM Jiawei Wang <jiaweiw@nvidia.com> wrote:
>
> [ upstream commit 9b0da816bdec98c0d6c5d17ccdd337bdbafc3f75 ]
>
> For NVGRE protocol, the default value of 'c_k_s_rsvd0_ver'
> must be 0x2000, and protocol type must be 0x6558 in the NVGRE
> header.
>
> This patch updates these two configurations while parsing the nvgre
> encap.

Thanks, while it is unsure if it will be 19.11.9 or later 19.11.10 it
is applied now.

> Fixes: dcd962fc6b4e ("app/testpmd: add NVGRE encap/decap")
>
> Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>
> ---
>  app/test-pmd/cmdline_flow.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index da3533c..0b76f7e 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -4250,7 +4250,11 @@ static int comp_set_raw_index(struct context *, const struct token *,
>                        .src_addr = nvgre_encap_conf.ipv4_src,
>                        .dst_addr = nvgre_encap_conf.ipv4_dst,
>                 },
> -               .item_nvgre.flow_id = 0,
> +               .item_nvgre = {
> +                       .c_k_s_rsvd0_ver = RTE_BE16(0x2000),
> +                       .protocol = RTE_BE16(RTE_ETHER_TYPE_TEB),
> +                       .flow_id = 0,
> +               },
>         };
>         memcpy(action_nvgre_encap_data->item_eth.dst.addr_bytes,
>                nvgre_encap_conf.eth_dst, RTE_ETHER_ADDR_LEN);
> --
> 1.8.3.1
>


-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-08  4:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-04 13:37 [dpdk-stable] [PATCH 19.11] app/testpmd: fix NVGRE encap configuration Jiawei Wang
2021-06-08  4:51 ` Christian Ehrhardt

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git