From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42EDFA0548 for ; Mon, 14 Jun 2021 07:23:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 16FE84003E; Mon, 14 Jun 2021 07:23:58 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id 140294003E for ; Mon, 14 Jun 2021 07:23:57 +0200 (CEST) Received: from mail-qv1-f72.google.com ([209.85.219.72]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lsf4m-0000XL-P8 for stable@dpdk.org; Mon, 14 Jun 2021 05:23:56 +0000 Received: by mail-qv1-f72.google.com with SMTP id jm5-20020ad45ec50000b0290219dc9a1ab8so16313190qvb.21 for ; Sun, 13 Jun 2021 22:23:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7iKVzA4wc73zH9ZlPBbeAPbvIbDY1/k0BoDviSY7m50=; b=dBEJlSqjRGGiWVKACe51z4AMaasvmVlYH7fe126wavEqvnFiQGuEGWAq5OJdOPPutW qD6g49XQ8xCsYcWTILWHGdf3oMhSnhMRIJq/hNm7YehelJVnD3sqi7VxPySH4X0jRfVh p358rzcq1jY6hnnoA2w2nFzUjVJBp8d03f/fMOshG/y48oOfHSDtyBehLfXA8XdIGc7H i5Z7H+snjJtILG5pum9gsAE4geFNfO1so0jMW6GTaksmdb9NxuteVqyO8CLlC9tXy4ic 3rkXrG5hvAKhY0N02dW+cgYXa19v77EycgjkDlo2wFvOcyJHDQUg9oabcF28Ln3JtDGY tuXQ== X-Gm-Message-State: AOAM532W28XM7z6a4zEkK8yfq5WXN2n6FjmCxs9RHCWhZ6SWtBnnkTww AS1lXu7gv+PIQUY6aNK5aJvuNu3cufP0uHB0TFOM17yZ95eKez1mWpXdcUzIUZSj1DDdtQ2X6tS /no+mWicuK2S5XTDmkdwAB6hLmY7sU0el0RcUWjIC X-Received: by 2002:a05:622a:1212:: with SMTP id y18mr15002958qtx.321.1623648235984; Sun, 13 Jun 2021 22:23:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzsZKZy9jcivZbVQgT5fJ2cZGPa7tVfcgvruByuk2tnMjZLhWRbYSqm5zqrXZdBgW86NJIzUwJ28nTdfUj2BfY= X-Received: by 2002:a05:622a:1212:: with SMTP id y18mr15002947qtx.321.1623648235811; Sun, 13 Jun 2021 22:23:55 -0700 (PDT) MIME-Version: 1.0 References: <20210613213602.23843-1-dmitry.kozliuk@gmail.com> In-Reply-To: <20210613213602.23843-1-dmitry.kozliuk@gmail.com> From: Christian Ehrhardt Date: Mon, 14 Jun 2021 07:23:30 +0200 Message-ID: To: Dmitry Kozlyuk Cc: stable@dpdk.org, Tal Shnaiderman , Yu Jiang Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [PATCH 19.11] eal/windows: add cleanup function stub X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Sun, Jun 13, 2021 at 11:36 PM Dmitry Kozlyuk wrote: > > Upstream commit 10aa375704c1 ("examples: add eal cleanup to examples") > requires librte_eal to export rte_eal_clearnup(). On Windows, it was > exported by commit c91717eb75c8 ("eal/windows: support exit and panic"), > which is based on refactoring that is not backported. > > Add a stub to fix the build. > In 19.11 LTS this function has nothing to clean up. Thank you, applied to 19.11.x (will be in the coming 19.11.9-rc3) > Bugzilla ID: 732 > > Reported-by: Yu Jiang > Signed-off-by: Dmitry Kozlyuk > --- > lib/librte_eal/rte_eal_exports.def | 1 + > lib/librte_eal/windows/eal/eal.c | 6 ++++++ > 2 files changed, 7 insertions(+) > > diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def > index c1bdee1c40..61b4082a54 100644 > --- a/lib/librte_eal/rte_eal_exports.def > +++ b/lib/librte_eal/rte_eal_exports.def > @@ -1,5 +1,6 @@ > EXPORTS > __rte_panic > + rte_eal_cleanup > rte_eal_init > rte_eal_mp_remote_launch > rte_eal_mp_wait_lcore > diff --git a/lib/librte_eal/windows/eal/eal.c b/lib/librte_eal/windows/eal/eal.c > index ce460481f8..7cfa8451a3 100644 > --- a/lib/librte_eal/windows/eal/eal.c > +++ b/lib/librte_eal/windows/eal/eal.c > @@ -82,3 +82,9 @@ rte_eal_init(int argc __rte_unused, char **argv __rte_unused) > rte_eal_mp_wait_lcore(); > return 0; > } > + > +int > +rte_eal_cleanup(void) > +{ > + return 0; > +} > -- > 2.29.3 > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd