Re: [dpdk-stable] [scripts 2/2] 4-final-review: silence git/pushd/popd commands

[Christian Ehrhardt <christian.ehrhardt@canonical.com>]

On Mon, Feb 22, 2021 at 4:01 PM <luca.boccassi@gmail.com> wrote:
>
> From: Luca Boccassi <luca.boccassi@microsoft.com>
>
> Allow to redirect the output to a file for git-send-email

Today I was just about to add this as well - thanks!
Acked-by: Christian Ehrhardt <christian.erhrhardt@canonical.com>

> ---
>  4-final-review | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/4-final-review b/4-final-review
> index 0444b1e..4aa4a75 100755
> --- a/4-final-review
> +++ b/4-final-review
> @@ -54,15 +54,15 @@ do_commit()
>  {
>         # $GIT doesn't work, so cd
>
> -       pushd $DPDK_DIR
> -       git commit -a -s -m "version: ${stable_release_rc}"
> +       pushd $DPDK_DIR &>/dev/null
> +       git commit -a -s -m "version: ${stable_release_rc}" &>/dev/null
>         if [ "x$SIGN_TAG" == "xyes" ]; then
>                 TAG_ARG="-s"
>         else
>                 TAG_ARG=""
>         fi
>         git tag ${TAG_ARG} v${stable_release_rc} -a -m "dpdk-${stable_release_rc}"
> -       popd
> +       popd &>/dev/null
>  }
>
>  get_shortlog()
> --
> 2.29.2
>


-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd