patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
To: Luca Boccassi <luca.boccassi@gmail.com>
Cc: dpdk stable <stable@dpdk.org>,
	Luca Boccassi <luca.boccassi@microsoft.com>
Subject: Re: [dpdk-stable] [scripts 2/2] 4-final-review: silence git/pushd/popd commands
Date: Mon, 22 Feb 2021 16:13:10 +0100
Message-ID: <CAATJJ0J3BQRB71MOGX2XwQRhQr6fvH3rnOseiR5e2vm16368SQ@mail.gmail.com> (raw)
In-Reply-To: <20210222150115.278569-2-luca.boccassi@gmail.com>

On Mon, Feb 22, 2021 at 4:01 PM <luca.boccassi@gmail.com> wrote:
>
> From: Luca Boccassi <luca.boccassi@microsoft.com>
>
> Allow to redirect the output to a file for git-send-email

Today I was just about to add this as well - thanks!
Acked-by: Christian Ehrhardt <christian.erhrhardt@canonical.com>

> ---
>  4-final-review | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/4-final-review b/4-final-review
> index 0444b1e..4aa4a75 100755
> --- a/4-final-review
> +++ b/4-final-review
> @@ -54,15 +54,15 @@ do_commit()
>  {
>         # $GIT doesn't work, so cd
>
> -       pushd $DPDK_DIR
> -       git commit -a -s -m "version: ${stable_release_rc}"
> +       pushd $DPDK_DIR &>/dev/null
> +       git commit -a -s -m "version: ${stable_release_rc}" &>/dev/null
>         if [ "x$SIGN_TAG" == "xyes" ]; then
>                 TAG_ARG="-s"
>         else
>                 TAG_ARG=""
>         fi
>         git tag ${TAG_ARG} v${stable_release_rc} -a -m "dpdk-${stable_release_rc}"
> -       popd
> +       popd &>/dev/null
>  }
>
>  get_shortlog()
> --
> 2.29.2
>


-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd

  reply	other threads:[~2021-02-22 15:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-22 15:01 [dpdk-stable] [scripts 1/2] 4-final-review: add support for VERSION file luca.boccassi
2021-02-22 15:01 ` [dpdk-stable] [scripts 2/2] 4-final-review: silence git/pushd/popd commands luca.boccassi
2021-02-22 15:13   ` Christian Ehrhardt [this message]
2021-02-22 15:12 ` [dpdk-stable] [scripts 1/2] 4-final-review: add support for VERSION file Christian Ehrhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAATJJ0J3BQRB71MOGX2XwQRhQr6fvH3rnOseiR5e2vm16368SQ@mail.gmail.com \
    --to=christian.ehrhardt@canonical.com \
    --cc=luca.boccassi@gmail.com \
    --cc=luca.boccassi@microsoft.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git