From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 10D3FA00C2 for ; Thu, 17 Nov 2022 08:26:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E2FF542C4D; Thu, 17 Nov 2022 08:26:14 +0100 (CET) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id 347BC40DDA for ; Thu, 17 Nov 2022 08:26:13 +0100 (CET) Received: from mail-oo1-f69.google.com (mail-oo1-f69.google.com [209.85.161.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id E58C23F158 for ; Thu, 17 Nov 2022 07:26:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1668669972; bh=G2wXlaIrRpcmvf1gRsIq6r+yBpYSuTKpxu469VgcB2Y=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=eS6RTZw080Wg8vyPQgPGafNCS+Ufyp0oNUGQ3jB5+iC0v5SwG8FAle7NezQyxma8k eLq6KJqGRNt82+nDj8ICFkb/d8n1xy0qG572fPXUY1xo86IwnFemOxV3WfS7bCzDK1 vl5HDziitEck0/zQ+vebGnGiqYWU2xcuhZXpDCjkNivfKh9peVfofOPZGKG4w5HGFE 2rI7V45HRD4pLRz/Kv3JmNUB37hIY27j9uFoLutwdmjtd1GE7XnLG6SAO5v4lv4mvi xq/JzzldiBYjmoGz2pyjpCgf4HPS4+zKkCAyOccbVKL/ti/C9zQBp5/a9o0TwYapMV /m5Q0Mjra/CBQ== Received: by mail-oo1-f69.google.com with SMTP id v10-20020a4a860a000000b00480b3e2b5afso548911ooh.12 for ; Wed, 16 Nov 2022 23:26:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G2wXlaIrRpcmvf1gRsIq6r+yBpYSuTKpxu469VgcB2Y=; b=3vBUE0EgB2O1GdEX/171hR6ezZWw8OxSdG8p2GBtWERVHrAahwLZAc+jiDTyd6Ncoj wFHo0p/2RKQw5Oiqfj68BdVEE23NjqpK0KSEPQ2g3r7oPPH7842ywXxi9IsrDsKuRR7i jI132VXiEzYG/bGQqX+90kWTvGjQOSvJ5WBHE8SjEsZNjtBRtv3tW6+SM1EqzPC1LcDC rGhUUiImt/xnpyMQjDknh4wUW8HgJQRl4sreH0YpT8fxn3blL2+C0kgFiurGZ7RmWLFu qjSQnC/0eb8k/7KGyGeigb5rE7p4tRr8XCLS9rYPPcfYiq8HRpZpMRJTq9HgJ5qiJ/1h Grwg== X-Gm-Message-State: ANoB5pnahlivNuEhhFsqRgmBxPfXlAwlZuB1vPFJE7qmu+X4dzZQhQf6 Jxypz2qKOhkWm06vot1wPwe8BSH7VEKbtmFoc0vrx/WYBB7V4MBAFKNntRfAyvylIoBA2KuqiYR k/ovAL24CNLnr06T4+qTFFf1XXnyJpinzbq0kNMfz X-Received: by 2002:a05:6871:4411:b0:131:caf1:947 with SMTP id nd17-20020a056871441100b00131caf10947mr3726138oab.204.1668669971827; Wed, 16 Nov 2022 23:26:11 -0800 (PST) X-Google-Smtp-Source: AA0mqf4fKMKYMm13SmVDWmFkMkdlbatGE9cAa/iiiyt6BC20eucEdrLsjuR++w8nwNkPoWpHSP5PFF0/femyVhKkFi4= X-Received: by 2002:a05:6871:4411:b0:131:caf1:947 with SMTP id nd17-20020a056871441100b00131caf10947mr3726090oab.204.1668669971616; Wed, 16 Nov 2022 23:26:11 -0800 (PST) MIME-Version: 1.0 References: <20221111114814.1553136-1-christian.ehrhardt@canonical.com> <98CBD80474FA8B44BF855DF32C47DC35D874C6@smartserver.smartshare.dk> In-Reply-To: From: Christian Ehrhardt Date: Thu, 17 Nov 2022 08:25:45 +0100 Message-ID: Subject: Re: please help backporting some patches to stable release 19.11.14 To: =?UTF-8?Q?Morten_Br=C3=B8rup?= Cc: dpdk stable , Konstantin Ananyev , Konstantin Ananyev , Kumara Parameshwaran , Lijun Ou , Lior Margalit , Long Li , Long Wu , Mah Yock Gen , Mao YingMing , Matan Azrad , Matan Azrad , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , Maxime Coquelin , "Min Hu (Connor)" , Nikhil Rao , Niklas Soderlund , Nithin Dabilpuram , Olivier Matz , Ori Kam , Pablo de Lara , Paul M Stillwell Jr , Pavan Nikhilesh , Peng Zhang , Qiming Yang , Qi Zhang , Radu Nicolau , Raja Zidane , Remy Horton , Rolf Neugebauer , Shahaf Shuler , Shally Verma , Shijith Thotton , Shiqi Liu <835703180@qq.com>, Simei Su , Somnath Kotur , Suanming Mou , Sunila Sahu , Taripin Samuel , Umesh Kartha , Usman Tanveer , Viacheslav Ovsiienko , Vladimir Medvedkin , "Wei Hu (Xavier)" , Wei Ling , Wenwu Ma , Wenzhuo Lu , Yiding Zhou , Yisen Zhuang , Yongseok Koh , Yuan Wang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Thu, Nov 17, 2022 at 7:27 AM Christian Ehrhardt wrote: > > On Wed, Nov 16, 2022 at 11:45 AM Morten Br=C3=B8rup wrote: > > > > > From: christian.ehrhardt@canonical.com > > > Sent: Friday, 11 November 2022 12.48 > > > > [...] > > > > > 459531c958 Morten Br=C3=B8rup mempool: fix cache flushing algorit= hm > > > a2833ecc5e Morten Br=C3=B8rup mempool: fix get objects from mempo= ol with > > > cache > > > > These two patches fixes some performance issues for certain use cases. = The affected use cases work without the patches, but don't get the improved= performance. > > > > However, these patches change the inner workings of the mempool cache. > > > > And since some PMDs bypass the mempool API and interact directly with t= he mempool caches, there is a risk that applications do the same. > > > > Although these patches are relevant for the performance of the affected= use cases, I fear that backporting them would introduce an unwanted risk o= f breaking PMDs and/or applications (generally, not just for the affected u= se cases). > > Thanks for your thoughts, I completely agree. > Let us now backport them and keep -stable stable. Arrr, thanks Morten for making me aware! Some typos do not matter, others completely break what you wanted to say ..= . Let us NOT backport them is what I meant to say :-) > > For the common good, I prefer not backporting them. Anyone feel free to= speak up if you disagree. > > > > We have a policy of not backporting performance improvements, and fixin= g a lack of performance could be interpreted as falling under this policy. > > > > > -- > Christian Ehrhardt > Senior Staff Engineer, Ubuntu Server > Canonical Ltd --=20 Christian Ehrhardt Senior Staff Engineer, Ubuntu Server Canonical Ltd