From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC1DDA034F for ; Wed, 11 Aug 2021 08:39:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B9E3D40040; Wed, 11 Aug 2021 08:39:14 +0200 (CEST) Received: from smtp-relay-canonical-1.canonical.com (smtp-relay-canonical-1.canonical.com [185.125.188.121]) by mails.dpdk.org (Postfix) with ESMTP id 5AEC640040 for ; Wed, 11 Aug 2021 08:39:13 +0200 (CEST) Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPS id 307603F357 for ; Wed, 11 Aug 2021 06:39:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1628663953; bh=zBFk1GZQqLRdmtI+IM891lY9pZpIogL3L+9XeNPkb1M=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=YSsDfF2tbhPoz3/3qk3O17xhLA4upKQ3nWBASoQsekwEaalumR0olWLb3tQcFXBtK 4+AwUfFPDiicHEOg0qpKU8C/tSILD1i8z7jTSHDjQ81AT6WBbcAxkYZ8hAvogb+ukz w4TJncXsjQ5OGHXsBySusVuorw9CDHf09Fpp14zyigZjthAHzBkCHjKSGa8/FhVerC NP4YMKj+qi04Ho2K7U9NmqXaBlwoin5jdXTYhbOcAwEZXVBZmWZykAX7ZHBFlZ1jPy srjk9qLgFg7JNKK3noZ0vM6gbSO4smgfWPJI+VEs+6OjqVcRPvdiCfqgvxJtqCjji8 u+6SKstEHbptQ== Received: by mail-qk1-f197.google.com with SMTP id 18-20020a05620a0792b02903b8e915ccceso732124qka.18 for ; Tue, 10 Aug 2021 23:39:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zBFk1GZQqLRdmtI+IM891lY9pZpIogL3L+9XeNPkb1M=; b=I9/n7nZyB0ZS+3mIhDupWPX5MSdYpnR5ilEI+lgIXEx3fpLb2ye2nDG+Y1Nu0mlz28 h0w83VzrJMtWywYOESHZJH8g9U9z5Olt0d6pTMLlSVDQIywaJ9nfqMDq8sgZD9qYoN7/ wss0uBllNGmpZJbvoirJanHmFakjTEs2ZfoiAoRa1SW22h8ddSBbWi+2sDs0zdZeFowb 2I3ibjsrqk6/sNPWCJkECHzQ+60UCMi2MxR6Se3/SUjRasS4oo9HfOLZ2Xv0KsW15Jhk CKlGYuuc6yR6XYGps0T8TsrZ5KQmIialD3dPDObK5t0WBLB7qNxqvCGUfEeTanEjaS3t 4DBQ== X-Gm-Message-State: AOAM533jGcT/BmkEvB3E6ndJ8H9PDrHClxh7RiIqlQPv4/UFqhpzLuNT y1vH5bwUV6BD2l1pDwhnXKw0yyrW5f684vWFYyV4vsAJha4DZtd3AiiDPBBVd5cYI6iwS4uFC09 F/gy4ZqHtbGcvtlzQbguv+yQPgn/UFC1cZKeBfeuq X-Received: by 2002:a0c:aac2:: with SMTP id g2mr22408939qvb.44.1628663952164; Tue, 10 Aug 2021 23:39:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxtf2Nb9Ww7RcL9sw3/NBALYSYZelJys/Y0GP1fNk/DEMCGKD1OJQW0IG4/ZdWqjiZL/8QoTccnmIztAbFHWFk= X-Received: by 2002:a0c:aac2:: with SMTP id g2mr22408925qvb.44.1628663951973; Tue, 10 Aug 2021 23:39:11 -0700 (PDT) MIME-Version: 1.0 References: <20210810142442.727267-1-christian.ehrhardt@canonical.com> In-Reply-To: From: Christian Ehrhardt Date: Wed, 11 Aug 2021 08:38:46 +0200 Message-ID: To: Luca Boccassi Cc: dpdk stable , Thomas Monjalon , Xueming Li Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [PATCH 1/2] 3-request-backport: use history from stable branch X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Tue, Aug 10, 2021 at 6:57 PM Luca Boccassi wrote: > > On Tue, 2021-08-10 at 16:24 +0200, christian.ehrhardt@canonical.com > wrote: > > From: Christian Ehrhardt > > > > To select the proper maintainers - as of today - we recommend to check > > out the main branch in $STABLE_DIR before calling 3-request-backport. > > But due to that the range $_parent_commit_id..HEAD selects the wrong HEAD > > and thereby does not find any applied patch. > > > > Instead we should use $RTE_VER_MAJOR that will correctly select the > > branch name and therefore make 3-request-backport work in this case. > > > > Signed-off-by: Christian Ehrhardt > > --- > > 3-request-backport | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/3-request-backport b/3-request-backport > > index a1725e5..67234d2 100755 > > --- a/3-request-backport > > +++ b/3-request-backport > > @@ -11,7 +11,7 @@ then > > pushd $STABLE_DIR &>/dev/null > > list=$(cat $_scripts_dir/$stable_release/tmp_import/list | tr '\n' ' ') > > _parent_commit_id=$(cat $_scripts_dir/$stable_release/parent_commit_id) > > - _applied=$(git log --oneline $_parent_commit_id..HEAD | cut -d\ -f2-) > > + _applied=$(git log --oneline $_parent_commit_id..$RTE_VER_MAJOR | cut -d\ -f2-) > > for _file in $list > > do > > _sub=$(grep Subject $_file | cut -d\ -f3-) > > Acked-by: Luca Boccassi Thanks, applied now > -- > Kind regards, > Luca Boccassi -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd