From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B205A2EEB for ; Thu, 12 Sep 2019 15:44:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ED7A31E90B; Thu, 12 Sep 2019 15:44:28 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by dpdk.org (Postfix) with ESMTP id 40D581E90B for ; Thu, 12 Sep 2019 15:44:27 +0200 (CEST) Received: from mail-vs1-f69.google.com ([209.85.217.69]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1i8POc-0005W8-O9 for stable@dpdk.org; Thu, 12 Sep 2019 13:44:26 +0000 Received: by mail-vs1-f69.google.com with SMTP id x21so3579955vsx.19 for ; Thu, 12 Sep 2019 06:44:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=q29jrxXkqeRnufLHIPNi5bV1vUW4bRUz17KCW0n9yx4=; b=WS74zIseRhiglQVKM3ydyoovL764bGRVod26MKBTbd2bUP4UaHqCpTomVM+SQMKNm8 rchj8vB4g8FAiQJxdY/8dmGvjSjepNCk+WskNd3x6JdrQ33QqIFn2ZHSyVmdYPL4cpTL XSZ6H6FUsy9T2owP9Sxqy2UHepzrh4dx9q3csHlUmrHdiRiiVcma9b2fr2RGAklXK22U yZB1nwJr6q2uqHW4HwGod/c0BB+IBoErjnJLZKZYaYLPqBkMHX81ZQ+QYgn/JxRhd4I1 1VcWWPqqfrWgM2oY7BrnYkglQj8LV7vukxv2gb9MHIMuWd84qdDtfhdjh4QCPygc7l+j dw3Q== X-Gm-Message-State: APjAAAX9ZdDyjWZc1lJENLeyuaCBCzD+TomJSi8nakbFzF4XYtkqvt+t TAYotrKBFIXltwqV9lckDPyZYUcNkTp3gjrcMGkLws8Iz+ecGfRE9XDdpD3uYKBe0hT6i9+ssgf lJwD7QYhkZSl6Kjr7JtbFAw/Hr+FtD5D+Xmgl1pSA X-Received: by 2002:ab0:136d:: with SMTP id h42mr981223uae.123.1568295865840; Thu, 12 Sep 2019 06:44:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqxP8FjasvJ5xpV1geADmhhS0jEreDAtsYFzeTxdl57nOX2KRHrDBsSamb3YY9qQHWYqIw+5f2PVVO1Cx07DQys= X-Received: by 2002:ab0:136d:: with SMTP id h42mr981206uae.123.1568295865573; Thu, 12 Sep 2019 06:44:25 -0700 (PDT) MIME-Version: 1.0 References: <20190829153003.7974-1-christian.ehrhardt@canonical.com> <20190829153431.GA624@bricha3-MOBL.ger.corp.intel.com> <20190904091805.GA1145@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: From: Christian Ehrhardt Date: Thu, 12 Sep 2019 15:43:58 +0200 Message-ID: To: Bruce Richardson , stable@dpdk.org Cc: Luca Boccassi , dev , Kevin Laatz , Thomas Monjalon Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] build: avoid --as-needed as it causes overlinking X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Tue, Sep 10, 2019 at 8:48 AM Christian Ehrhardt wrote: > > On Wed, Sep 4, 2019 at 11:18 AM Bruce Richardson > wrote: > > > > On Wed, Sep 04, 2019 at 11:13:34AM +0200, Christian Ehrhardt wrote: > > > On Mon, Sep 2, 2019 at 9:09 AM Christian Ehrhardt > > > wrote: > > > > > > > > On Thu, Aug 29, 2019 at 6:02 PM Luca Boccassi wrote: > > > > > > > > > > On Thu, 2019-08-29 at 16:34 +0100, Bruce Richardson wrote: > > > > > > On Thu, Aug 29, 2019 at 05:30:03PM +0200, Christian Ehrhardt wrote: > > > > > > > A while ago telemetry was added in 57ae0ec6 and it also added as- > > > > > > > needed > > > > > > > to config/meson.build. This seems no more needed these days as due > > > > > > > to other > > > > > > > build changes the ordering in buildlogs is: > > > > > > > [...] -lrte_telemetry [...] -Wl,--no-as-needed [...] > > > > > > > Which means telemetry no more benefits from --no-as-needed anyway. > > > > > > > > > > > > > > Overlinking problems get triggered by the meson generated pkgconfig > > > > > > > which > > > > > > > will have: > > > > > > > [...] -Wl,--no-as-needed > > > > > > > This will overlink and in addition anything that follows > > > > > > > as it also doesn't wrap back to --as-needed. So if a projects > > > > > > > includes > > > > > > > dpdk libs + it will also consider with --no-as- > > > > > > > needed. > > > > > > > > > > > > > > Fixes: > > > > > > > https://bugs.launchpad.net/ubuntu/+source/dpdk/+bug/1841759 > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Christian Ehrhardt < > > > > > > > christian.ehrhardt@canonical.com > > > > > > > > > > > > > > > Acked-by: Luca Boccassi < > > > > > > > bluca@debian.org > > > > > > > > > > > > > > > --- > > > > > > > config/meson.build | 1 - > > > > > > > 1 file changed, 1 deletion(-) > > > > > > > > > > > > > > diff --git a/config/meson.build b/config/meson.build > > > > > > > index 2bafea530..a27f731f8 100644 > > > > > > > --- a/config/meson.build > > > > > > > +++ b/config/meson.build > > > > > > > @@ -94,7 +94,6 @@ dpdk_conf.set('RTE_TOOLCHAIN_' + > > > > > > > toolchain.to_upper(), 1) > > > > > > > dpdk_conf.set('RTE_ARCH_64', cc.sizeof('void *') == 8) > > > > > > > > > > > > > > add_project_link_arguments('-Wl,--no-as-needed', language: 'c') > > > > > > > -dpdk_extra_ldflags += '-Wl,--no-as-needed' > > > > > > > > > > > > > > > > > > > This seems strange to me. What is it about linking the dpdk apps that > > > > > > require the argument, but makes it safe for non-builtin apps to avoid > > > > > > having the arg? > > > > > > > > > > We've been wondering about that for a while :-) It also seems to be not > > > > > reproducible on Ubuntu 18.04/gcc 7.4. > > > > > > > > > > Can the verbose linking log be shared here, so that we can have a look > > > > > at where no-as-needed lands? Might provide some clue > > > > > > > > That would be the verbose linking log of the Travis CI run right? > > > > I currently have no idea which knob to turn to get this :-/ > > > > > > > > Having it accepted in upstream would make it more easy to fix this in > > > > the soon to be released Ubuntu 19.10. > > > > Is there a path to consider taking this fix as-is and continue the > > > > debug/discussion how the removal of the second line can even cause the > > > > symptoms that we have seen later? > > > > > > re-ping for the above ^^ > > > > > > > I'm ok with what you propose above. > > Thanks Bruce! > > Is there anything else we'd need to do to get this committed? And actually 18.11 stable would make sense as well IMHO. Could one who commits could add that as: Fixes: 57ae0ec62620 ("build: add dependency on telemetry to apps with meson") > -- > Christian Ehrhardt > Software Engineer, Ubuntu Server > Canonical Ltd -- Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd