From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B080A00C2 for ; Thu, 17 Nov 2022 08:48:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 38F3C40DDC; Thu, 17 Nov 2022 08:48:14 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id A1FEA40DDA for ; Thu, 17 Nov 2022 08:48:12 +0100 (CET) Received: from mail-ot1-f71.google.com (mail-ot1-f71.google.com [209.85.210.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 3B2403F195 for ; Thu, 17 Nov 2022 07:48:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1668671292; bh=Vl4ns94InCpawCML2N4bUITVNbfIPX4FUTd13TUjahY=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=T355lydSk/t4xfz135SHb43i9Y6DIf0XQW5a0uUkI4wIBX1JgeOrkCem2Jdp5h/RU AxhSi8p6PYC5RLgloH85uQy9Fxr+EbQF5kqv8B5Ax9u7cfsB0XETgXDLKJm/YrSoez ah44S7zFVf2iqVXyoozAGU+jAXZhuL50iZZrYhOsgidDRsRJZHeGS8PE+oSvGX8daM jxA94yeMBjvud08yIdGhFUaMkedSthCO6lpHds8Bgx3LERW6aPZU/FKgmhknR8Nkt3 NH0Feu8U2pIGxuY4DVGpc1wtdfCLPOIJcbM4tfCjfKJPXU29lBSb5+o5ulL9qCdENE QcxTh6n1+3M9Q== Received: by mail-ot1-f71.google.com with SMTP id a66-20020a9d2648000000b0066db1bff57eso446158otb.14 for ; Wed, 16 Nov 2022 23:48:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Vl4ns94InCpawCML2N4bUITVNbfIPX4FUTd13TUjahY=; b=za+CHdDH1ULu0boAUbegqb/6alO5Fifdr//HgqNf1qfToJ00ZxTVAwK0dkUYjaTdxN RaqeO8Fb02YXGuBtpQXpJhX4zTu5umAIrSAeUehQDZInsBUHl39RwNBip2gbVsbxvwSR H7rGzxJzIbTU+2Jw0tzqYlbNMbda/q/QLTrb5qsA4F+vXjIkFf4+SuM66hO4YR/qoxa1 6HazAEra3VhMMVqVrijoldUiDzZz5ZemngMQ46wmP0a96im26e7klbxn9HJJ2CASo223 mklNuXysLl8591fDn/PUulD1ihIaZNG3IxjJwp/jwNN5UdR74mia+Qc0JsWmGTmY8P4B rtig== X-Gm-Message-State: ANoB5pl+bSS45MZdmtUgJ8DMK7EyKf/lPJl3j3YT5DQoFdbJnhXDHrzA evQAiOGjFZNJLUTyW/qlmA6jQqsT6uavreydS6Le88PzKPiYF56b8H1mr37LnW0C8WxA2v+Ueg8 xXxNC989SAQeUoALVwDxdns4JSDVh9uvSuTzasN4k X-Received: by 2002:a05:6808:f8e:b0:35a:6005:3d90 with SMTP id o14-20020a0568080f8e00b0035a60053d90mr549427oiw.127.1668671291196; Wed, 16 Nov 2022 23:48:11 -0800 (PST) X-Google-Smtp-Source: AA0mqf5TSc9GLFZNJr5VARVeJbOMLDc9waaY2V6gp+tZs6/7sEZE2wtFHlbGsyHX2TO8Vi7aYNcRKVvDZOtkb2FY+Lk= X-Received: by 2002:a05:6808:f8e:b0:35a:6005:3d90 with SMTP id o14-20020a0568080f8e00b0035a60053d90mr549418oiw.127.1668671290906; Wed, 16 Nov 2022 23:48:10 -0800 (PST) MIME-Version: 1.0 References: <20221116023926.317352-1-yidingx.zhou@intel.com> In-Reply-To: From: Christian Ehrhardt Date: Thu, 17 Nov 2022 08:47:45 +0100 Message-ID: Subject: Re: [PATCH 19.11] net/iavf: add thread for event callbacks To: "Zhou, YidingX" Cc: "stable@dpdk.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, Nov 16, 2022 at 10:58 AM Zhou, YidingX wrote: > > > > -----Original Message----- > > > From: Christian Ehrhardt > > > Sent: Wednesday, November 16, 2022 4:18 PM > > > To: Zhou, YidingX > > > Cc: stable@dpdk.org > > > Subject: Re: [PATCH 19.11] net/iavf: add thread for event callbacks > > > > > > On Wed, Nov 16, 2022 at 3:35 AM Yiding Zhou > > wrote: > > > > > > > > [upstream commit cb5c1b91f76f436724cd09f26c7432b2775b519c] > > > > > > Hi, > > > I tried to apply this but it causes build errors: > > > > > > [ 151s] iavf_vchnl.o: In function `iavf_dev_event_handler_fini': > > > [ 151s] iavf_vchnl.c:(.text+0x5d9): undefined reference to `pthread_cancel' > > > [ 151s] iavf_vchnl.c:(.text+0x611): undefined reference to `pthread_join' > > > [ 151s] collect2: error: ld returned 1 exit status [ 151s] make[4]: > > > *** [librte_pmd_iavf.so.20.0] Error 1 [ 151s] make[3]: *** [iavf] > > > Error 2 > > > > > > On all redhat, fedora, suse builds. > > > Interestingly the Ubuntu builds worked fine, but only them. > > > > > > Please have a look and resubmit. > > > > > Ok, I will check this on other systems. > > Hi > I have built DPDK successfully on the following systems. > > OS: Fedora release 36 (Thirty Six) > meson: 0.63.1 > ninja: 1.10.2.git.kitware.jobserver-1 > gcc: gcc (GCC) 12.2.1 20220819 (Red Hat 12.2.1-1) > ---------------- > OS: SUSE Linux Enterprise Server 15 SP4 (x86_64) > meson: n0.61.5 > ninja: 1.10.2.git.kitware.jobserver-1 > gcc: gcc (SUSE Linux) 7.5.0 > ---------------- > OS: Red Hat Enterprise Linux release 9.0 (Plow) > meson: 0.63.2 > ninja: 1.10.2.git.kitware.jobserver-1 > gcc: gcc (GCC) 11.2.1 20220127 (Red Hat 11.2.1-9) > > What is your build environment? Hi, We use OBS (Thanks Lucas to set this up, I'm only re-using what he did) to do some cross release/distro build checks based on our WIP branches on github. You can dive into details of logs and configuration here: https://build.opensuse.org/package/show/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11 Not all builds work every time, but between before & after applying a patch for 19.11.x I at least want to see no regressions. Due to that, please ignore suse_factory; suse_tumbleweed, debian_next and fedora_rawhide - those have been broken before. But most others start to fail when applying your patch while being ok before. I'm done with DPDK 19.11 for the rest of today, so to make more sense for you I have applied your patch again and restarted the OBS service. In a few minutes you'll see the artifacts of a build with your patch applied so you can have a look. -- Christian Ehrhardt Senior Staff Engineer, Ubuntu Server Canonical Ltd