From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D5B2A0547 for ; Tue, 15 Nov 2022 09:19:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 17CA940DFD; Tue, 15 Nov 2022 09:19:38 +0100 (CET) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id 5929940150 for ; Tue, 15 Nov 2022 09:19:37 +0100 (CET) Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id D3977423C0 for ; Tue, 15 Nov 2022 08:19:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1668500376; bh=xJLpbJVkP2zZPe6bK2Oryn+8k/LWumuPdo5WFu1LnOE=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=sNqOYoizePPUDFlPOXgmnxxtV5BROzyQ4UHjNeqb84cqv5/pw2HWcaZp2tYub/5Sg osTjNQvGtUGN84hHeeT95MrkEM6beEUgLFyEUQKN4KLQVPdJIOrgoAJ8avirz7jsUd SoN/nfCYMwXaaKYgkUGPP12Ud4tVuvTv3st2mUscLfZnfJQMx1iAfWK1vXuna45z8J XP5620dOSj4vIyt5x6ng3xkhIeOow3NWklCd/z8bks4CjihkaVvLUQqm4ltyxbyz0S kMFwF2+TJ4tmzP/Jt1wQdjFiqNiEodz0i/IRcTYwIcijGFgwzn5PNlgLfnfCGTrsAg Y32b1wR3zujvA== Received: by mail-oi1-f199.google.com with SMTP id r203-20020acac1d4000000b003576bf4f829so4496520oif.15 for ; Tue, 15 Nov 2022 00:19:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xJLpbJVkP2zZPe6bK2Oryn+8k/LWumuPdo5WFu1LnOE=; b=UYvvWb2yG049XfNX2+VefKicX2SB6jPpF2g0Naeu6isye0zM1hQ2WDBvc5aC2MNhGy St9CSCUq5mkla4CGtj8Uc0e4NZb/cSv9UXyzpOmmLFmZRuhF9KQ6MsEMfZK9clMqNBXO m00XAPibqwytBgxB1mDYIcXXcyaDJdSm4ZvSFuHdr7PXyZUVqgy6nADEs4cWx3XhRVur VPvMA05LraiabAfJ5Z0EzDLq8Mg0qzNSZFf8WxNsZ6z5nvNncLpN857EceOkNKtFXD4X iMovTxYKQb9LYRdglJ/A2ogcs6fVmHicv1pzwMXOWi8XFiP2UXROix/BYy2gaH7FcJ3a IjVg== X-Gm-Message-State: ANoB5pmCIFUN9P4sQI8fAhZaXJd1uqkhxgiWge7jevuraiTn5IKteYJT wOZQA/Quqf7n+Wc9jwy53l5t4f9hzVJ+CaYnlK0cjYTG9vugWtuw7tNRhaHyWKiKjrIuu/Vcw3x T1uKU8minJce1vjqHr9Yc8u17kziPqzfWhHHTMW7Z X-Received: by 2002:aca:da57:0:b0:35a:6005:3d90 with SMTP id r84-20020acada57000000b0035a60053d90mr340702oig.127.1668500375656; Tue, 15 Nov 2022 00:19:35 -0800 (PST) X-Google-Smtp-Source: AA0mqf7rrZqLM7oW3OCEEKwgaaJjyQUsgNRy7lBaw0EJoP2xURAufx/nj4MfdsVBG2/e1QXY8Gy9b3AvXe3j4M3tvZk= X-Received: by 2002:aca:da57:0:b0:35a:6005:3d90 with SMTP id r84-20020acada57000000b0035a60053d90mr340700oig.127.1668500375436; Tue, 15 Nov 2022 00:19:35 -0800 (PST) MIME-Version: 1.0 References: <20221114111352.3094085-1-ivan.malov@oktetlabs.ru> In-Reply-To: <20221114111352.3094085-1-ivan.malov@oktetlabs.ru> From: Christian Ehrhardt Date: Tue, 15 Nov 2022 09:19:09 +0100 Message-ID: Subject: Re: [PATCH 19.11] net/bonding: fix flow flush order on close To: Ivan Malov Cc: stable@dpdk.org, Andrew Rybchenko Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Mon, Nov 14, 2022 at 12:13 PM Ivan Malov wrote: > > [ upstream commit df810d1b6e31a3e25085a6abae3be119af3034c1 ] Thanks, applied to the WIP branch - expect it to be part of 19.11.14 unless some builds stumble over it. > The current code first removes all back-end devices of > the bonded device and then invokes flush operation to > remove flows in such back-end devices, which makes no > sense. Fix that by re-ordering the steps accordingly. > > Fixes: 49dad9028e2a ("net/bonding: support flow API") > > Signed-off-by: Ivan Malov > Reviewed-by: Andrew Rybchenko > --- > drivers/net/bonding/rte_eth_bond_pmd.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c > index 4a0f6e1b8..7e79bac42 100644 > --- a/drivers/net/bonding/rte_eth_bond_pmd.c > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c > @@ -2115,6 +2115,10 @@ bond_ethdev_close(struct rte_eth_dev *dev) > struct rte_flow_error ferror; > > RTE_BOND_LOG(INFO, "Closing bonded device %s", dev->device->name); > + > + /* Flush flows in all back-end devices before removing them */ > + bond_flow_ops.flush(dev, &ferror); > + > while (internals->slave_count != skipped) { > uint16_t port_id = internals->slaves[skipped].port_id; > > @@ -2127,7 +2131,6 @@ bond_ethdev_close(struct rte_eth_dev *dev) > skipped++; > } > } > - bond_flow_ops.flush(dev, &ferror); > bond_ethdev_free_queues(dev); > rte_bitmap_reset(internals->vlan_filter_bmp); > } > -- > 2.30.2 > -- Christian Ehrhardt Senior Staff Engineer, Ubuntu Server Canonical Ltd