From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DACFA0524 for ; Tue, 1 Jun 2021 09:45:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 45B1940040; Tue, 1 Jun 2021 09:45:46 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id 3FAD840040 for ; Tue, 1 Jun 2021 09:45:45 +0200 (CEST) Received: from mail-qk1-f197.google.com ([209.85.222.197]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lnz5r-0006dg-Vp for stable@dpdk.org; Tue, 01 Jun 2021 07:45:44 +0000 Received: by mail-qk1-f197.google.com with SMTP id y201-20020a3764d20000b02903a95207e6a4so4730688qkb.2 for ; Tue, 01 Jun 2021 00:45:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=zgLcl/S1VLF6u6ivvCZR0CW9rRVltA/EDMlAM3apGXE=; b=FKOcsypkyEkp6CxJeETdlAH0D0U5lynC8SSIu2/OU5GiGpmFk0Fnnwx+A+2wPVClsm oOsgKn8sxr1BlwHaq4+kEqxgiHdqnCSg3/PJiQGlJIjqyJmIK8nqmaSKFvUTlrDKUWJQ kyhPU6gxz6fPqXjNewLBirtbtwnJBARlDKD8ZGn+j8HFQyIgyc9hsTZZ4+zk/zIwXoaa 3lA6gU7QcdizofyVnuBzx/CRf7h/7uFTuFbOiCv/+7yYo5cBEictqOB2aMZCgEJ7rcG1 QpKAVmT93e0rXowEBvkTw170tq6kMD2wbMZSLLZk6tIRa5QgJYPhHqcUGhlQL/HEU3T3 Ud7g== X-Gm-Message-State: AOAM531F/C/aavb9Pl5RHYbZXbhrYW1nwAw2EvYm+T6zpUySr+2XUXLi kyHy0KrZQtEAJEBEGyG+EpvF61KpmfWNBIEKga12iRZI8QXVm1BhR5VIb4g34s3e0cua56i9t+/ ZnWCu9SPG9dtCtY+nK+bX3aG3zRFn8gDSqxuzcX1j X-Received: by 2002:a0c:c3d1:: with SMTP id p17mr21177354qvi.44.1622533543196; Tue, 01 Jun 2021 00:45:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzAwmPiqkXcyS4b5pVKfAh4l/Ga1fzMyozuiI/orXaj/rdd82rzds9M8m3tjAKHQn39KBYVUC3kisNwn5Dbszg= X-Received: by 2002:a0c:c3d1:: with SMTP id p17mr21177347qvi.44.1622533542990; Tue, 01 Jun 2021 00:45:42 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Christian Ehrhardt Date: Tue, 1 Jun 2021 09:45:17 +0200 Message-ID: To: "Xueming(Steven) Li" Cc: dpdk stable , Luca Boccassi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-stable] Should we backport or skip e132ee86 "devargs: fix memory leak on parsing failure" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Tue, Jun 1, 2021 at 9:01 AM Xueming(Steven) Li wro= te: > > > > > -----Original Message----- > > From: Christian Ehrhardt > > Sent: Tuesday, June 1, 2021 2:07 PM > > To: dpdk stable ; Xueming(Steven) Li > > Cc: Luca Boccassi > > Subject: Should we backport or skip e132ee86 "devargs: fix memory leak = on parsing failure" > > > > Hi Xueming, > > > > I wanted to let you know that while backporting: > > Commit e132ee8690474fa985e26f1d4db75823024748c8 > > Author: Xueming Li > > Date: Tue Apr 13 03:14:09 2021 +0000 > > devargs: fix memory leak on parsing failure > > > > I've found > > > > [ 288s] ../lib/librte_eal/common/eal_common_devargs.c:171:16: error: > > passing argument 1 of =E2=80=98free=E2=80=99 discards =E2=80=98const=E2= =80=99 qualifier from pointer target type [-Werror=3Ddiscarded-qualifiers] > > [ 288s] 171 | free(devargs->data); > > [ 288s] | ~~~~~~~^~~~~~ > > [ 288s] In file included from ../lib/librte_eal/common/include/rte_com= mon.h:20, > > [ 288s] from ../lib/librte_eal/common/include/rte_log= .h:25, > > [ 288s] from ../lib/librte_eal/common/include/rte_bus= .h:24, > > [ 288s] from ../lib/librte_eal/common/eal_common_deva= rgs.c:13: > > [ 288s] /usr/include/stdlib.h:565:25: note: expected =E2=80=98void *= =E2=80=99 but argument is of type =E2=80=98const char *=E2=80=99 > > [ 288s] 565 | extern void free (void *__ptr) __THROW; > > [ 288s] | ~~~~~~^~~~~ > > > > I've seen that to make it work it would require some more from the same= series, but that was not targeted at dpgk-stable > > > > Commit 64051bb1f144c418f3fc76e6d0973337b05d5886 > > Author: Xueming Li > > Date: Tue Apr 13 03:14:08 2021 +0000 > > devargs: unify scratch buffer storage > > > > Then I've checked and seen that it is also not present in lib/librte_ea= l/common/eal_common_devargs.c of 20.11.2 that you are > > preparing so I have also dropped it from 19.11.9 as well for now. > > > > Do you think you'd want to create backports of this for 19.11/20.11 or = is it not important enough to bother about it? > > Yes, need another patch to make this one work. But I don't think it impor= tant enough to have it. Great, that is all I needed to know to "let it go" mentally :-) Thanks! > > -- > > Christian Ehrhardt > > Staff Engineer, Ubuntu Server > > Canonical Ltd --=20 Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd