From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7811A0561 for ; Thu, 18 Mar 2021 12:54:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AAAD040698; Thu, 18 Mar 2021 12:54:49 +0100 (CET) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id B75B440698 for ; Thu, 18 Mar 2021 12:54:48 +0100 (CET) Received: from mail-qv1-f72.google.com ([209.85.219.72]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lMrEm-0003hg-9n for stable@dpdk.org; Thu, 18 Mar 2021 11:54:48 +0000 Received: by mail-qv1-f72.google.com with SMTP id z5so1677083qvo.16 for ; Thu, 18 Mar 2021 04:54:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=siB+WK8uwfPKTTCUo4HTfJlqOy6uUnxm1IemnyiGL3s=; b=jiFQePmInznmsJ40P9mBFUjEqV9JhHFrAwjnnKrgk1rpzCU5Lnk59SirWyB7vp3PWW g+dC+CQ33xQ+DmAavzBQR1VKxQjs5mrzyXvxVtGM1Z0EoBvQx9dQrs0F0EXQgY+NYU6R xhHdwxPlMrMo5UDb95DPAsN2zb8fwpJ3Ks5Pue6FNW+swADAtcpWpSoVB9rFCix7USLo jxWIPmeBchofPqN3/nVTRmXhohr37M82dwtDnC9GG6jeWpZbB9HDWULdWLfc+pdtxlKQ qeuzlWeRAk50YqEuuK7F8NI7yewPh7trKO83GT6ClIcBewcfbzuh+zsGNI7OlmHJyPKg LNdg== X-Gm-Message-State: AOAM533kAFU/257WaFsv38lcZeP2++FYY4Etx8e6OHL8V9qiQltoTwXX 82WvkuPwWLEtUkzMSrwQVpMVFVsmKWJR0zY+xb2YrXwm4/n3mZsvJ3UQGFH45FYT2S2tKwWn/KD SIXfqkGsdNZ+lHB5Bi4Rk6IB4uHF4I0txghbGHyKf X-Received: by 2002:ac8:d44:: with SMTP id r4mr3230615qti.7.1616068487340; Thu, 18 Mar 2021 04:54:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzEa0jLxUFz6JjvFn76cFFSPifOapVXXPn4A6H5nPG2upFBkFKdZKjA0wQKfV2PXHfHukjqz+cTEE8Dm1SX3go= X-Received: by 2002:ac8:d44:: with SMTP id r4mr3230598qti.7.1616068487058; Thu, 18 Mar 2021 04:54:47 -0700 (PDT) MIME-Version: 1.0 References: <20200818181222.8462-1-bluca@debian.org> <20200901124747.GB1047@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: From: Christian Ehrhardt Date: Thu, 18 Mar 2021 12:54:20 +0100 Message-ID: To: "Pai G, Sunil" , "Stokes, Ian" Cc: "Richardson, Bruce" , Luca Boccassi , "stable@dpdk.org" , dev , James Page Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [dpdk-dev] 19.11.4 patches review and test X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Tue, Sep 1, 2020 at 3:23 PM Pai G, Sunil wrote: > > Hi, > > Yes , OVS was using pkg-config even before these patches were rolled out. > But it always used to pick the DPDK shared libs by default for OVS even on using the -Bstatic/-Bshared flags. > These patches from Bruce simplify the process from DPDK side without having the user to specify them. > Moreover, with these patches , the problem of shared DPDK libs always being picked instead of static was not seen any more with a bit of changes from the OVS side as well. > http://patchwork.ozlabs.org/project/openvswitch/patch/20200707141126.71414-1-sunil.pai.g@intel.com/ . > The patches for ovs-master are ready as well and will them out soon. Hi Sunil, Ian, everyone .. back in 19.11.4 these DPDK changes were not picked up as they have broken builds as discussed here. Later on the communication was that all this works fine now and thereby Luca has "reverted the reverts" in 19.11.6 [1]. But today we were made aware that still no OVS 2.13 builds against a DPDK that has those changes. Not 2.13.1 as we have it in Ubuntu nor (if it needs some OVS changes backported) the recent 2.13.3 does build. They still fail with the very same issue I reported [2] back then. Unfortunately I have just released 19.11.7 so I can't revert them there - but OTOH reverting and counter reverting every other release seems wrong anyway. I wanted to ask if there is a set of patches that OVS would need to backport to 2.13.x to make this work? If they could be identified and prepared Distros could use them on 2.13.3 asap and 2.13.4 could officially release them for OVS later on. But for that we'd need a hint which OVS changes that would need to be. All I know atm is from the testing reports on DPDK it seems that OVS 2.14.3 and 2.15 are happy with the new DPDK code. Do you have pointers on what 2.13.3 would need to get backported to work again in regard to this build issue. [1]: http://git.dpdk.org/dpdk-stable/log/?h=19.11&ofs=550 [2]: http://mails.dpdk.org/archives/stable/2020-September/024796.html > Thanks and Regards, > Pai G, Sunil > Sunil > > > -----Original Message----- > > From: Bruce Richardson > > Sent: Tuesday, September 1, 2020 6:18 PM > > To: Christian Ehrhardt > > Cc: Luca Boccassi ; stable@dpdk.org; dev ; > > Pai G, Sunil ; Stokes, Ian > > Subject: Re: [dpdk-dev] 19.11.4 patches review and test > > > > On Tue, Sep 01, 2020 at 02:32:26PM +0200, Christian Ehrhardt wrote: > > > On Tue, Sep 1, 2020 at 10:30 AM Luca Boccassi wrote: > > > > > > > > On Tue, 2020-08-18 at 19:12 +0100, Luca Boccassi wrote: > > > > > Hi all, > > > > > > > > > > Here is a list of patches targeted for stable release 19.11.4. > > > > > > > > > > The planned date for the final release is August 31st. > > > > > > > > > > Please help with testing and validation of your use cases and > > > > > report any issues/results with reply-all to this mail. For the > > > > > final release the fixes and reported validations will be added to the release > > notes. > > > > > > > > > > A release candidate tarball can be found at: > > > > > > > > > > https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.4-rc1 > > > > > > > > > > These patches are located at branch 19.11 of dpdk-stable repo: > > > > > https://dpdk.org/browse/dpdk-stable/ > > > > > > > > > > Thanks. > > > > > > > > > > Luca Boccassi > > > > > > > > Microsoft's regression tests are still running, delaying until > > > > Thursday the 3rd. Apologies for any inconvenience. > > > > > > Due to report on OVS failing to build I happened to find that 19.11.4 > > > has massively changed linking. > > > => https://paste.ubuntu.com/p/znCRR4gpjP/ > > > > > > This was meant to be helpful for sure and I assume is around: > > > 48f7fd27f6 build/pkg-config: prevent overlinking > > > 2d1535d592 build/pkg-config: improve static linking flags > > > 9fb13a12c1 build/pkg-config: output drivers first for static build > > > 59b108d824 build/pkg-config: move pkg-config file creation > > > aea915e944 devtools: test static linkage with pkg-config > > > > > > But overlinking has effectively become underlinking now > > > https://launchpadlibrarian.net/495845224/buildlog_ubuntu-groovy-amd64. > > > openvswitch_2.13.1-0ubuntu2~ppa1_BUILDING.txt.gz > > > > > > /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/10/../../../x86_64-linux- > > gnu/librte_pmd_ring.a(net_ring_rte_eth_ring.c.o): > > > in function `rte_eth_from_rings': > > > (.text+0x91c): undefined reference to `rte_vdev_init' > > > /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/10/../../../x86_64-linux- > > gnu/librte_pmd_ring.a(net_ring_rte_eth_ring.c.o): > > > in function `vdrvinitfn_pmd_ring_drv': > > > (.text.startup+0x28): undefined reference to `rte_vdev_register' > > > collect2: error: ld returned 1 exit status > > > > > > Also as you can see in the pastebin above, CFlags and Libs massively > > > shrunk and likely too much so. > > > > > > Given that this should be a stable release I'd ask to back out those > > > changes so that a test build creates the same .pc file as before - > > > would that make sense? > > > > > > > > Adding some OVS folks on CC. > > > > The request for backporting these actually came from the OVS side, since they > > were deemed necessary to enable OVS to switch to use DPDK pkg-config rather > > than the older approach using a makefile-based build. However, it appears you > > guys were already building OVS using the pkg-config file, and since this causes > > issues where there were none, backing it out seems a prudent choice. > > > > Ian, Sunil, any comments here. > > > > Regards > > /Bruce -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd