From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7714FA034F for ; Wed, 11 Aug 2021 12:10:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3EE9E40040; Wed, 11 Aug 2021 12:10:58 +0200 (CEST) Received: from smtp-relay-canonical-0.canonical.com (smtp-relay-canonical-0.canonical.com [185.125.188.120]) by mails.dpdk.org (Postfix) with ESMTP id 34EC540040 for ; Wed, 11 Aug 2021 12:10:57 +0200 (CEST) Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPS id E9ECD3F04C for ; Wed, 11 Aug 2021 10:10:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1628676656; bh=rHChQ3iIl8n7DSVGVDN8rYTcMSYW+vXgoy09KiLJvdc=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=U2FFVPIrUrGruvtDvwg1kQHwAWrHh4efzM2sCYex8g1wD3YpWcpKNXUwTNxuhdF4l DrnDM1TxwjxmoBGAEMDFNJ1TayycCKMXNX8GYJ0vyGKQ02PQAOxCHESXf/Zi/3uL4o jsDzGZ6hyHNdjFzng2OX3qjsOHecw2cu+6EBE1UMO6xyteCbvCgJNuwQqpWjoOiVom 0ZCRATKIbKeiiCmat9Z1HRerRaWIk74D10u20H/6HRI1yJ3N4gFSAZLuGEOauVu4q/ 5SMmfTH/teMHApZy8+2g1OKM7DkdE9WQUhriH4CbtBckR9yZkRmyN9oe4vTd914ucH DR2/THVK7qCdg== Received: by mail-qt1-f198.google.com with SMTP id m8-20020a05622a0548b029028e6910f18aso1063237qtx.4 for ; Wed, 11 Aug 2021 03:10:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rHChQ3iIl8n7DSVGVDN8rYTcMSYW+vXgoy09KiLJvdc=; b=NApIS0l8EC1a8T7WKUJI3iybwxGH85R/5c2kupaecCcxvX0LzQ9gG07OkvhGjMLsBQ swHxTSMKViMNW3GzoRJjKqC5mADvnWOOlomDkSx0ADv77KimHK9CEzKaODA7/EYbIRHk s21UzPhYql2CAs04js0lNw8/zCPeyPgZOnwyFgmGy2DGUIb57hYDCf4PioSlaqUXK67x GO2eEG4LRXCuuL78NS616FKjT3FxQrFqS3vFHJkoDy19RhtcvFv5V+oF2iOxAoCsXZqy Heo/KGgQAjb7Ft3CHCJt1rIB+4piOXjzTv10mRnmWtVjyGJY8lWu0M40N4smScmp2FKr sN/Q== X-Gm-Message-State: AOAM530d75A7V0BT8w4TfCzHG5y5kiZJ02WJyT2NBScBAZxNhj0rJsEk M3PkMmUqHB91HMOVxvmpV17ckZRw4WW/SqXWjSZyDDbcTd5R3VRky0FMiF2XMxuYCoLLPCyzP0d y7MGxYbnxf3uNhDpWEZDqGNjkyddB2gWESa2eu5QQ X-Received: by 2002:a0c:aac2:: with SMTP id g2mr22997939qvb.44.1628676655973; Wed, 11 Aug 2021 03:10:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwi1EFFM8KYRkU43PCLcmxfoCmOcZeWd1+S4fwfjwCg4ezobN3sJik9IQQbQMbYicVExohnrpdtdxS91ZZFCRk= X-Received: by 2002:a0c:aac2:: with SMTP id g2mr22997931qvb.44.1628676655816; Wed, 11 Aug 2021 03:10:55 -0700 (PDT) MIME-Version: 1.0 References: <20210811095145.1846-1-mk@semihalf.com> In-Reply-To: <20210811095145.1846-1-mk@semihalf.com> From: Christian Ehrhardt Date: Wed, 11 Aug 2021 12:10:30 +0200 Message-ID: To: Michal Krawczyk Cc: dpdk stable , Ghalem Boudour , Olivier Matz Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [PATCH 19.11 1/2] net/ena: enable multi-segment in Tx offload flags X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Wed, Aug 11, 2021 at 11:52 AM Michal Krawczyk wrote: > > From: Ghalem Boudour > > [ upstream commit 3e7008459df969611fb7aa3b885a949515ac0b49 ] > Applied, thanks! > The DPDK ENA driver does not provide multi-segment tx offload capability. > Let's add DEV_TX_OFFLOAD_MULTI_SEGS to ports offload capability by > default, and always set it in dev->data->dev_conf.txmode.offload. > > This flag in not listed in doc/guides/nics/features/default.ini, so > ena.ini does not need to be updated. > > Fixes: 1173fca25af9 ("ena: add polling-mode driver") > Cc: stable@dpdk.org > > Signed-off-by: Ghalem Boudour > Signed-off-by: Olivier Matz > Acked-by: Michal Krawczyk > --- > drivers/net/ena/ena_ethdev.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c > index febca8fdb7..6c9a2aa1a9 100644 > --- a/drivers/net/ena/ena_ethdev.c > +++ b/drivers/net/ena/ena_ethdev.c > @@ -1877,6 +1877,8 @@ static int ena_dev_configure(struct rte_eth_dev *dev) > > adapter->state = ENA_ADAPTER_STATE_CONFIG; > > + dev->data->dev_conf.txmode.offloads |= DEV_TX_OFFLOAD_MULTI_SEGS; > + > adapter->tx_selected_offloads = dev->data->dev_conf.txmode.offloads; > adapter->rx_selected_offloads = dev->data->dev_conf.rxmode.offloads; > return 0; > @@ -1948,6 +1950,7 @@ static int ena_infos_get(struct rte_eth_dev *dev, > DEV_RX_OFFLOAD_TCP_CKSUM; > > rx_feat |= DEV_RX_OFFLOAD_JUMBO_FRAME; > + tx_feat |= DEV_TX_OFFLOAD_MULTI_SEGS; > > /* Inform framework about available features */ > dev_info->rx_offload_capa = rx_feat; > -- > 2.25.1 > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd