From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8D76A034F for ; Mon, 22 Feb 2021 15:56:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9FF7C4003C; Mon, 22 Feb 2021 15:56:00 +0100 (CET) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id 09CA74003C for ; Mon, 22 Feb 2021 15:55:59 +0100 (CET) Received: from mail-oi1-f199.google.com ([209.85.167.199]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lECcw-0006HI-LO for stable@dpdk.org; Mon, 22 Feb 2021 14:55:58 +0000 Received: by mail-oi1-f199.google.com with SMTP id w134so6270860oif.8 for ; Mon, 22 Feb 2021 06:55:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TzGwe19KumLrE4Q9WEV70x5CdlUL7ztG4tBRVi/G2Ps=; b=cEThBJE9LntQLHAaDv4tSgCpRr6yolYXtp+O0UAm7ggDYTp5OaCiKuVsOClfADXVEN L5W1yrz2o6zYr2Edr9Cny3Px7K73bfZVFLJHwpdON5hBv9Br180dHmtdePJwte327HNx O8tkGddqUgs5lo2ZjcWyFQmQbTAIjTL0K7kRPONh4IbZklBBs+P4lIwKrhrN9wtfZD3r aExkexPPHIb5B6rsHZRa4oqr/4zDaBS69CLJ4R1ROYJz8PJjDv7OjDBW15wc+w8KNg33 G6QIq+RC428eWby1Ou1wyQqdI+6YsYNGy4mJGQ8vUhEnPbqJ6nCOsvbEMEWOe9RTsHx2 wTJQ== X-Gm-Message-State: AOAM533ybWlcqpQBbD7t45WuRQy16K7SCtFl4PiaIC5tIdTQ8QB2fLJY yc1Pn5ZNjKXKdejC3KY55YUSyONYXqe5oL6VFWETNaCES/UAjQ6jbk2nVphgLDteV/tFMTBdqrw B3DOIS9CRAJx5Adrc1rCQis5zlDGJQyub1/QM/kum X-Received: by 2002:a9d:2270:: with SMTP id o103mr16757835ota.303.1614005757592; Mon, 22 Feb 2021 06:55:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJyRRHK9ZmksfqLt/KRtsjRcwh2KGA04L7vyjsQBE7jP3PrXFfwgHbJbzdnrkxGotk+9/NviSPnC33gGRyvVqeY= X-Received: by 2002:a9d:2270:: with SMTP id o103mr16757795ota.303.1614005756776; Mon, 22 Feb 2021 06:55:56 -0800 (PST) MIME-Version: 1.0 References: <20210222115840.137249-1-luca.boccassi@gmail.com> <20210222115840.137249-2-luca.boccassi@gmail.com> In-Reply-To: <20210222115840.137249-2-luca.boccassi@gmail.com> From: Christian Ehrhardt Date: Mon, 22 Feb 2021 15:55:31 +0100 Message-ID: To: Luca Boccassi Cc: dpdk stable , Stephen Hemminger , Thomas Monjalon , Raslan Darawsheh Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [PATCH 19.11 2/2] mem: fix build X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Mon, Feb 22, 2021 at 12:58 PM wrote: > > From: Thomas Monjalon > > [ backported from upstream commit 27efcf2003113fc9a236d8cf5b6c5e01b28b59ca ] > > Some compilers (on RHEL7 and CentOS7) were getting this error: > error: "RTE_EXEC_ENV_FREEBSD" is not defined [-Werror=undef] > > Existence of a macro must be checked with "#ifdef" or "#if defined". > > Fixes: d72e4042c5eb ("mem: exclude unused memory from core dump") applied both of this series > Signed-off-by: Thomas Monjalon > Tested-by: Raslan Darawsheh > --- > lib/librte_eal/common/eal_common_memory.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_eal/common/eal_common_memory.c b/lib/librte_eal/common/eal_common_memory.c > index 9a797a4fa3..4c897a13f1 100644 > --- a/lib/librte_eal/common/eal_common_memory.c > +++ b/lib/librte_eal/common/eal_common_memory.c > @@ -42,7 +42,7 @@ static uint64_t system_page_sz; > > #ifdef RTE_EXEC_ENV_LINUX > #define RTE_DONTDUMP MADV_DONTDUMP > -#elif RTE_EXEC_ENV_FREEBSD > +#elif defined RTE_EXEC_ENV_FREEBSD > #define RTE_DONTDUMP MADV_NOCORE > #else > #error "madvise doesn't support this OS" > -- > 2.29.2 > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd