From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24B98A0C52 for ; Mon, 16 Aug 2021 10:52:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1752F4003C; Mon, 16 Aug 2021 10:52:37 +0200 (CEST) Received: from smtp-relay-canonical-1.canonical.com (smtp-relay-canonical-1.canonical.com [185.125.188.121]) by mails.dpdk.org (Postfix) with ESMTP id 6D74C4003C for ; Mon, 16 Aug 2021 10:52:35 +0200 (CEST) Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPS id 54F1A3F357 for ; Mon, 16 Aug 2021 08:52:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1629103955; bh=4hazKHQ7RbDUuF4mmgPi/cvSuNKl7BBi8OaKIcDlJ44=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=SAkQr5pNj1S1stlOxH6AL3zMztrXf2/r+xMEuDa/Dcz+yWM3HlldQdSK6yg7Mveg5 hsy+WUedH1m9C7hy1JFDnT469theMVBd7O2LB/klXc1ud+v5D99b+N1o6frOrN6xOQ w3WzMenJJ6no7nnP8oc41I5vdA05RXBmGzXv+bHaHgnuoUQkvKbY1b6cZf5VIBnmpB 8cnddw2SpDPXyRlrhQ38vHBCbJ3PsbJT9UJbLeCarIW447a68SaZYFCraMG17hQTNt waUbMrmdA1UobJgWWXCgaVn7wgNWWDNByH5LxhBD331yg3dlYwQgYsazcCJx2a861p 9PBEkDSJR8Pug== Received: by mail-qt1-f200.google.com with SMTP id l24-20020ac84a98000000b00298c09593afso1038016qtq.22 for ; Mon, 16 Aug 2021 01:52:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4hazKHQ7RbDUuF4mmgPi/cvSuNKl7BBi8OaKIcDlJ44=; b=tXYq2oAwVdLg7wfoDM+b3qiTH/PRMFCV0+y5GWydoNOtR4/1jLcNCv3v43w7DzrtwQ rDHbES52tC8bomZ2dJ6Fp9ZHn9TEpb+gyQ0f2HP8cYR40pusty0azm/zdk5pnV/d24sT Hf2VB8Jn3np3RcSDzBCq2YaEjgF62MQWsdzBZmKasNwTMIhMfR9512BK4vECMhmbKpJn V7aWHhqBV1GtV5JUaEOl1yGYEGfT/5QpxCTIw8o6ebmtJFYffX9E/UfveOBk1Ig9pYMF RGrQV/493X5In/HB44hlE3ifvZldg2HlbNJpPT7Nv/AAdvVEv/jGCPGppNYtFYtySe6J TENQ== X-Gm-Message-State: AOAM5318LZMrxGDKFyTMCrTZ/+5mdDf+nWbWjTuAb9ugjoJjBbgm2SNZ ke21ift7drllr3By7kvZnFFVn3yvAR3HQJ19J3S1j/NuR6eSQMvgfoYLpwvTB/8Dmen+FU4DZZW 1YanloX+NHN72s4+KkmLK0sDwyfaEAup/dagTOEm3 X-Received: by 2002:a0c:be85:: with SMTP id n5mr14801120qvi.59.1629103954433; Mon, 16 Aug 2021 01:52:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw8LprAw8wn6+oJWkVvD2LLF9W0vnBf90crKTeqtGxTMM8qyOKpoMF/ALa0CBuoeeKP353ihuOrlguiXQvnSAY= X-Received: by 2002:a0c:be85:: with SMTP id n5mr14801113qvi.59.1629103954220; Mon, 16 Aug 2021 01:52:34 -0700 (PDT) MIME-Version: 1.0 References: <20210812092702.2071831-1-dkozlyuk@nvidia.com> In-Reply-To: <20210812092702.2071831-1-dkozlyuk@nvidia.com> From: Christian Ehrhardt Date: Mon, 16 Aug 2021 10:52:08 +0200 Message-ID: To: Dmitry Kozlyuk Cc: dpdk stable , Asaf Penso , Matan Azrad Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [PATCH 19.11] bus: clarify log for non-NUMA-aware devices X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Thu, Aug 12, 2021 at 11:27 AM Dmitry Kozlyuk wrote: > > [ upstream commit e9b3d79b0696cd983ace8e6f65532b240f43a1bb ] > > PCI and vmbus drivers printed a warning when NUMA node > had been reported as (-1) or not reported by OS: Thanks, applied > EAL: Invalid NUMA socket, default to 0 > > This message and its level might confuse users because the configuration > is valid and nothing happens that requires attention or intervention. > It was also printed without the device identification and with an indent > (PCI only), which is confusing unless DEBUG logging is on to print > the header message with the device name. > > Reduce level to INFO, reword the message, and suppress it when there is > only one NUMA node because NUMA awareness does not matter in this case. > Also, remove the indent for PCI. > > Fixes: f0e0e86aa35d ("pci: move NUMA node check from scan to probe") > Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support") > Cc: stable@dpdk.org > > Signed-off-by: Dmitry Kozlyuk > Acked-by: Matan Azrad > --- > doc/guides/nics/ena.rst | 2 +- > drivers/bus/pci/pci_common.c | 5 ++++- > drivers/bus/vmbus/vmbus_common.c | 5 ++++- > 3 files changed, 9 insertions(+), 3 deletions(-) > > diff --git a/doc/guides/nics/ena.rst b/doc/guides/nics/ena.rst > index bbf27f235a..d39201c20b 100644 > --- a/doc/guides/nics/ena.rst > +++ b/doc/guides/nics/ena.rst > @@ -198,7 +198,7 @@ Example output: > > [...] > EAL: PCI device 0000:00:06.0 on NUMA socket -1 > - EAL: Invalid NUMA socket, default to 0 > + EAL: Device 0000:00:06.0 is not NUMA-aware, defaulting socket to 0 > EAL: probe driver: 1d0f:ec20 net_ena > > Interactive-mode selected > diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c > index ab73c009ac..cabfe69ec8 100644 > --- a/drivers/bus/pci/pci_common.c > +++ b/drivers/bus/pci/pci_common.c > @@ -18,6 +18,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -150,7 +151,9 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr, > } > > if (dev->device.numa_node < 0) { > - RTE_LOG(WARNING, EAL, " Invalid NUMA socket, default to 0\n"); > + if (rte_socket_count() > 1) > + RTE_LOG(INFO, EAL, "Device %s is not NUMA-aware, defaulting socket to 0\n", > + dev->name); > dev->device.numa_node = 0; > } > > diff --git a/drivers/bus/vmbus/vmbus_common.c b/drivers/bus/vmbus/vmbus_common.c > index 3adef01c95..34676c48af 100644 > --- a/drivers/bus/vmbus/vmbus_common.c > +++ b/drivers/bus/vmbus/vmbus_common.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -113,7 +114,9 @@ vmbus_probe_one_driver(struct rte_vmbus_driver *dr, > dev->driver = dr; > > if (dev->device.numa_node < 0) { > - VMBUS_LOG(WARNING, " Invalid NUMA socket, default to 0"); > + if (rte_socket_count() > 1) > + VMBUS_LOG(INFO, "Device %s is not NUMA-aware, defaulting socket to 0", > + guid); > dev->device.numa_node = 0; > } > > -- > 2.25.1 > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd