From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15A8FA0524 for ; Tue, 1 Jun 2021 08:07:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D630D40040; Tue, 1 Jun 2021 08:07:39 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id A026640040 for ; Tue, 1 Jun 2021 08:07:38 +0200 (CEST) Received: from mail-qv1-f71.google.com ([209.85.219.71]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lnxYw-0004Li-AF for stable@dpdk.org; Tue, 01 Jun 2021 06:07:38 +0000 Received: by mail-qv1-f71.google.com with SMTP id h11-20020a0ceecb0000b0290211ed54e716so10688055qvs.9 for ; Mon, 31 May 2021 23:07:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc :content-transfer-encoding; bh=fhwzYZ4EZL2FUZBWeHPtpqGihcVDiYXrxPwClN9l7mw=; b=aMWin2zsX/iVzrSVud7A00oZQDEVCVLMJNWTw370LGU3VVKEQDRpZkKOfRcq1NFpgV 7JkYY0nMs/61cTU5mqo6Icj6scuIinYHIETNzcPRK4BnbjJn89mIm8XgohVEKa0AMdmA dMl2L/GBTpCT/B5YJWvOgOdjLH3fX458qGwcMRmnt6fa6DDs68VtTgTteD/9s7w9Ed1E D05y8Pg1PmcvtE2g6TmUWwwY0kxVN4ror8+jQemp+aUf1QRa2d6Vmrr3Qff1rfpKjn9A y0pV61UGx48RCXzyYfA0oMrChNg4VZekB2xmP/qz/UdUh8jZE9Iuh2Dt9glHCFTkwOP4 tNsA== X-Gm-Message-State: AOAM531MZqGvSLocNdizp0fEsFgqtccULFPhpFJc1toMM1ZXGO9NiCqL 3sQsojClDJ4aIOaK8big2Yk91+Ls+zKCEPdcJn2bay/IbCZfUxVf7tEJKbUmp0Txwtd/8H53+8P cFRkVHtv4VFW5VgJFGbNvBZrq4bTfNfb08Wk8ofTW X-Received: by 2002:ac8:7c4b:: with SMTP id o11mr18352755qtv.336.1622527657340; Mon, 31 May 2021 23:07:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzWwIyACnwaGrjB6Rebe0WzC61i5lukdfOMKmTf/nQSSB+BHTRbl/bOi3iaNcyijSOX98lD6HauB2Fu37xLmRs= X-Received: by 2002:ac8:7c4b:: with SMTP id o11mr18352740qtv.336.1622527657084; Mon, 31 May 2021 23:07:37 -0700 (PDT) MIME-Version: 1.0 From: Christian Ehrhardt Date: Tue, 1 Jun 2021 08:07:11 +0200 Message-ID: To: dpdk stable , Xueming Li Cc: Luca Boccassi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] Should we backport or skip e132ee86 "devargs: fix memory leak on parsing failure" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi Xueming, I wanted to let you know that while backporting: Commit e132ee8690474fa985e26f1d4db75823024748c8 Author: Xueming Li Date: Tue Apr 13 03:14:09 2021 +0000 devargs: fix memory leak on parsing failure I've found [ 288s] ../lib/librte_eal/common/eal_common_devargs.c:171:16: error: passing argument 1 of =E2=80=98free=E2=80=99 discards =E2=80=98const=E2=80= =99 qualifier from pointer target type [-Werror=3Ddiscarded-qualifiers] [ 288s] 171 | free(devargs->data); [ 288s] | ~~~~~~~^~~~~~ [ 288s] In file included from ../lib/librte_eal/common/include/rte_common.= h:20, [ 288s] from ../lib/librte_eal/common/include/rte_log.h:2= 5, [ 288s] from ../lib/librte_eal/common/include/rte_bus.h:2= 4, [ 288s] from ../lib/librte_eal/common/eal_common_devargs.= c:13: [ 288s] /usr/include/stdlib.h:565:25: note: expected =E2=80=98void *=E2=80= =99 but argument is of type =E2=80=98const char *=E2=80=99 [ 288s] 565 | extern void free (void *__ptr) __THROW; [ 288s] | ~~~~~~^~~~~ I've seen that to make it work it would require some more from the same series, but that was not targeted at dpgk-stable Commit 64051bb1f144c418f3fc76e6d0973337b05d5886 Author: Xueming Li Date: Tue Apr 13 03:14:08 2021 +0000 devargs: unify scratch buffer storage Then I've checked and seen that it is also not present in lib/librte_eal/common/eal_common_devargs.c of 20.11.2 that you are preparing so I have also dropped it from 19.11.9 as well for now. Do you think you'd want to create backports of this for 19.11/20.11 or is it not important enough to bother about it? --=20 Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd