From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
To: Jiawei Wang <jiaweiw@nvidia.com>
Cc: dpdk stable <stable@dpdk.org>, Ori Kam <orika@nvidia.com>
Subject: [dpdk-stable] " app/testpmd: fix NVGRE encap configuration" incompatible with 19.11.x
Date: Wed, 2 Jun 2021 15:25:28 +0200 [thread overview]
Message-ID: <CAATJJ0L7ik-GBN22ot0tdU3zXWcoyktEQTJeZaxxAUU8SsXyjw@mail.gmail.com> (raw)
Hi,
this change was targeted for the stable releases
commit 9b0da816bdec98c0d6c5d17ccdd337bdbafc3f75
Author: Jiawei Wang <jiaweiw@nvidia.com>
Date: Tue Mar 16 06:18:27 2021 +0200
app/testpmd: fix NVGRE encap configuration
But when applied it causes:
[ 263s] /home/abuild/rpmbuild/BUILD/dpdk-1622611368.078834f40/app/test-pmd/cmdline_flow.c:
In function 'parse_vc_action_nvgre_encap':
[ 263s] /home/abuild/rpmbuild/BUILD/dpdk-1622611368.078834f40/app/test-pmd/cmdline_flow.c:4254:3:
error: missing initializer for field 'protocol' of 'struct
rte_flow_item_nvgre' [-Werror=missing-field-initializers]
[ 263s] .item_nvgre.protocol = RTE_BE16(RTE_ETHER_TYPE_TEB),
[ 263s] ^
[ 263s] In file included from
/home/abuild/rpmbuild/BUILD/dpdk-1622611368.078834f40/x86_64-default-linux-gcc/include/rte_eth_ctrl.h:11:0,
[ 263s] from
/home/abuild/rpmbuild/BUILD/dpdk-1622611368.078834f40/x86_64-default-linux-gcc/include/rte_ethdev.h:978,
[ 263s] from
/home/abuild/rpmbuild/BUILD/dpdk-1622611368.078834f40/app/test-pmd/cmdline_flow.c:18:
[ 263s] /home/abuild/rpmbuild/BUILD/dpdk-1622611368.078834f40/x86_64-default-linux-gcc/include/rte_flow.h:917:13:
note: 'protocol' declared here
[ 263s] rte_be16_t protocol; /**< Protocol type (0x6558). */
[ 263s] ^
This is failing not everywhere but in:
- SLE_12_SP4/x86_64
- RHEL_7/x86_64
- openSUSE_Leap_42.3/x86_64
The type and the init code looks the same here and in the recent main branch.
Neither do I see recent changes that would cause this.
And the init just looks right to me, so I'm sure I'm overlooking something.
So I wondered (if you consider this patch important for 19.11.x) if
you could have
a look and consider backporting it so that it works well (or as an alternative
let me know that it won't be needed for 19.11.x)
References/Logs:
19.11.8 working: https://paste.ubuntu.com/p/vvm4qCcmJT/
19.11.9 fail RH7: https://paste.ubuntu.com/p/2wph5nfbCg/
19.11.9 fail SLE12SP4: https://paste.ubuntu.com/p/nGHhkPJbR3/
19.11.9 fail openSuse42.3: https://paste.ubuntu.com/p/43mMx3sY2n/
19.11.9 witzh the patch dropped works: https://paste.ubuntu.com/p/JGZ44BhkC6/
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
next reply other threads:[~2021-06-02 13:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 13:25 Christian Ehrhardt [this message]
2021-06-03 14:54 ` Jiawei(Jonny) Wang
2021-06-04 5:07 ` Christian Ehrhardt
2021-06-04 13:44 ` Jiawei(Jonny) Wang
2021-06-08 4:50 ` Christian Ehrhardt
2021-06-08 5:59 ` Jiawei(Jonny) Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAATJJ0L7ik-GBN22ot0tdU3zXWcoyktEQTJeZaxxAUU8SsXyjw@mail.gmail.com \
--to=christian.ehrhardt@canonical.com \
--cc=jiaweiw@nvidia.com \
--cc=orika@nvidia.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).