From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37319A0032 for ; Mon, 11 Jul 2022 08:16:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A1CD4021E; Mon, 11 Jul 2022 08:16:41 +0200 (CEST) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id 214A44021E for ; Mon, 11 Jul 2022 08:16:40 +0200 (CEST) Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id B6FA63F1D7 for ; Mon, 11 Jul 2022 06:16:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1657520199; bh=mHQH6aV9zb1LqtueBhulqiNp43MVy6u6xYRQIjRii4U=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=tn/xveY/pfIziQtp5zUDoVnxDI5XAf2G+eJCEudwm/o3KVrMqQWfbkCvvvr6bUhbc NCTT8cH6mSYIl6ga+wMK7ZVAenBxfhFW9NpzHFWvqIJS/oZA9lmvh9ewU+ERiNR5EH wpfyZOi752BGLN4iTSVlcCNlCvAhKhjjWHimwkhzeXCI/8oLXMrVWt1k5CXqGqO8h3 BY+QVOV/tHzknTjajd99ikfpPXlRLCJCO+j6sqjOqfcthsfHZGeNu8wvBUJeKmKxYC /m8EkqT/Y5XcNfQ4/UJaoit9EM0cACr5QJJSDAeQQsZ72Ni/gkXpNmxTAbZXBPE0gf fGucXY5Wni3zw== Received: by mail-lf1-f69.google.com with SMTP id z13-20020a056512308d00b004811694f893so1772316lfd.6 for ; Sun, 10 Jul 2022 23:16:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mHQH6aV9zb1LqtueBhulqiNp43MVy6u6xYRQIjRii4U=; b=JcBAT53C2I6Ni8AU9nsUB4tbJEb9+pqjgdnC3JDoF5+jMklI0LTaw5Y94U9zGw0XjL kRQsrSDrCXCloaGP1pTyjYFQNLuzqgWqatn2s3CHYikBpbFcgzYjg7mSRGJINnW/mcG+ 1sDo+x+XYIu26ICylHtyOdepho1fp+8IqcEanrobf+w0SYaTp5zaJmU0K0HjC23fs5rJ LPo0omE2kXegi9xtynRxKXD648vLUdO1RWBVRozW2VTZ8QSPpIb/m03KUNFgoae+9sQH 4pN14xFn2KOdudYo4JytuuUv+lcq8L9FjADoh7pJQcddTtJ0wRf8Cq6hQBXGrJmoRUkf /BWw== X-Gm-Message-State: AJIora/OxgukzsLvLYDEOmB1Y0S1oZXe8osgaLh+KjeZMcylW/AIum02 VDYf+GfBTZGP8SZ3WAXrMCOpXsyyVqlu3NCEdvSvjYrSwFHJoZs31PAzr9TKuKPNQk/kwfO+9E/ d5LwmAOiPrTbRgfgannhVba9jTHHyyfAfgy3r4hQp X-Received: by 2002:a05:6512:3b26:b0:47f:9895:703c with SMTP id f38-20020a0565123b2600b0047f9895703cmr11116655lfv.395.1657520198753; Sun, 10 Jul 2022 23:16:38 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vVYVlLsJBfPNob/jRZ6/lMWUTMr/ONmFS8pKnezWDQRwU5IcA0YnylHF4afExRe/ut+DTCbBPRm8hkp2eD4y0= X-Received: by 2002:a05:6512:3b26:b0:47f:9895:703c with SMTP id f38-20020a0565123b2600b0047f9895703cmr11116643lfv.395.1657520198572; Sun, 10 Jul 2022 23:16:38 -0700 (PDT) MIME-Version: 1.0 References: <20220710070342.563953-1-michaelba@nvidia.com> In-Reply-To: <20220710070342.563953-1-michaelba@nvidia.com> From: Christian Ehrhardt Date: Mon, 11 Jul 2022 08:16:12 +0200 Message-ID: Subject: Re: [PATCH 19.11] net/mlx5: fix LRO validation in Rx setup To: Michael Baum Cc: stable@dpdk.org, Matan Azrad , Viacheslav Ovsiienko Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Sun, Jul 10, 2022 at 9:04 AM Michael Baum wrote: > > [ upstream commit a213b8682117711c8e92475c5bbb321a3d8428dd ] Thanks, applied > The mlx5_rx_queue_setup() get LRO offload from user. > > When LRO is configured, the LRO flag in rxq_data is set to 1. > > This patch adds validation to make sure the LRO is supported. > > Fixes: 17ed314 ("net/mlx5: allow LRO per Rx queue") > > Signed-off-by: Michael Baum > Acked-by: Matan Azrad > --- > drivers/net/mlx5/mlx5_rxq.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c > index bb4f11bccb..7a0a7e6ac9 100644 > --- a/drivers/net/mlx5/mlx5_rxq.c > +++ b/drivers/net/mlx5/mlx5_rxq.c > @@ -502,8 +502,18 @@ mlx5_rx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc, > struct mlx5_rxq_data *rxq = (*priv->rxqs)[idx]; > struct mlx5_rxq_ctrl *rxq_ctrl = > container_of(rxq, struct mlx5_rxq_ctrl, rxq); > + uint64_t offloads = conf->offloads | > + dev->data->dev_conf.rxmode.offloads; > int res; > > + if ((offloads & DEV_RX_OFFLOAD_TCP_LRO) && > + !priv->config.lro.supported) { > + DRV_LOG(ERR, > + "Port %u queue %u LRO is configured but not supported.", > + dev->data->port_id, idx); > + rte_errno = EINVAL; > + return -rte_errno; > + } > res = mlx5_rx_queue_pre_setup(dev, idx, &desc); > if (res) > return res; > -- > 2.25.1 > -- Christian Ehrhardt Senior Staff Engineer, Ubuntu Server Canonical Ltd