From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99CCEA00C2 for ; Thu, 17 Nov 2022 07:28:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7216540DDC; Thu, 17 Nov 2022 07:28:01 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id C230F40DDA for ; Thu, 17 Nov 2022 07:27:59 +0100 (CET) Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 987CB3F470 for ; Thu, 17 Nov 2022 06:27:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1668666476; bh=Hwe/mnRU7TTHTf1KOvr5fo1d9uQQuuDftcFYiN9n32s=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=LtCsWrvuVypQNLaNT8hDTX+MzapNgXiBPj5rrXXNILrsf6249gUkXXS/I6cOOVGYS n3LEMUxLhlnwC2FBiWdiKT8GgIvZzeD5v5OsxQU1gTKOIy1hfRj+xWUmtOyLhjhIJN ycymIJPThOxho0OPqynCKvuMT5++X033F60KslnUHwNzbcMfxpb+tOrku3zWmCegTu 04jlqgcQuu5a6WjDDehAw7uH+Eck9ivJ9zbfH/2w+hpfPWNyZlDeJLg+OyWqUJCROT bLFk0vncQ0vuwj6JHQu4GfugsdMjmf3xXC8jS+EajKpEFlHztwXJYocId2jBVwshpc advqTyyDi3j8g== Received: by mail-oi1-f198.google.com with SMTP id 13-20020aca280d000000b0035a3c3d34c7so454632oix.21 for ; Wed, 16 Nov 2022 22:27:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Hwe/mnRU7TTHTf1KOvr5fo1d9uQQuuDftcFYiN9n32s=; b=7HybMXwwFwbXcjeREC+1wM5z8ZrfY9kRMnoqXGX5Ya+Gx3Et2aaDDMp0U49UY3qiJb jL/YqZGOkDtE3Ek7UKSlYN6AaCJv5/qDDu1JFxQTyqTbG2B4LryXysYDeAvKNEx+FFd3 LeMLQkBnTfKI+3P/ktqe7hYm3qYfHIQkpJ+U2WAmYVMQ0JNhK5lsid6vsOQg7ZGuSh9U y7H56u5ocGi0gF7nwyZcwjmw8VG6SPPThIkhKSXDWidjTJIjmXDXmfX9xwY8nW2UTKqU QHBzJiy1KpslXNxu9jhs6cT2H+9asRutsjemhIF4xCQZttcAbUvyuGD3WGONOtaPR/yQ bVQA== X-Gm-Message-State: ANoB5pniHbaS2G6cxOmMAfH9UsXlIqmrxAHgk2X7th8JYU5KWsj8myEl Sj7r5Icl/CFqBCCTA5x2Cna0QEF3MGwg6LbdAbnt0+kau9WQWISMYzR+GpD9mFwF5PBkcnzfO/g O8PvMJ/5imYHlFmId0IITJRsDW6yIl3lyR8Jw8RRP X-Received: by 2002:a05:6871:4411:b0:131:caf1:947 with SMTP id nd17-20020a056871441100b00131caf10947mr3655334oab.204.1668666475194; Wed, 16 Nov 2022 22:27:55 -0800 (PST) X-Google-Smtp-Source: AA0mqf4EyAdZRAMjHv+YotUU98b7EfB+19Mb55nJSG6O5XsHzgBBWS2eASxsKk2w9BpPgc+DeYieW/eR6narkfhONzA= X-Received: by 2002:a05:6871:4411:b0:131:caf1:947 with SMTP id nd17-20020a056871441100b00131caf10947mr3655296oab.204.1668666474976; Wed, 16 Nov 2022 22:27:54 -0800 (PST) MIME-Version: 1.0 References: <20221111114814.1553136-1-christian.ehrhardt@canonical.com> <98CBD80474FA8B44BF855DF32C47DC35D874C6@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D874C6@smartserver.smartshare.dk> From: Christian Ehrhardt Date: Thu, 17 Nov 2022 07:27:29 +0100 Message-ID: Subject: Re: please help backporting some patches to stable release 19.11.14 To: =?UTF-8?Q?Morten_Br=C3=B8rup?= Cc: dpdk stable , Konstantin Ananyev , Konstantin Ananyev , Kumara Parameshwaran , Lijun Ou , Lior Margalit , Long Li , Long Wu , Mah Yock Gen , Mao YingMing , Matan Azrad , Matan Azrad , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , Maxime Coquelin , "Min Hu (Connor)" , Nikhil Rao , Niklas Soderlund , Nithin Dabilpuram , Olivier Matz , Ori Kam , Pablo de Lara , Paul M Stillwell Jr , Pavan Nikhilesh , Peng Zhang , Qiming Yang , Qi Zhang , Radu Nicolau , Raja Zidane , Remy Horton , Rolf Neugebauer , Shahaf Shuler , Shally Verma , Shijith Thotton , Shiqi Liu <835703180@qq.com>, Simei Su , Somnath Kotur , Suanming Mou , Sunila Sahu , Taripin Samuel , Umesh Kartha , Usman Tanveer , Viacheslav Ovsiienko , Vladimir Medvedkin , "Wei Hu (Xavier)" , Wei Ling , Wenwu Ma , Wenzhuo Lu , Yiding Zhou , Yisen Zhuang , Yongseok Koh , Yuan Wang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, Nov 16, 2022 at 11:45 AM Morten Br=C3=B8rup wrote: > > > From: christian.ehrhardt@canonical.com > > Sent: Friday, 11 November 2022 12.48 > > [...] > > > 459531c958 Morten Br=C3=B8rup mempool: fix cache flushing algorithm > > a2833ecc5e Morten Br=C3=B8rup mempool: fix get objects from mempool= with > > cache > > These two patches fixes some performance issues for certain use cases. Th= e affected use cases work without the patches, but don't get the improved p= erformance. > > However, these patches change the inner workings of the mempool cache. > > And since some PMDs bypass the mempool API and interact directly with the= mempool caches, there is a risk that applications do the same. > > Although these patches are relevant for the performance of the affected u= se cases, I fear that backporting them would introduce an unwanted risk of = breaking PMDs and/or applications (generally, not just for the affected use= cases). Thanks for your thoughts, I completely agree. Let us now backport them and keep -stable stable. > For the common good, I prefer not backporting them. Anyone feel free to s= peak up if you disagree. > > We have a policy of not backporting performance improvements, and fixing = a lack of performance could be interpreted as falling under this policy. > --=20 Christian Ehrhardt Senior Staff Engineer, Ubuntu Server Canonical Ltd