* [dpdk-stable] [19.11 20.11 PATCH] test/cmdline: silence clang 12 warning
@ 2021-06-10 11:00 Kevin Traynor
2021-06-13 7:37 ` Xueming(Steven) Li
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Traynor @ 2021-06-10 11:00 UTC (permalink / raw)
To: stable; +Cc: bluca, christian.ehrhardt, xuemingl, Kevin Traynor
[ upstream commit 5ac070cfed17111ccaf5aee0cc08119ebb1c4e5e ]
clang 12 gives a warning about string concatenation in arrays.
In this case, as it is a long string test the strings are concatenated.
Add parentheses to indicate this.
$ clang --version
clang version 12.0.0 (Fedora 12.0.0-0.3.rc1.fc34)
../app/test/test_cmdline_num.c:204:5: warning:
suspicious concatenation of string literals in an array initialization;
did you mean to separate the elements with a comma?
[-Wstring-concatenation]
"1111000011110000111100001111000011110000111100001111000011110000",
^
../app/test/test_cmdline_num.c:203:3: note:
place parentheses around the string literal to silence warning
"0b1111000011110000111100001111000011110000111100001111000011110000"
^
Fixes: dbb860e03eb1 ("cmdline: tests")
Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
---
app/test/test_cmdline_num.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test/test_cmdline_num.c b/app/test/test_cmdline_num.c
index ec479cdb3a..9276de59bd 100644
--- a/app/test/test_cmdline_num.c
+++ b/app/test/test_cmdline_num.c
@@ -201,6 +201,6 @@ const char * num_invalid_strs[] = {
"-0b0111010101",
/* too long (128+ chars) */
- "0b1111000011110000111100001111000011110000111100001111000011110000"
- "1111000011110000111100001111000011110000111100001111000011110000",
+ ("0b1111000011110000111100001111000011110000111100001111000011110000"
+ "1111000011110000111100001111000011110000111100001111000011110000"),
"1E3",
"0A",
--
2.31.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [19.11 20.11 PATCH] test/cmdline: silence clang 12 warning
2021-06-10 11:00 [dpdk-stable] [19.11 20.11 PATCH] test/cmdline: silence clang 12 warning Kevin Traynor
@ 2021-06-13 7:37 ` Xueming(Steven) Li
2021-06-14 4:53 ` Christian Ehrhardt
0 siblings, 1 reply; 3+ messages in thread
From: Xueming(Steven) Li @ 2021-06-13 7:37 UTC (permalink / raw)
To: Kevin Traynor, stable; +Cc: bluca, christian.ehrhardt
Applied, thanks!
> -----Original Message-----
> From: Kevin Traynor <ktraynor@redhat.com>
> Sent: Thursday, June 10, 2021 7:00 PM
> To: stable@dpdk.org
> Cc: bluca@debian.org; christian.ehrhardt@canonical.com; Xueming(Steven) Li <xuemingl@nvidia.com>; Kevin Traynor
> <ktraynor@redhat.com>
> Subject: [19.11 20.11 PATCH] test/cmdline: silence clang 12 warning
>
> [ upstream commit 5ac070cfed17111ccaf5aee0cc08119ebb1c4e5e ]
>
> clang 12 gives a warning about string concatenation in arrays.
> In this case, as it is a long string test the strings are concatenated.
> Add parentheses to indicate this.
>
> $ clang --version
> clang version 12.0.0 (Fedora 12.0.0-0.3.rc1.fc34)
>
> ../app/test/test_cmdline_num.c:204:5: warning:
> suspicious concatenation of string literals in an array initialization; did you mean to separate the elements with a comma?
> [-Wstring-concatenation]
> "1111000011110000111100001111000011110000111100001111000011110000",
> ^
> ../app/test/test_cmdline_num.c:203:3: note:
> place parentheses around the string literal to silence warning
> "0b1111000011110000111100001111000011110000111100001111000011110000"
> ^
>
> Fixes: dbb860e03eb1 ("cmdline: tests")
>
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> ---
> app/test/test_cmdline_num.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/app/test/test_cmdline_num.c b/app/test/test_cmdline_num.c index ec479cdb3a..9276de59bd 100644
> --- a/app/test/test_cmdline_num.c
> +++ b/app/test/test_cmdline_num.c
> @@ -201,6 +201,6 @@ const char * num_invalid_strs[] = {
> "-0b0111010101",
> /* too long (128+ chars) */
> - "0b1111000011110000111100001111000011110000111100001111000011110000"
> - "1111000011110000111100001111000011110000111100001111000011110000",
> + ("0b1111000011110000111100001111000011110000111100001111000011110000"
> +
> +"1111000011110000111100001111000011110000111100001111000011110000"),
> "1E3",
> "0A",
> --
> 2.31.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [19.11 20.11 PATCH] test/cmdline: silence clang 12 warning
2021-06-13 7:37 ` Xueming(Steven) Li
@ 2021-06-14 4:53 ` Christian Ehrhardt
0 siblings, 0 replies; 3+ messages in thread
From: Christian Ehrhardt @ 2021-06-14 4:53 UTC (permalink / raw)
To: Xueming(Steven) Li; +Cc: Kevin Traynor, stable, bluca
On Sun, Jun 13, 2021 at 9:37 AM Xueming(Steven) Li <xuemingl@nvidia.com> wrote:
>
> Applied, thanks!
>
19.11 had this already from our recent discussion - thanks
> > -----Original Message-----
> > From: Kevin Traynor <ktraynor@redhat.com>
> > Sent: Thursday, June 10, 2021 7:00 PM
> > To: stable@dpdk.org
> > Cc: bluca@debian.org; christian.ehrhardt@canonical.com; Xueming(Steven) Li <xuemingl@nvidia.com>; Kevin Traynor
> > <ktraynor@redhat.com>
> > Subject: [19.11 20.11 PATCH] test/cmdline: silence clang 12 warning
> >
> > [ upstream commit 5ac070cfed17111ccaf5aee0cc08119ebb1c4e5e ]
> >
> > clang 12 gives a warning about string concatenation in arrays.
> > In this case, as it is a long string test the strings are concatenated.
> > Add parentheses to indicate this.
> >
> > $ clang --version
> > clang version 12.0.0 (Fedora 12.0.0-0.3.rc1.fc34)
> >
> > ../app/test/test_cmdline_num.c:204:5: warning:
> > suspicious concatenation of string literals in an array initialization; did you mean to separate the elements with a comma?
> > [-Wstring-concatenation]
> > "1111000011110000111100001111000011110000111100001111000011110000",
> > ^
> > ../app/test/test_cmdline_num.c:203:3: note:
> > place parentheses around the string literal to silence warning
> > "0b1111000011110000111100001111000011110000111100001111000011110000"
> > ^
> >
> > Fixes: dbb860e03eb1 ("cmdline: tests")
> >
> > Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> > ---
> > app/test/test_cmdline_num.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/app/test/test_cmdline_num.c b/app/test/test_cmdline_num.c index ec479cdb3a..9276de59bd 100644
> > --- a/app/test/test_cmdline_num.c
> > +++ b/app/test/test_cmdline_num.c
> > @@ -201,6 +201,6 @@ const char * num_invalid_strs[] = {
> > "-0b0111010101",
> > /* too long (128+ chars) */
> > - "0b1111000011110000111100001111000011110000111100001111000011110000"
> > - "1111000011110000111100001111000011110000111100001111000011110000",
> > + ("0b1111000011110000111100001111000011110000111100001111000011110000"
> > +
> > +"1111000011110000111100001111000011110000111100001111000011110000"),
> > "1E3",
> > "0A",
> > --
> > 2.31.1
>
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-14 4:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-10 11:00 [dpdk-stable] [19.11 20.11 PATCH] test/cmdline: silence clang 12 warning Kevin Traynor
2021-06-13 7:37 ` Xueming(Steven) Li
2021-06-14 4:53 ` Christian Ehrhardt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).