From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42BA5A0548 for ; Mon, 14 Jun 2021 06:53:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B2244003E; Mon, 14 Jun 2021 06:53:55 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id E62874003E for ; Mon, 14 Jun 2021 06:53:53 +0200 (CEST) Received: from mail-qt1-f198.google.com ([209.85.160.198]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lsebh-0007GP-H0 for stable@dpdk.org; Mon, 14 Jun 2021 04:53:53 +0000 Received: by mail-qt1-f198.google.com with SMTP id a12-20020ac8108c0000b029023c90fba3dcso6783871qtj.7 for ; Sun, 13 Jun 2021 21:53:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=djyoquKKYTa/QMD8VoPE9mcX3IkDxKRCVCJq/TatU2U=; b=lm5s/x+gCDSlxYlMdNHBtrGe4ZFfRQ++bhd/j3v97Ki5IHNpOIr7OHGAKv+/VwNI6w TdCBb07f1Tzt8lqDdA+yU6MypQq1tYcDc/00aItOJ7JUhTW4EqeLQYzfApcyXXMD/cYq 7w9BINuhCQ5SEQPJs0uY4u1g0DiX1EwNMZTjfzKmacHOHM8x2LUpwVcgySVwv+HHzg6v EwogBPO2xXUn9iZpY1EpQaBj/5WrYmRGZkqyjnYU6t8+ArQyhPqfplYSfWNvMsqBJ+ds 3sHTK0kg/o+f5jd1fAhJOZxLfCYBhRf/YitnoodwEnUt0o5OugXvM6v4qNcq/oGU2++R PY8g== X-Gm-Message-State: AOAM5304J3I9dYLDU3ps2nvuRh1v+bjKHihjIz4YgECydHcmjQYWuK2T dqTiyXPsiJMDvOuN1CRuNYLOR/fXkJZg6V4d2PMgWQkbLK5ccUqufkyQP7FY6kUlP3rXBXLXaja PYUXHdwEWrFv9BBZLtG1p9OLDVECarrXvmsepo/s+ X-Received: by 2002:a0c:e88b:: with SMTP id b11mr16717693qvo.59.1623646432490; Sun, 13 Jun 2021 21:53:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyiwhFpNxsHp4uXW2ULRt1d0qlmWHP1vpw8OAJM/cdz8kUaNjuA0Dxte9UygZrUGG2myfJY2zfeiGdEu4v9pDg= X-Received: by 2002:a0c:e88b:: with SMTP id b11mr16717684qvo.59.1623646432288; Sun, 13 Jun 2021 21:53:52 -0700 (PDT) MIME-Version: 1.0 References: <20210610110028.230803-1-ktraynor@redhat.com> In-Reply-To: From: Christian Ehrhardt Date: Mon, 14 Jun 2021 06:53:26 +0200 Message-ID: To: "Xueming(Steven) Li" Cc: Kevin Traynor , "stable@dpdk.org" , "bluca@debian.org" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [19.11 20.11 PATCH] test/cmdline: silence clang 12 warning X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Sun, Jun 13, 2021 at 9:37 AM Xueming(Steven) Li wrote: > > Applied, thanks! > 19.11 had this already from our recent discussion - thanks > > -----Original Message----- > > From: Kevin Traynor > > Sent: Thursday, June 10, 2021 7:00 PM > > To: stable@dpdk.org > > Cc: bluca@debian.org; christian.ehrhardt@canonical.com; Xueming(Steven) Li ; Kevin Traynor > > > > Subject: [19.11 20.11 PATCH] test/cmdline: silence clang 12 warning > > > > [ upstream commit 5ac070cfed17111ccaf5aee0cc08119ebb1c4e5e ] > > > > clang 12 gives a warning about string concatenation in arrays. > > In this case, as it is a long string test the strings are concatenated. > > Add parentheses to indicate this. > > > > $ clang --version > > clang version 12.0.0 (Fedora 12.0.0-0.3.rc1.fc34) > > > > ../app/test/test_cmdline_num.c:204:5: warning: > > suspicious concatenation of string literals in an array initialization; did you mean to separate the elements with a comma? > > [-Wstring-concatenation] > > "1111000011110000111100001111000011110000111100001111000011110000", > > ^ > > ../app/test/test_cmdline_num.c:203:3: note: > > place parentheses around the string literal to silence warning > > "0b1111000011110000111100001111000011110000111100001111000011110000" > > ^ > > > > Fixes: dbb860e03eb1 ("cmdline: tests") > > > > Signed-off-by: Kevin Traynor > > --- > > app/test/test_cmdline_num.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/app/test/test_cmdline_num.c b/app/test/test_cmdline_num.c index ec479cdb3a..9276de59bd 100644 > > --- a/app/test/test_cmdline_num.c > > +++ b/app/test/test_cmdline_num.c > > @@ -201,6 +201,6 @@ const char * num_invalid_strs[] = { > > "-0b0111010101", > > /* too long (128+ chars) */ > > - "0b1111000011110000111100001111000011110000111100001111000011110000" > > - "1111000011110000111100001111000011110000111100001111000011110000", > > + ("0b1111000011110000111100001111000011110000111100001111000011110000" > > + > > +"1111000011110000111100001111000011110000111100001111000011110000"), > > "1E3", > > "0A", > > -- > > 2.31.1 > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd