From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 10B83A0524 for ; Mon, 31 May 2021 10:41:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B7E8B40040; Mon, 31 May 2021 10:41:53 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id 6087F40040 for ; Mon, 31 May 2021 10:41:52 +0200 (CEST) Received: from mail-qt1-f198.google.com ([209.85.160.198]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lndUd-0002Kj-UD for stable@dpdk.org; Mon, 31 May 2021 08:41:51 +0000 Received: by mail-qt1-f198.google.com with SMTP id d7-20020ac811870000b02901e65f85117bso3810030qtj.18 for ; Mon, 31 May 2021 01:41:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=syL6Q1teJj7a0pFTjS22EdX35ag7s8WHbEdoaFxuOrM=; b=etiBfijFI+aO7p+cVBuWFGVPfCGsmlIfeKNGlOdcudzLb1urEegiuUbLuqRSa5vIB9 vEbUOSl0almB3Q3ki9+qx9P0Gy7mYAq5FM0cWV4iyl3JSWn9vMQ7LbjJwMevHxZsNfYg jnSwE1dxXw77DiKGQHL28YuaCeHE3S9E4oXmAm8HTw8oMmvuUPGE50cAF4q/Oyx7LpM/ ADAoIFN/h5Vuh4xv8tSRMjnXnDhuf88rCc07rUkh0pbdYTlQFJDB1AjfDRWMNFWUVcOS ciCaVkdPRR+HMVA0xDaG3wj8QOsPehuw//Ek2p3tNxhb//e3fACWiBFdg0QNBSwKhO06 POmA== X-Gm-Message-State: AOAM53384GxBkcW5jus6kEqebH+pJO25NefYZxbSh/RNbgzM9kA4pm4E mkRYxEFazKSMJm1VINVwaAtdgQjKgipFsf1GzLAbnQXxHXE2BPtcuOQWO8iEYj0YF/238HOtlot Yyrcrw8gGmfPELgunKHcEA6rn7te58+7M0+Ro4pjK X-Received: by 2002:a05:620a:1667:: with SMTP id d7mr15471642qko.462.1622450511029; Mon, 31 May 2021 01:41:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzZn4cV/bBICPvQc2xs4lbELl1EmwUFbgoXonDaGkDQlkqg6j+NNIHaVVaVy0WSg616mYTfnBMXIimix/hCTnk= X-Received: by 2002:a05:620a:1667:: with SMTP id d7mr15471624qko.462.1622450510828; Mon, 31 May 2021 01:41:50 -0700 (PDT) MIME-Version: 1.0 References: <20210523081242.19860-1-talshn@nvidia.com> In-Reply-To: <20210523081242.19860-1-talshn@nvidia.com> From: Christian Ehrhardt Date: Mon, 31 May 2021 10:41:25 +0200 Message-ID: To: Tal Shnaiderman Cc: dpdk stable , Thomas Monjalon , pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, Xueming Li Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [PATCH 19.11.9] eal/windows: fix default thread priority X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Sun, May 23, 2021 at 10:13 AM Tal Shnaiderman wrote: > > [ upstream commit 16afcbfa30e9c2831264fb349457a4228fa687c8 ] Thank you for the backport, queued for 19.11.9 now > The hard-coded thread priority for Windows threads in EAL > is REALTIME_PRIORITY_CLASS/THREAD_PRIORITY_TIME_CRITICAL. > > This results in issues with DPDK threads causing OS thread starvation > and eventually a bugcheck. > > The fix reduce the thread priority to > NORMAL_PRIORITY_CLASS/THREAD_PRIORITY_NORMAL. > > Bugzilla ID: 600 > > Reported-by: Odi Assli > Signed-off-by: Tal Shnaiderman > Acked-by: Dmitry Kozlyuk > --- > lib/librte_eal/windows/eal/eal_thread.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_eal/windows/eal/eal_thread.c b/lib/librte_eal/windows/eal/eal_thread.c > index 0591d4c7fb..af1e7fe2ea 100644 > --- a/lib/librte_eal/windows/eal/eal_thread.c > +++ b/lib/librte_eal/windows/eal/eal_thread.c > @@ -147,8 +147,8 @@ eal_thread_create(pthread_t *thread) > if (!th) > return -1; > > - SetPriorityClass(GetCurrentProcess(), REALTIME_PRIORITY_CLASS); > - SetThreadPriority(th, THREAD_PRIORITY_TIME_CRITICAL); > + SetPriorityClass(GetCurrentProcess(), NORMAL_PRIORITY_CLASS); > + SetThreadPriority(th, THREAD_PRIORITY_NORMAL); > > return 0; > } > -- > 2.16.1.windows.4 > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd