patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: dpdk-dev <dev@dpdk.org>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
	dpdk stable <stable@dpdk.org>,
	 Lance Richardson <lance.richardson@broadcom.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/bnxt: fix to not overwrite error message
Date: Fri, 20 Dec 2019 18:51:28 -0800
Message-ID: <CACZ4nhs3bEc0uSFKN-c_L5-rcWXgcovVakFaUTSXx7fSji8dyw@mail.gmail.com> (raw)
In-Reply-To: <20191221024218.56582-1-ajit.khaparde@broadcom.com>

On Fri, Dec 20, 2019 at 6:42 PM Ajit Khaparde <ajit.khaparde@broadcom.com>
wrote:

> In some cases when flow creation fails, we  overwrite the specific
> error message with a generic error message. This patch fixes it.
>
> Fixes: d24610f7bfda ("net/bnxt: allow flow creation when RSS is enabled")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Reviewed-by: Lance Richardson <lance.richardson@broadcom.com>
>
Patch applied to dpdk-next-net-brcm


> ---
>  drivers/net/bnxt/bnxt_flow.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c
> index 707aedcec..cde1fa41c 100644
> --- a/drivers/net/bnxt/bnxt_flow.c
> +++ b/drivers/net/bnxt/bnxt_flow.c
> @@ -1485,7 +1485,7 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,
>                 if (rxq && !vnic->rx_queue_cnt)
>                         rxq->vnic = &bp->vnic_info[0];
>         }
> -       return rc;
> +       return -rte_errno;
>  }
>
>  static
> @@ -1815,7 +1815,7 @@ bnxt_flow_create(struct rte_eth_dev *dev,
>                 rte_flow_error_set(error, 0,
>                                    RTE_FLOW_ERROR_TYPE_NONE, NULL,
>                                    "Flow with pattern exists, updating
> destination queue");
> -       else
> +       else if (!rte_errno)
>                 rte_flow_error_set(error, -ret,
>                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
>                                    "Failed to create flow.");
> --
> 2.21.0 (Apple Git-122.2)
>
>

      reply	other threads:[~2019-12-21  2:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-21  2:42 [dpdk-stable] " Ajit Khaparde
2019-12-21  2:51 ` Ajit Khaparde [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACZ4nhs3bEc0uSFKN-c_L5-rcWXgcovVakFaUTSXx7fSji8dyw@mail.gmail.com \
    --to=ajit.khaparde@broadcom.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=lance.richardson@broadcom.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git