From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D76BA04B0 for ; Thu, 13 Aug 2020 06:30:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2523E1C020; Thu, 13 Aug 2020 06:30:02 +0200 (CEST) Received: from mail-oo1-f66.google.com (mail-oo1-f66.google.com [209.85.161.66]) by dpdk.org (Postfix) with ESMTP id 144961BFF3 for ; Thu, 13 Aug 2020 06:30:01 +0200 (CEST) Received: by mail-oo1-f66.google.com with SMTP id j16so959348ooc.7 for ; Wed, 12 Aug 2020 21:30:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=l4eD6CUuKfZNUe4oMGIsxe2TVy1McysWnFINriWYvbE=; b=B2mDJHymjei/5MnOXnPPYNy9OhNREExU9r8KnBiqyLKI2r1OsI1DXqWwUgs4dcNoZb QT5kwu75pf+FlozBCZpwBBpqWSY1JfiGG7uSBfqRZXkxX2uPq5OwcheItIuq47NuX0rh REG1BiyIkJtAFaulb2SdbTQ3Sy49XgmzHWrjM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l4eD6CUuKfZNUe4oMGIsxe2TVy1McysWnFINriWYvbE=; b=RTtOg820hhZ6FukSyaIJn89WXY8IE8ktIHIlapvP6KYYEQoX+lgsufQLqsVerhg+vh YA67krdc0aa6qFfCXVQI9PGTszhEaB+L5Jxa1mYU3UgcQTu4YyjVeTENRA5/PbrTwOVa tbPozK8HtcdYumhmIDdYer9iTDh8snoLg51M/I9ZChLSPJ4lTadZzzf2j2hHpB9uYtyK VgiyLuQ+SvBg1KBUZ8h8UxSwlym3SjDlHMCKVyjKSE3H7sPRJXbIrAdF6inPq8eugz7j 0bcTAm8x0Mfp45G+uiASvK0n7GY3Sk/a14WaH/S63Mt3PinWHQ5e0BLwdlodQPKNaiHD yV/A== X-Gm-Message-State: AOAM53358M30gqz0s7TGX1DE34zDtgziRm6iuhrGRfzDrm1Ft80beAbF 5Bxn2VYYt8X51gTIJ+H3ZiMM+KYx5WTTE0krpevd5g== X-Google-Smtp-Source: ABdhPJwsLvr10opbnhBQSFA9CbPZKOVgRGfd1itReZPfVmtM+MVg/R3//y2GHQWLs7e3vFDZjya+bz8NkXRaBIt2rYQ= X-Received: by 2002:a4a:e92e:: with SMTP id a14mr2999170ooe.23.1597293000141; Wed, 12 Aug 2020 21:30:00 -0700 (PDT) MIME-Version: 1.0 References: <20200812035235.32516-1-kalesh-anakkur.purayil@broadcom.com> <46749d3e5468b12d77f586181651666c38deffae.camel@debian.org> In-Reply-To: <46749d3e5468b12d77f586181651666c38deffae.camel@debian.org> From: Ajit Khaparde Date: Wed, 12 Aug 2020 21:29:44 -0700 Message-ID: To: Luca Boccassi Cc: Kalesh A P , dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-stable] [PATCH 19.11 1/2] net/bnxt: support speed capabilities query X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Luca, On Wed, Aug 12, 2020 at 1:38 AM Luca Boccassi wrote: > On Wed, 2020-08-12 at 09:22 +0530, Kalesh A P wrote: > > From: Kalesh AP > > > > [ upstream commit 85cf7f2bba0f665fe91710cd1cf0ca852f73890a ] > > > > Added information about supported speeds for the port in the > > "dev_infos_get". As other PMDs are returning the speed capabilities, > > apps may expect this behavior from bnxt PMD. > > > > Signed-off-by: Kalesh AP > > Reviewed-by: Ajit Khaparde > > --- > > drivers/net/bnxt/bnxt_ethdev.c | 36 ++++++++++++++++++++++++++++++++++++ > > 1 file changed, 36 insertions(+) > > > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c > b/drivers/net/bnxt/bnxt_ethdev.c > > index fe240b6..90e1a33 100644 > > --- a/drivers/net/bnxt/bnxt_ethdev.c > > +++ b/drivers/net/bnxt/bnxt_ethdev.c > > @@ -490,6 +490,40 @@ static int bnxt_shutdown_nic(struct bnxt *bp) > > * Device configuration and status function > > */ > > > > +static uint32_t bnxt_get_speed_capabilities(struct bnxt *bp) > > +{ > > + uint32_t link_speed = bp->link_info.support_speeds; > > + uint32_t speed_capa = 0; > > + > > + if (link_speed & HWRM_PORT_PHY_QCFG_OUTPUT_LINK_SPEED_100MB) > > + speed_capa |= ETH_LINK_SPEED_100M; > > + if (link_speed & HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_SPEEDS_100MBHD) > > + speed_capa |= ETH_LINK_SPEED_100M_HD; > > + if (link_speed & HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_SPEEDS_1GB) > > + speed_capa |= ETH_LINK_SPEED_1G; > > + if (link_speed & HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_SPEEDS_2_5GB) > > + speed_capa |= ETH_LINK_SPEED_2_5G; > > + if (link_speed & HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_SPEEDS_10GB) > > + speed_capa |= ETH_LINK_SPEED_10G; > > + if (link_speed & HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_SPEEDS_20GB) > > + speed_capa |= ETH_LINK_SPEED_20G; > > + if (link_speed & HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_SPEEDS_25GB) > > + speed_capa |= ETH_LINK_SPEED_25G; > > + if (link_speed & HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_SPEEDS_40GB) > > + speed_capa |= ETH_LINK_SPEED_40G; > > + if (link_speed & HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_SPEEDS_50GB) > > + speed_capa |= ETH_LINK_SPEED_50G; > > + if (link_speed & HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_SPEEDS_100GB) > > + speed_capa |= ETH_LINK_SPEED_100G; > > + > > + if (bp->link_info.auto_mode == > HWRM_PORT_PHY_QCFG_OUTPUT_AUTO_MODE_NONE) > > + speed_capa |= ETH_LINK_SPEED_FIXED; > > + else > > + speed_capa |= ETH_LINK_SPEED_AUTONEG; > > + > > + return speed_capa; > > +} > > + > > static int bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev, > > struct rte_eth_dev_info *dev_info) > > { > > @@ -533,6 +567,8 @@ static int bnxt_dev_info_get_op(struct rte_eth_dev > *eth_dev, > > dev_info->tx_offload_capa = BNXT_DEV_TX_OFFLOAD_SUPPORT; > > dev_info->flow_type_rss_offloads = BNXT_ETH_RSS_SUPPORT; > > > > + dev_info->speed_capa = bnxt_get_speed_capabilities(bp); > > + > > /* *INDENT-OFF* */ > > dev_info->default_rxconf = (struct rte_eth_rxconf) { > > .rx_thresh = { > > Hi, > > This smells like a feature? 20.02 does not have it, so what happens if > a user expects this to work and upgrades from 19.11.x to 20.02? > Well in this example, the user will see a regression. A dumb question.. Does it ever happen that a user upgrades from an LTS like 19.11.x to 20.02? Thanks Ajit > > -- > Kind regards, > Luca Boccassi >