From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Weifeng Li <liweifeng96@126.com>
Cc: Somnath Kotur <somnath.kotur@broadcom.com>,
dpdk-dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v2] net/bnxt: fix nested lock at bond mode
Date: Mon, 12 Jul 2021 21:22:41 -0700 [thread overview]
Message-ID: <CACZ4nhuM+FvoSV79D=xrnSgSfJH2N-yD4qwq7SyOsdeygX-skw@mail.gmail.com> (raw)
In-Reply-To: <1625307642-1360-1-git-send-email-liweifeng96@126.com>
[-- Attachment #1: Type: text/plain, Size: 2383 bytes --]
On Sat, Jul 3, 2021 at 3:21 AM Weifeng Li <liweifeng96@126.com> wrote:
> Bnxt register lsc callback (bond_ethdev_lsc_event_callback) when
> working at bond mode. This callback will dead lock when lsc
> interrupt triggered.
>
> lsc interrupt ->
> bnxt_handle_async_event ->
> bnxt_link_update_op ->
> bond_ethdev_lsc_event_callback (lsc_lock) ->
> bnxt_link_update_op ->
> bond_ethdev_lsc_event_callback (lsc_lock dead lock)
>
> Fixes: c2faa1d1969e ("net/bnxt: add support for LSC interrupt event")
> Cc: stable@dpdk.org
>
> Signed-off-by: Weifeng Li <liweifeng96@126.com>
>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Updated the commit headline to "fix nested lock during bonding" during
merge.
Patch applied to dpdk-next-net-brcm. Thanks
> ---
> v2: fix coding style issues
> ---
> drivers/net/bnxt/bnxt_cpr.c | 2 ++
> drivers/net/bnxt/bnxt_ethdev.c | 5 -----
> 2 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c
> index 2c7fd78..f4c9c72 100644
> --- a/drivers/net/bnxt/bnxt_cpr.c
> +++ b/drivers/net/bnxt/bnxt_cpr.c
> @@ -111,6 +111,8 @@ void bnxt_handle_async_event(struct bnxt *bp,
> case HWRM_ASYNC_EVENT_CMPL_EVENT_ID_LINK_SPEED_CFG_CHANGE:
> /* FALLTHROUGH */
> bnxt_link_update_op(bp->eth_dev, 0);
> + rte_eth_dev_callback_process(bp->eth_dev,
> + RTE_ETH_EVENT_INTR_LSC, NULL);
> break;
> case HWRM_ASYNC_EVENT_CMPL_EVENT_ID_PF_DRVR_UNLOAD:
> PMD_DRV_LOG(INFO, "Async event: PF driver unloaded\n");
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c
> b/drivers/net/bnxt/bnxt_ethdev.c
> index 495c6cd..619b7b8 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -1844,11 +1844,6 @@ int bnxt_link_update_op(struct rte_eth_dev
> *eth_dev, int wait_to_complete)
> if (new.link_status != eth_dev->data->dev_link.link_status ||
> new.link_speed != eth_dev->data->dev_link.link_speed) {
> rte_eth_linkstatus_set(eth_dev, &new);
> -
> - rte_eth_dev_callback_process(eth_dev,
> - RTE_ETH_EVENT_INTR_LSC,
> - NULL);
> -
> bnxt_print_link_info(eth_dev);
> }
>
> --
> 1.8.3.1
>
>
prev parent reply other threads:[~2021-07-13 4:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-03 9:57 [dpdk-stable] [PATCH] " Weifeng Li
2021-07-03 10:20 ` [dpdk-stable] [PATCH v2] " Weifeng Li
2021-07-13 4:22 ` Ajit Khaparde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACZ4nhuM+FvoSV79D=xrnSgSfJH2N-yD4qwq7SyOsdeygX-skw@mail.gmail.com' \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=liweifeng96@126.com \
--cc=somnath.kotur@broadcom.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).