From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by dpdk.org (Postfix) with ESMTP id 68CB45F44 for ; Wed, 14 Nov 2018 12:36:43 +0100 (CET) Received: by mail-ed1-f66.google.com with SMTP id r27so10398125eda.0 for ; Wed, 14 Nov 2018 03:36:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kNTgAOTLPtTTFPTWaf3a7WOQxRz9wlO7JdqKeaujkxs=; b=hHXzx2+/PKBpIyM0HJvAy1i6Lorn2w0VyUUrIADkA9uFzAA3iUP9f3TEfqZQLuznF6 9j5kFB8x/ymDPWuY7khwPJWe9qkYTHmoPowUkYcthV0uBdcQNbHLyZkmUDbSA2yRJmBX IeZtJt60bWJq+hoiVArnPOKfpu7ZSQFQx9+KzH5QtDDgu9E1QKOI8mIpNipg953ql780 0mP6buxRANRdZWUcp3ZMW4k3LA8Wz5rfWx/ySDX+ZxOLYiNUoLhTS7S5L6ZJXpcDM9eU r6eIzbw4Vdx0z2abkTL8CI1eksu+NlSve+xGqR83Pct91hvlobdbUX6GKpB5Vuq2HEsk 2KEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kNTgAOTLPtTTFPTWaf3a7WOQxRz9wlO7JdqKeaujkxs=; b=stkTqV774Q8bnLm93aH6x4Rpu/5CkbEdcInDp55Hrzt32xkwhGSVaX51yoVp8Vqz/Q p6KbF5mdxPaqwZqk5INKUC2lXT+cR4DkFhis6TChMqvfq0Z37jwbVcg8KqlAY2eYq+hx QdvxmfIJouSvTkLtGFWpwNgh0KumqqAEoILPEKRWRPZ+VZmB9VG1RplRb4LvG74TWxvu Z4+elW1fVMMqJ4dFQOgLskRR1iGbYohpp8ZXjRtWGOMNlwX2QYZXggOqzje/BcS6ksWD hxYpA+hxxJNL1l9rTQMYcrcdPRV6YODJgkUYDbb3Sxzz/K9mKqEaIWyO+6VmTl0TsebG n76Q== X-Gm-Message-State: AGRZ1gLnFbz2qm/WdHkbuYkkGKibE34YjmH0KxMcM1VJGocIrNI8Ha+h mMxMcE+dIN8CmwvItHQzPvNJaFr4gGetiFyyy9OTzA== X-Google-Smtp-Source: AJdET5caeurmMjJ9QOrLJEIpmeX3H2Y9GR6Zw+5mu6sUvEef9XA5DKVEeE3efhP3meCz4HxgxqYb+U4FxW0YNpG7FD4= X-Received: by 2002:a17:906:6c97:: with SMTP id s23-v6mr1611641ejr.79.1542195403035; Wed, 14 Nov 2018 03:36:43 -0800 (PST) MIME-Version: 1.0 References: <20181029125329.17729-20-bluca@debian.org> <20181108180111.25873-1-bluca@debian.org> <20181108180111.25873-11-bluca@debian.org> <1542047709.11515.6.camel@debian.org> <1542193670.11515.8.camel@debian.org> In-Reply-To: <1542193670.11515.8.camel@debian.org> From: Alejandro Lucero Date: Wed, 14 Nov 2018 11:36:31 +0000 Message-ID: To: Luca Boccassi Cc: "Burakov, Anatoly" , dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-stable] patch 'bus/pci: compare kernel driver instead of interrupt handler' has been queued to LTS release 16.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Nov 2018 11:36:43 -0000 On Wed, Nov 14, 2018 at 11:07 AM Luca Boccassi wrote: > On Wed, 2018-11-14 at 10:02 +0000, Alejandro Lucero wrote: > > Hi Luca, > > > > On Mon, Nov 12, 2018 at 6:35 PM Luca Boccassi > > wrote: > > > > > On Thu, 2018-11-08 at 18:01 +0000, Luca Boccassi wrote: > > > > Hi, > > > > > > > > FYI, your patch has been queued to LTS release 16.11.9 > > > > > > > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable > > > > yet. > > > > It will be pushed if I get no objections before 11/10/18. So > > > > please > > > > shout if anyone has objections. > > > > > > > > Also note that after the patch there's a diff of the upstream > > > > commit > > > > vs the patch applied > > > > to the branch. If the code is different (ie: not only metadata > > > > diffs), due for example to > > > > a change in context or macro names, please double check it. > > > > > > > > Thanks. > > > > > > > > Luca Boccassi > > > > > > > > --- > > > > From 0df09603d47c1e38140b747baa8b712e70f5df51 Mon Sep 17 00:00:00 > > > > 2001 > > > > From: Alejandro Lucero > > > > Date: Thu, 25 Oct 2018 11:49:28 +0100 > > > > Subject: [PATCH] bus/pci: compare kernel driver instead of > > > > interrupt > > > > handler > > > > > > > > [ upstream commit 630deed612ca382f48a3ef4b65dfc74b7cd09cf9 ] > > > > > > > > Invoking the right pci read/write functions is based on interrupt > > > > handler type. However, this is not configured for secondary > > > > processes > > > > precluding to use those functions. > > > > > > > > This patch fixes the issue using the driver name the device is > > > > bound > > > > to instead. > > > > > > > > Fixes: 632b2d1deeed ("eal: provide functions to access PCI > > > > config") > > > > > > > > Signed-off-by: Alejandro Lucero > > > > Acked-by: Anatoly Burakov > > > > --- > > > > lib/librte_eal/linuxapp/eal/eal_pci.c | 33 ++++++++++++--------- > > > > ---- > > > > -- > > > > 1 file changed, 15 insertions(+), 18 deletions(-) > > > > > > > > diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c > > > > b/lib/librte_eal/linuxapp/eal/eal_pci.c > > > > index 02ec24150..85c7b3139 100644 > > > > --- a/lib/librte_eal/linuxapp/eal/eal_pci.c > > > > +++ b/lib/librte_eal/linuxapp/eal/eal_pci.c > > > > @@ -36,6 +36,7 @@ > > > > > > > > #include > > > > #include > > > > +#include > > > > > > Self-facepalm: this cannot work, as ethdev depends on eal. v2 > > > inlined > > > below. > > > > > > Alejandro and Anatoly, please have a quick look. Thanks! > > > > > > > > > > This patch is only necessary for PMDs which secondary support > > requires > > these pci read/write accesses. > > AFAIK, it is just NFP PMD having this need, and multiprocess support > > will > > be added in 19.02, so it is not a big problem to not apply this > > patch. > > Hi, > > So I can drop both this and 939e666bc0796940ae91535002e1a1c9196eae02 ? > > I can not find what you refer to. Which commit is that one? > -- > Kind regards, > Luca Boccassi >