From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94DC7A04E7 for ; Thu, 5 Nov 2020 19:03:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4EB4B23D; Thu, 5 Nov 2020 19:03:00 +0100 (CET) Received: from mail-oo1-f68.google.com (mail-oo1-f68.google.com [209.85.161.68]) by dpdk.org (Postfix) with ESMTP id 5379F23D for ; Thu, 5 Nov 2020 19:02:59 +0100 (CET) Received: by mail-oo1-f68.google.com with SMTP id j41so637847oof.12 for ; Thu, 05 Nov 2020 10:02:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GyVy/rKi2pkBmjpkgmFdCGFAb8d9hEmoBZ0hKz6+5gM=; b=TTZd1MCk+nRQYNTJBz3YTNXzG0FUbNR7sI5o9l7HMsnQyBW8nvMYJNHYiAqv+aSDsg Vzw/1W+tHvn78VS/hTZpwykNLZmZ+kK7Y3QsYBtI8y5xRTZQtKq0unzaiDNJpVAdL0BX vZBYz1eyEu+M6bIokpDGbbt7oL22QR+3zypGI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GyVy/rKi2pkBmjpkgmFdCGFAb8d9hEmoBZ0hKz6+5gM=; b=XqkrzlY8nTGMGKdbrIpNv9S5zPGTwC63p28QRBRFHyUJ+BB08jDxcg4pCmJJN21QzQ xEpmMA9Pn152DDVQiZzUM//obIbebEy3aSnqz7dPE6oj+pdFD8ISvDIAipCRKA1EG3eg wLVP7C0TH4xR6ITIxvVv7zUwkX5IgdJHst90MXylrD7d7Xzv0PgNmCWoyhTg0sRO35rc vvRQ3sn05QY9qvE9WsX1y+synQC5sb2Ep+wuz+20VN8iOCesHHNl7s2VrHmO/Sn0A8Fe LinO9GH7OURCYD2eXDPiL3pcbwOfQWXhhWWeMpSK9Hs6IHVl0JM2fOHaGbX2oTx5zHik aXTA== X-Gm-Message-State: AOAM532c96L7Q/wkXWD30K2THXTjZD6SdhgYlWUoW9g2wPC12JvtCgPk ciWqdk8SfgRhCLP1ylJ5trCytxpAQjLzMTwlkgw2Uw== X-Google-Smtp-Source: ABdhPJzsIP0SUdtcWhAbUij5Mxb7h6iXorqDBpy0Vh4mc72xFs4DVl5TCnLAo7osizIJA3WrPiXFSBapn9JZjODafFw= X-Received: by 2002:a4a:9806:: with SMTP id y6mr2653975ooi.45.1604599377250; Thu, 05 Nov 2020 10:02:57 -0800 (PST) MIME-Version: 1.0 References: <4da07e46-cf17-57ac-c38d-aa82aacc895e@intel.com> <20201105174424.4131345-1-thomas@monjalon.net> In-Reply-To: <20201105174424.4131345-1-thomas@monjalon.net> From: Lance Richardson Date: Thu, 5 Nov 2020 13:02:46 -0500 Message-ID: To: Thomas Monjalon Cc: dev@dpdk.org, Ferruh Yigit , David Marchand , Olivier Matz , Andrew Rybchenko , Maxime Coquelin , stable@dpdk.org, Wenzhuo Lu , Beilei Xing , Bernard Iremonger , Steve Yang Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-stable] [PATCH 1/1] app/testpmd: revert max Rx packet length adjustment X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Thu, Nov 5, 2020 at 12:51 PM Thomas Monjalon wrote: > > The fix of max_rx_pkt_len for allowing VLAN packets in all cases > was breaking configuration of some drivers. Example with virtio: > > Ethdev port_id=0 max_rx_pkt_len 11229 > max valid value 9728 > Fail to configure port 0 > > Trying to fix the logic was revealing other issues in some drivers. > That's why it is decided to revert. > > The workaround for the original issue would be > to set the MTU explicitly from the application > with rte_eth_dev_set_mtu(). > > Fixes: f6870a7ed6b3 ("app/testpmd: fix max Rx packet length for VLAN packet") > Cc: stable@dpdk.org > > Reported-by: Andrew Rybchenko > Signed-off-by: Thomas Monjalon > --- Acked-by: Lance Richardson