From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38D4EA0C42 for ; Fri, 7 May 2021 23:35:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 25368410E0; Fri, 7 May 2021 23:35:35 +0200 (CEST) Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) by mails.dpdk.org (Postfix) with ESMTP id C6ACE4013F for ; Fri, 7 May 2021 23:35:31 +0200 (CEST) Received: by mail-oi1-f172.google.com with SMTP id l6so10023561oii.1 for ; Fri, 07 May 2021 14:35:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SPl8muacHBKGyIbwKTcMG1+cfQdn7necbyMYoWsNsOs=; b=HO0HL86sroUz8FVu0l4shsFXtVT3UvB6hrIm8opvPI7PYZytHm/+D3Cn7LVIG/69qG V+v9sTYpfrn+Q0aRfwLH17e0IweCdrDkgqqr5iJZYkASm6u6H7BWKsVjoyUAXLOc/j/K iYc5p5ZO8FU5ZacS4g79ve9+243wxwPoz7DhU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SPl8muacHBKGyIbwKTcMG1+cfQdn7necbyMYoWsNsOs=; b=it5gEPgtr+LnFDMk4lJ8CzAfQ08L7fRdvJXRNnLhCPWa5hLCyZIz3162nEC+yg1Tqp Iefhxz+3gnp0HPG4X9K7VB3QU8K6GIWl6ggJ8AENeuTowoaHi5gjm96lED4XiuuSfelm +WWOqHZ4OsWDQvkeZAB1bKvhLwMwJ3KFyHpfgDS9t/l7oyZBjyWc6leORANirBqxnnEN hbz0pMkeqhQdIPWMtNeEzjWPKId8oRIknAhrrGQ+/vPT6DqTyGhTZhPpU7Bj3lqmCm07 cx1UPH73rC2zGioyajpbJqgceV2/XNBqkHM3dV26UaS4h5O3lG4p4i8Hp/AQO8t6hdue xCww== X-Gm-Message-State: AOAM530MO/Sf6yxonRaPpTjEPVftNFB9oGTE0PBkkAmDUiwfwlFoKl0p ay0zM7u8W++Ckv3a+6n6K0eIYLgRYbN/x0/7Rtpgeg== X-Google-Smtp-Source: ABdhPJzq3RLlnZCEG4gapx3TBOf1jrZYbhuZtzbQKE7nIojXlxzy3QTJi4hJ/8Z/Tw1ayidVydCuY04EXvAchEEXCFM= X-Received: by 2002:a05:6808:1408:: with SMTP id w8mr2905743oiv.81.1620423330912; Fri, 07 May 2021 14:35:30 -0700 (PDT) MIME-Version: 1.0 References: <20210507181025.84012-1-lance.richardson@broadcom.com> <20210507190657.84927-1-lance.richardson@broadcom.com> <20210507235146.133c3706@sovereign> In-Reply-To: <20210507235146.133c3706@sovereign> From: Lance Richardson Date: Fri, 7 May 2021 17:35:20 -0400 Message-ID: To: Dmitry Kozlyuk Cc: Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , dev@dpdk.org, dpdk stable Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000000bc07d05c1c4353c" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-stable] [PATCH v2] eal: fix memory mapping for 32-bit targets X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" --0000000000000bc07d05c1c4353c Content-Type: text/plain; charset="UTF-8" On Fri, May 7, 2021 at 4:51 PM Dmitry Kozlyuk wrote: > > 2021-05-07 15:06 (UTC-0400), Lance Richardson: > [...] > > diff --git a/lib/eal/unix/eal_unix_memory.c b/lib/eal/unix/eal_unix_memory.c > > index ec7156df96..41a94a7511 100644 > > --- a/lib/eal/unix/eal_unix_memory.c > > +++ b/lib/eal/unix/eal_unix_memory.c > > @@ -24,14 +24,14 @@ > > > > static void * > > mem_map(void *requested_addr, size_t size, int prot, int flags, > > - int fd, size_t offset) > > + int fd, uint64_t offset) > > { > > void *virt = mmap(requested_addr, size, prot, flags, fd, offset); > > if (virt == MAP_FAILED) { > > RTE_LOG(DEBUG, EAL, > > - "Cannot mmap(%p, 0x%zx, 0x%x, 0x%x, %d, 0x%zx): %s\n", > > - requested_addr, size, prot, flags, fd, offset, > > - strerror(errno)); > > + "Cannot mmap(%p, 0x%zx, 0x%x, 0x%x, %d, 0x%llx): %s\n", > > + requested_addr, size, prot, flags, fd, > > + (unsigned long long)offset, strerror(errno)); > > Why not PRIx64? Good point. %llx made sense for off_t. Thanks, Lance --0000000000000bc07d05c1c4353c--