[-- Attachment #1: Type: text/plain, Size: 1335 bytes --] Fix two issues found when writing PMD unit tests for HW ptype and L4 checksum offload: - The version field in the IPv6 header was being set to zero, which prevented hardware from recognizing it as IPv6. The IP version field is now set to six. - The payload_len field was being initialized using host byte order, which (among other things) resulted in incorrect L4 checksum computation. The payload_len field is now set using network (big-endian) byte order. Fixes: 92073ef961ee ("bond: unit tests") Cc: stable@dpdk.org Signed-off-by: Lance Richardson <lance.richardson@broadcom.com> --- app/test/packet_burst_generator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test/packet_burst_generator.c b/app/test/packet_burst_generator.c index f203f9d09e..8b390853a2 100644 --- a/app/test/packet_burst_generator.c +++ b/app/test/packet_burst_generator.c @@ -141,8 +141,8 @@ uint16_t initialize_ipv6_header(struct rte_ipv6_hdr *ip_hdr, uint8_t *src_addr, uint8_t *dst_addr, uint16_t pkt_data_len) { - ip_hdr->vtc_flow = 0; - ip_hdr->payload_len = pkt_data_len; + ip_hdr->vtc_flow = rte_cpu_to_be_32(0x60000000); /* Set version to 6. */ + ip_hdr->payload_len = rte_cpu_to_be_16(pkt_data_len); ip_hdr->proto = IPPROTO_UDP; ip_hdr->hop_limits = IP_DEFTTL; -- 2.25.1
On Fri, Mar 26, 2021 at 5:37 PM Lance Richardson <lance.richardson@broadcom.com> wrote: > > Fix two issues found when writing PMD unit tests for HW ptype and > L4 checksum offload: Would those unit tests be interesting to other pmd driver writers? > > - The version field in the IPv6 header was being set to zero, > which prevented hardware from recognizing it as IPv6. The > IP version field is now set to six. > - The payload_len field was being initialized using host byte > order, which (among other things) resulted in incorrect L4 > checksum computation. The payload_len field is now set using > network (big-endian) byte order. > > Fixes: 92073ef961ee ("bond: unit tests") Odd that this never got caught before, I guess nobody ran the bonding test with ipv6. Adding new maintainers for the bonding code since this helper is only used in the bonding ut. Should we take this in 21.05 or wait 21.08? > Cc: stable@dpdk.org > > Signed-off-by: Lance Richardson <lance.richardson@broadcom.com> Reviewed-by: David Marchand <david.marchand@redhat.com> -- David Marchand
[-- Attachment #1: Type: text/plain, Size: 589 bytes --] On Tue, May 11, 2021 at 10:31 AM David Marchand <david.marchand@redhat.com> wrote: > > On Fri, Mar 26, 2021 at 5:37 PM Lance Richardson > <lance.richardson@broadcom.com> wrote: > > > > Fix two issues found when writing PMD unit tests for HW ptype and > > L4 checksum offload: > > Would those unit tests be interesting to other pmd driver writers? > I think so, although some adjustments would be needed to account for differences in hardware capabilities. The tests I've written so far are still very much a work in progress, but I hope to have something ready for RFC in the near future.
[-- Attachment #1: Type: text/plain, Size: 773 bytes --] On Tue, May 11, 2021 at 10:42 AM Lance Richardson <lance.richardson@broadcom.com> wrote: > > On Tue, May 11, 2021 at 10:31 AM David Marchand > <david.marchand@redhat.com> wrote: > > > > On Fri, Mar 26, 2021 at 5:37 PM Lance Richardson > > <lance.richardson@broadcom.com> wrote: > > > > > > Fix two issues found when writing PMD unit tests for HW ptype and > > > L4 checksum offload: > > > > Would those unit tests be interesting to other pmd driver writers? > > > I think so, although some adjustments would be needed to account > for differences in hardware capabilities. The tests I've written so far > are still very much a work in progress, but I hope to have something > ready for RFC in the near future. What is the current status of this patch? Thanks, Lance
On Mon, Jun 21, 2021 at 2:41 PM Lance Richardson
<lance.richardson@broadcom.com> wrote:
>
> On Tue, May 11, 2021 at 10:42 AM Lance Richardson
> <lance.richardson@broadcom.com> wrote:
> >
> > On Tue, May 11, 2021 at 10:31 AM David Marchand
> > <david.marchand@redhat.com> wrote:
> > >
> > > On Fri, Mar 26, 2021 at 5:37 PM Lance Richardson
> > > <lance.richardson@broadcom.com> wrote:
> > > >
> > > > Fix two issues found when writing PMD unit tests for HW ptype and
> > > > L4 checksum offload:
> > >
> > > Would those unit tests be interesting to other pmd driver writers?
> > >
> > I think so, although some adjustments would be needed to account
> > for differences in hardware capabilities. The tests I've written so far
> > are still very much a work in progress, but I hope to have something
> > ready for RFC in the near future.
>
> What is the current status of this patch?
I wanted feedback from bonding guys, but I'll get it in v21.08 now.
Thanks for the heads up.
--
David Marchand
On Fri, Mar 26, 2021 at 5:37 PM Lance Richardson
<lance.richardson@broadcom.com> wrote:
>
> Fix two issues found when writing PMD unit tests for HW ptype and
> L4 checksum offload:
>
> - The version field in the IPv6 header was being set to zero,
> which prevented hardware from recognizing it as IPv6. The
> IP version field is now set to six.
> - The payload_len field was being initialized using host byte
> order, which (among other things) resulted in incorrect L4
> checksum computation. The payload_len field is now set using
> network (big-endian) byte order.
>
> Fixes: 92073ef961ee ("bond: unit tests")
> Cc: stable@dpdk.org
>
> Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
Applied, thanks.
--
David Marchand