From: Lance Richardson <lance.richardson@broadcom.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>,
Xiaoyun Li <xiaoyun.li@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>,
Steve Yang <stevex.yang@intel.com>,
dev@dpdk.org, stable@dpdk.org, oulijun@huawei.com,
wisamm@mellanox.com, lihuisong@huawei.com
Subject: Re: [dpdk-stable] [PATCH v5] app/testpmd: fix setting maximum packet length
Date: Mon, 25 Jan 2021 22:45:05 -0500 [thread overview]
Message-ID: <CADyeNEBUB3wth=TS7+X12+_WZf+eR-bVH1GROrtCuKWx6gyXEQ@mail.gmail.com> (raw)
In-Reply-To: <1efbcf83-8b7f-682c-7494-44cacef55e36@intel.com>
[-- Attachment #1: Type: text/plain, Size: 2216 bytes --]
On Mon, Jan 25, 2021 at 7:44 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> >> + if (rx_offloads != port->dev_conf.rxmode.offloads) {
> >> + uint16_t qid;
> >> +
> >> + port->dev_conf.rxmode.offloads = rx_offloads;
> >> +
> >> + /* Apply JUMBO_FRAME offload configuration to Rx queue(s) */
> >> + for (qid = 0; qid < port->dev_info.nb_rx_queues; qid++) {
> >> + if (on)
> >> + port->rx_conf[qid].offloads |= DEV_RX_OFFLOAD_JUMBO_FRAME;
> >> + else
> >> + port->rx_conf[qid].offloads &= ~DEV_RX_OFFLOAD_JUMBO_FRAME;
> >> + }
> >
> > Is it correct to set per-queue offloads that aren't advertised by the PMD
> > as supported in rx_queue_offload_capa?
> >
>
> 'port->rx_conf[]' is testpmd struct, and 'port->dev_conf.rxmode.offloads' values
> are reflected to 'port->rx_conf[].offloads' for all queues.
>
> We should set the offload in 'port->rx_conf[].offloads' if it is set in
> 'port->dev_conf.rxmode.offloads'.
>
> If a port has capability for 'JUMBO_FRAME', 'port->rx_conf[].offloads' can have
> it. And the port level capability is already checked above.
>
I'm still not 100% clear about the per-queue offload question.
With this patch, and jumbo max packet size configured (on the command
line in this case), I see:
testpmd> show port 0 rx_offload configuration
Rx Offloading Configuration of port 0 :
Port : JUMBO_FRAME
Queue[ 0] : JUMBO_FRAME
testpmd> show port 0 rx_offload capabilities
Rx Offloading Capabilities of port 0 :
Per Queue :
Per Port : VLAN_STRIP IPV4_CKSUM UDP_CKSUM TCP_CKSUM TCP_LRO
OUTER_IPV4_CKSUM VLAN_FILTER VLAN_EXTEND JUMBO_FRAME SCATTER TIMESTAMP
KEEP_CRC OUTER_UDP_CKSUM RSS_HASH
Yet if I configure a jumbo MTU starting with standard max packet size,
jumbo is only enabled at the port level:
testpmd> port config mtu 0 9000
testpmd> port start all
testpmd> show port 0 rx_offload configuration
Rx Offloading Configuration of port 0 :
Port : JUMBO_FRAME
Queue[ 0] :
It still seems odd for a per-queue offload to be enabled on a PMD that
doesn't support per-queue receive offloads.
next prev parent reply other threads:[~2021-01-26 3:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210125083202.38267-1-stevex.yang@intel.com>
2021-01-25 18:15 ` Ferruh Yigit
2021-01-25 19:41 ` Lance Richardson
2021-01-26 0:44 ` Ferruh Yigit
2021-01-26 3:22 ` Lance Richardson
2021-01-26 3:45 ` Lance Richardson [this message]
2021-01-26 7:54 ` Li, Xiaoyun
2021-01-26 11:01 ` Ferruh Yigit
2021-01-28 21:36 ` Lance Richardson
2021-01-28 22:12 ` Ferruh Yigit
2021-01-26 9:02 ` Wisam Monther
2021-01-27 3:04 ` Li, Xiaoyun
2021-01-28 1:57 ` Chen, BoX C
2021-01-28 9:18 ` Wisam Monther
2021-01-28 9:26 ` Ferruh Yigit
2021-01-28 11:08 ` Wisam Monther
2021-01-28 12:07 ` [dpdk-stable] [PATCH v6] " Ferruh Yigit
2021-01-29 9:34 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADyeNEBUB3wth=TS7+X12+_WZf+eR-bVH1GROrtCuKWx6gyXEQ@mail.gmail.com' \
--to=lance.richardson@broadcom.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=lihuisong@huawei.com \
--cc=oulijun@huawei.com \
--cc=stable@dpdk.org \
--cc=stevex.yang@intel.com \
--cc=wenzhuo.lu@intel.com \
--cc=wisamm@mellanox.com \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).