From: Lance Richardson <lance.richardson@broadcom.com>
To: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
Cc: Thomas Monjalon <thomas@monjalon.net>,
Bruce Richardson <bruce.richardson@intel.com>,
aconole@redhat.com, maicolgabriel@hotmail.com, dev@dpdk.org,
Ruifeng Wang <ruifeng.wang@arm.com>,
stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v11 2/7] net/bnxt: fix aarch32 build
Date: Wed, 9 Dec 2020 09:10:04 -0500 [thread overview]
Message-ID: <CADyeNEBUc=6Dce6gsAY7x=d1M=JHr=0Aq=hsPSy6W9Jq_7CXRw@mail.gmail.com> (raw)
In-Reply-To: <1607518771-7564-3-git-send-email-juraj.linkes@pantheon.tech>
On Wed, Dec 9, 2020 at 7:59 AM Juraj Linkeš <juraj.linkes@pantheon.tech> wrote:
>
> From: Ruifeng Wang <ruifeng.wang@arm.com>
>
> NEON vector path of the PMD needs aarch64 support. But it was
> enabled for aarch32 build as well because aarch32 build had
> cpu_family set to aarch64. So build for aarch32 will fail due
> to unsupported intrinsics.
>
> Fixed aarch32 build by updating meson file to execule NEON vector
> implementation for aarch32.
>
> Fixes: 398358341419 ("net/bnxt: support NEON")
> Cc: lance.richardson@broadcom.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---
> drivers/net/bnxt/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/meson.build b/drivers/net/bnxt/meson.build
> index 2896337b5..a2fd494da 100644
> --- a/drivers/net/bnxt/meson.build
> +++ b/drivers/net/bnxt/meson.build
> @@ -74,6 +74,6 @@ sources = files('bnxt_cpr.c',
>
> if arch_subdir == 'x86'
> sources += files('bnxt_rxtx_vec_sse.c')
> -elif arch_subdir == 'arm' and host_machine.cpu_family().startswith('aarch64')
> +elif arch_subdir == 'arm' and dpdk_conf.get('RTE_ARCH_64')
> sources += files('bnxt_rxtx_vec_neon.c')
> endif
> --
> 2.20.1
>
With this change, there should be no need for
http://patchwork.dpdk.org/patch/84864/
Reviewed-by: Lance Richardson <lance.richardson@broadcom.com>
--
This electronic communication and the information and any files transmitted
with it, or attached to it, are confidential and are intended solely for
the use of the individual or entity to whom it is addressed and may contain
information that is confidential, legally privileged, protected by privacy
laws, or otherwise restricted from disclosure to anyone else. If you are
not the intended recipient or the person responsible for delivering the
e-mail to the intended recipient, you are hereby notified that any use,
copying, distributing, dissemination, forwarding, printing, or copying of
this e-mail is strictly prohibited. If you received this e-mail in error,
please return the e-mail to the sender, delete it from your computer, and
destroy any printed copy of it.
next prev parent reply other threads:[~2020-12-09 14:10 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1600244472-29696-1-git-send-email-juraj.linkes@pantheon.tech>
[not found] ` <1607518771-7564-1-git-send-email-juraj.linkes@pantheon.tech>
2020-12-09 12:59 ` [dpdk-stable] [PATCH v11 1/7] net/sfc: " Juraj Linkeš
2020-12-09 13:37 ` [dpdk-stable] ***Spam*** " Andrew Rybchenko
2020-12-09 12:59 ` [dpdk-stable] [PATCH v11 2/7] net/bnxt: " Juraj Linkeš
2020-12-09 14:10 ` Lance Richardson [this message]
2020-12-09 14:16 ` Ruifeng Wang
2020-12-09 18:56 ` [dpdk-stable] [dpdk-dev] " Ajit Khaparde
2020-12-09 19:08 ` Ajit Khaparde
[not found] ` <1607675213-12061-1-git-send-email-juraj.linkes@pantheon.tech>
2020-12-11 8:26 ` [dpdk-stable] [PATCH v12 1/6] net/sfc: " Juraj Linkeš
2020-12-11 8:26 ` [dpdk-stable] [PATCH v12 2/6] net/bnxt: " Juraj Linkeš
[not found] ` <1615279005-30278-1-git-send-email-juraj.linkes@pantheon.tech>
2021-03-09 8:36 ` [dpdk-stable] [PATCH v13 1/7] net/sfc: " Juraj Linkeš
2021-03-09 8:36 ` [dpdk-stable] [PATCH v13 2/7] net/bnxt: " Juraj Linkeš
2021-03-09 8:36 ` [dpdk-stable] [PATCH v13 3/7] net/virtio: " Juraj Linkeš
[not found] ` <1615988163-17371-1-git-send-email-juraj.linkes@pantheon.tech>
2021-03-17 13:35 ` [dpdk-stable] [PATCH v14 1/7] net/sfc: " Juraj Linkeš
2021-03-17 13:35 ` [dpdk-stable] [PATCH v14 2/7] net/bnxt: " Juraj Linkeš
2021-03-17 13:35 ` [dpdk-stable] [PATCH v14 3/7] net/virtio: " Juraj Linkeš
[not found] ` <1618995020-4775-1-git-send-email-juraj.linkes@pantheon.tech>
2021-04-21 8:50 ` [dpdk-stable] [PATCH v16 1/8] net/sfc: " Juraj Linkeš
2021-04-21 9:04 ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
2021-04-21 10:06 ` Ruifeng Wang
2021-04-21 14:08 ` Juraj Linkeš
2021-04-21 14:20 ` Andrew Rybchenko
2021-04-21 8:50 ` [dpdk-stable] [PATCH v16 2/8] net/bnxt: " Juraj Linkeš
2021-04-21 8:50 ` [dpdk-stable] [PATCH v16 3/8] net/virtio: " Juraj Linkeš
2021-04-21 9:16 ` [dpdk-stable] [dpdk-dev] " Maxime Coquelin
[not found] ` <1619095749-7948-1-git-send-email-juraj.linkes@pantheon.tech>
2021-04-22 12:49 ` [dpdk-stable] [PATCH v17 1/8] net/sfc: " Juraj Linkeš
2021-04-22 12:49 ` [dpdk-stable] [PATCH v17 2/8] net/bnxt: " Juraj Linkeš
2021-04-22 18:50 ` Ajit Khaparde
2021-04-22 12:49 ` [dpdk-stable] [PATCH v17 3/8] net/virtio: " Juraj Linkeš
[not found] ` <1625664343-26498-1-git-send-email-juraj.linkes@pantheon.tech>
2021-07-07 13:25 ` [dpdk-stable] [PATCH v18 1/7] net/sfc: " Juraj Linkeš
2021-07-07 13:25 ` [dpdk-stable] [PATCH v18 2/7] net/bnxt: " Juraj Linkeš
2021-07-07 13:25 ` [dpdk-stable] [PATCH v18 3/7] net/virtio: " Juraj Linkeš
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADyeNEBUc=6Dce6gsAY7x=d1M=JHr=0Aq=hsPSy6W9Jq_7CXRw@mail.gmail.com' \
--to=lance.richardson@broadcom.com \
--cc=aconole@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=juraj.linkes@pantheon.tech \
--cc=maicolgabriel@hotmail.com \
--cc=ruifeng.wang@arm.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).