From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5CEACA0A0E for ; Mon, 10 May 2021 18:04:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 563F34003E; Mon, 10 May 2021 18:04:43 +0200 (CEST) Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) by mails.dpdk.org (Postfix) with ESMTP id A7E2C4003E for ; Mon, 10 May 2021 18:04:42 +0200 (CEST) Received: by mail-oi1-f182.google.com with SMTP id d21so16204695oic.11 for ; Mon, 10 May 2021 09:04:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SpdePANfMjq9XKhzij3FuD+P+YzxO5RHJBcwsevXIMI=; b=NoRKgkSTCKyoQPTkzJ3EBx58sZxBLcD8Ix9we5Z+y5jrBAyFrvR7qwSQJt5f1S8Y4T Vufrr1y4gUO9vEG72H/eLISI3gIsCX4dsYv/YP75JlSZjzDpd1rASF9+gY+dzBms8TUj fj6PEYO9rNG6ov7nqDAMLLApsV53ugNeC+37E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SpdePANfMjq9XKhzij3FuD+P+YzxO5RHJBcwsevXIMI=; b=E+Qh/rjiWBRYAyeICndsp5IOEUf7Ox1GPIiG6RPmNpJcwwxnSzVytS85OYTY38ZYnk SFxTIdWI/iSoy27ZOk/Ggae1TO9V0ed+Ad9adubIc+PDZSSM6pCmKvA8gtdaKHAMDEzF NGmeY4CPMTnLWlaX7gG6pqLVrPUu4+wbUnm2swh4rbYVb0YEjGEIOEzNBweWwjnYonjv uxNT+G76R8keu1VVXw/gSEofltEotVyNRDQ922M8YeKPtSSguwtfcMzJKqmEyCO6wOO3 8cC8L6kOezDShw5RRE+NTjaNQMIGDAd+WxlpJ0bEwhKHxti4s4g+J6NZIB+OOZXxHdMW 5/TQ== X-Gm-Message-State: AOAM531VCib8RPqSnHbt6f4CnvSGgip6D9bzD/w9YTwOAa+xph+m5vgR qgope6Vo1TD9H2LmZfImq9t2A8Ahdb88NK+7xQAqVQ== X-Google-Smtp-Source: ABdhPJydQNFmHnOR/329RbIPmayfRKjh5TI0rdbLDLrWSPXm5oeHAD1WfvaqI3iCOa526EdsvXGEPvjY6aavpkyQc7w= X-Received: by 2002:aca:211a:: with SMTP id 26mr18236366oiz.19.1620662681965; Mon, 10 May 2021 09:04:41 -0700 (PDT) MIME-Version: 1.0 References: <20210507181025.84012-1-lance.richardson@broadcom.com> <2003089.4ItjxMFgZf@thomas> <7d299b6c-80ba-cb35-f5ac-daf2a5670217@intel.com> <4580427.4aQfPY00Ab@thomas> In-Reply-To: <4580427.4aQfPY00Ab@thomas> From: Lance Richardson Date: Mon, 10 May 2021 12:04:31 -0400 Message-ID: To: Thomas Monjalon Cc: "Burakov, Anatoly" , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , dev@dpdk.org, dpdk stable Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000007978be05c1fbef86" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v3] eal: fix memory mapping for 32-bit targets X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" --0000000000007978be05c1fbef86 Content-Type: text/plain; charset="UTF-8" On Mon, May 10, 2021 at 11:55 AM Thomas Monjalon wrote: > 10/05/2021 17:31, Burakov, Anatoly: > > On 10-May-21 1:42 PM, Thomas Monjalon wrote: > > > +Cc Anatoly > > > > > > 08/05/2021 16:27, Lance Richardson: > > >> For 32-bit targets, size_t is normally a 32-bit type and > > >> does not have sufficient range to represent 64-bit offsets > > >> that can are needed when mapping PCI addresses. Use uint64_t > > >> instead. > > >> > > >> Found when attempting to run 32-bit Linux dpdk-testpmd > > >> using VFIO driver: > > >> > > >> EAL: pci_map_resource(): cannot map resource(63, 0xc0010000, \ > > >> 0x200000, 0x20000000000): Invalid argument ((nil)) > > >> > > >> Fixes: c4b89ecb64ea ("eal: introduce memory management wrappers") > > >> Cc: stable@dpdk.org > > >> Signed-off-by: Lance Richardson > > >> --- > > > > LGTM, although the Fixes: tag is probably wrong because IIRC previous > > versions did have the same issue. > > What should be the right Fixes tag Anatoly? > I think this would be more appropriate (prior to this commit, pci_map_resource() called mmap() directly with off_t offset, with this commit offset was narrowed to size_t before calling mmap()): Fixes: 2fd3567e5425 ("pci: use OS generic memory mapping functions") --0000000000007978be05c1fbef86--